column # changes auto cellHeight

adumesny · adumesny · commit 5b1cd50be2a4 · 2021-02-26T14:56:24.000-08:00
* fix changing column # `column(n)` now resizes `cellHeight:'auto'` to keep square
* update column.html demo to have fix cellHeight (makes it easier to see relayout for debugging)
diff --git a/demo/column.html b/demo/column.html
@@ -12,7 +12,7 @@
 </head>
 <body>
   <div class="container-fluid">
-    <h1>column() grid demo</h1>
+    <h1>column() grid demo (fix cellHeight)</h1>
     <div><span>Number of Columns:</span> <span id="column-text">12</span></div>
     <div>
       <label>Choose re-layout:</label>
@@ -41,7 +41,11 @@ <h1>column() grid demo</h1>
   </div>
 
   <script type="text/javascript">
-    let grid = GridStack.init({float: true});
+    let grid = GridStack.init({
+      float: true,
+      disableOneColumnMode: true, // prevent auto column for this manual demo
+      cellHeight: 100 // fixed as default 'auto' (square) makes it hard to test 1-3 column in actual large windows tests
+    });
     let text = document.querySelector('#column-text');
     let layout = 'moveScale';
 
diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -54,6 +54,7 @@ Change log
 - Dragging up and down now behave the same (used to require push WAY down past to swap/append). Also much more efficient collision code.
 - handle mid point of dragged over items (>50%) rather than a new row/column and check for the most covered when multiple items collide.
 - fix [1617](https://github.com/gridstack/gridstack.js/issues/1617) FireFox DOM order issue. Thanks [@marcel-necker](https://github.com/marcel-necker)
+- fix changing column # `column(n)` now resizes `cellHeight:'auto'` to keep square
 - add `drag | resize` events while dragging [1616](https://github.com/gridstack/gridstack.js/pull/1616). Thanks [@MrCorba](https://github.com/MrCorba)
 - add `GridStack.setupDragIn()` so user can update external draggable after the grid has been created [1637](https://github.com/gridstack/gridstack.js/issues/1637)
 
diff --git a/src/gridstack.ts b/src/gridstack.ts
@@ -298,7 +298,7 @@ export class GridStack {
 
     this._isAutoCellHeight = (this.opts.cellHeight === 'auto');
     if (this._isAutoCellHeight || this.opts.cellHeight === 'initial') {
-      // make the cell content square initially (will use resize event to keep it square)
+      // make the cell content square initially (will use resize/column event to keep it square)
       this.cellHeight(undefined, false);
     } else {
       this.cellHeight(this.opts.cellHeight, false);
@@ -685,6 +685,7 @@ export class GridStack {
       if (!domNodes.length) { domNodes = undefined; }
     }
     this.engine.updateNodeWidths(oldColumn, column, domNodes, layout);
+    if (this._isAutoCellHeight) this.cellHeight();
 
     // and trigger our event last...
     this._ignoreLayoutsNodeChange = true; // skip layout update
