Skip to content

Commit 4b62c33

Browse files
committed
Always require authentication with basic auth
When connection bound authentication is used, we must deny access if basci auth is used and a request does not have the basic auth header. Basic auth authenticate each and every request, so if it is missing this means such request is no more authenticated and we should not allow access based on our cached metadata in this case. Closes #41 Signed-off-by: Simo Sorce <simo@redhat.com>
1 parent b91b5d3 commit 4b62c33

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/mod_auth_gssapi.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,9 @@ static int mag_auth(request_rec *req)
587587
auth_header = apr_table_get(req->headers_in, "Authorization");
588588

589589
if (mc) {
590-
if (mc->established && !auth_header) {
590+
if (mc->established &&
591+
(auth_header == NULL) &&
592+
(mc->auth_type != AUTH_TYPE_BASIC)) {
591593
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, req,
592594
"Already established context found!");
593595
mag_set_req_data(req, cfg, mc);

0 commit comments

Comments
 (0)