Resize Regardless Orientation

Replace variables

Author: erigoni

lib/ImageResize.php

@@ -280,15 +280,15 @@ public function output($image_type = null, $quality = null)
     public function resizeToShortSide($max_short, $allow_enlarge = false)
     {
         if ($this->getSourceHeight() < $this->getSourceWidth()) {
-            $ratio = $height / $this->getSourceHeight();
+            $ratio = $max_short / $this->getSourceHeight();
             $width = $this->getSourceWidth() * $ratio;
 
-            $this->resize($width, $height, $allow_enlarge);
+            $this->resize($width, $max_short, $allow_enlarge);
         } else {
-            $ratio = $height / $this->getSourceWidth();
+            $ratio = $max_short / $this->getSourceWidth();
             $width = $this->getSourceHeight() * $ratio;
 
-            $this->resize($width, $height, $allow_enlarge);
+            $this->resize($width, $max_short, $allow_enlarge);
         }
 
         return $this;
@@ -304,15 +304,15 @@ public function resizeToShortSide($max_short, $allow_enlarge = false)
     public function resizeToLongSide($max_long, $allow_enlarge = false)
     {
         if ($this->getSourceHeight() > $this->getSourceWidth()) {
-            $ratio = $height / $this->getSourceHeight();
+            $ratio = $max_long / $this->getSourceHeight();
             $width = $this->getSourceWidth() * $ratio;
 
-            $this->resize($width, $height, $allow_enlarge);
+            $this->resize($width, $max_long, $allow_enlarge);
         } else {
-            $ratio = $height / $this->getSourceWidth();
+            $ratio = $max_long / $this->getSourceWidth();
             $width = $this->getSourceHeight() * $ratio;
 
-            $this->resize($width, $height, $allow_enlarge);
+            $this->resize($width, $max_long, $allow_enlarge);
         }
 
         return $this;

test/Test.php

@@ -121,6 +121,28 @@ public function testInvalidString()
      * Resize tests
      */
 
+    public function testResizeToLongSide()
+    {
+        $image = $this->createImage(200, 100, 'png');
+        $resize = new ImageResize($image);
+
+        $resize->resizeToLongSide(100);
+
+        $this->assertEquals(100, $resize->getDestWidth());
+        $this->assertEquals(50, $resize->getDestHeight());
+    }
+
+    public function testResizeToShortSide()
+    {
+        $image = $this->createImage(200, 100, 'png');
+        $resize = new ImageResize($image);
+
+        $resize->resizeToShortSide(50);
+
+        $this->assertEquals(100, $resize->getDestWidth());
+        $this->assertEquals(50, $resize->getDestHeight());
+    }
+
     public function testResizeToHeight()
     {
         $image = $this->createImage(200, 100, 'png');