#a bit sus - Code Broken - Undefined array key 3116

[Dagsi27]

In class: Hfig\MAPI\Property\PropertyStore

we have this line:

The problem is that i had one case where flags is like 6000 and the guide_off shows key to 3000. But the array "guids" has only 10 keys. So I got an error: {"status":500,"message":"Undefined array key 3116","detail":[]}

I apply a small workaround that helps to open the file properly:

when the guid_off is setting an false key it just continue. Other files ale also working fine. Do you had a simalary error? Can you maybe apply a fix for that or jsut add the small code from me?

[Dagsi27]

/# a bit sus
$guid_off = $flags >> 1;

// Workaround: Check if the calculated index is valid
if ($guid_off - 2 < 0 || $guid_off - 2 >= count($guids)) {
$this->logger->warning(sprintf(
"GUID offset out of bounds. Calculated offset: %d. Flags: %d. GUID array size: %d",
$guid_off - 2,
$flags,
count($guids)
));
continue; // Skip this property if the GUID offset is invalid
}

// Access the valid GUID
$guid = $guids[$guid_off - 2];

[swikrit]

Will the fix be implemented in a future update?

[Dagsi27]

If you need right now a solution you can take out these file to your project and implement the change that i wrote. It's like 3 files I can help you if you want. @swikrit

[swikrit]

@Dagsi27 Sorry for the late response, I'm in a bit of a habit of ignoring my github notifications 😅

Thanks for the offer to help, I applied the changes you posted and it just worked so it's unnecessary now. I don't know what the process is for making a PR but suggest this as a quick fix for people who are managing the library.

I made a PR with your fix @Dagsi27 Hopefully they apply it soon.