From 012a7e3ee577137cc188fd3ee1e5b6ff86b0933a Mon Sep 17 00:00:00 2001 From: Maximilian von Gaisberg <10868746+vongaisberg@users.noreply.github.com> Date: Tue, 8 Mar 2022 21:01:34 +0100 Subject: [PATCH 1/3] Fix regex for hostname validation --- lib/classes/validation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classes/validation.js b/lib/classes/validation.js index 3e8b21c..aa6a87f 100644 --- a/lib/classes/validation.js +++ b/lib/classes/validation.js @@ -54,7 +54,7 @@ class validation { * @var hostname * Regex for matching hostnames (RFC-1123) */ - hostname: /^(([a-zA-Z]|[a-zA-Z][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z]|[A-Za-z][A-Za-z0-9\-]*[A-Za-z0-9])|localhost$/, + hostname: /^((?!-))(xn--)?[a-z0-9][a-z0-9-_]{0,61}[a-z0-9]{0,1}\.(xn--)?([a-z0-9\-]{1,61}|[a-z0-9-]{1,30}\.[a-z]{2,})$/, /** * @var IPv4 From 33f25a4cd248a15169f0e18eec791bf10d693f04 Mon Sep 17 00:00:00 2001 From: Maximilian von Gaisberg <10868746+vongaisberg@users.noreply.github.com> Date: Tue, 8 Mar 2022 21:34:48 +0100 Subject: [PATCH 2/3] Add better error messages --- lib/classes/validation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classes/validation.js b/lib/classes/validation.js index aa6a87f..025dbad 100644 --- a/lib/classes/validation.js +++ b/lib/classes/validation.js @@ -122,7 +122,7 @@ class validation { if (opts.range.length >= 1) { opts.range.forEach(value => { scope.verify(value, (err, result) => { - if (err) return cb(scope.messages.range); + if (err) return cb(scope.messages.range + JSON.stringify(value)); }); }); } From ea112e7d6faed1cb81da769d5d8aafeb375b7812 Mon Sep 17 00:00:00 2001 From: Maximilian von Gaisberg <10868746+vongaisberg@users.noreply.github.com> Date: Tue, 8 Mar 2022 22:54:00 +0100 Subject: [PATCH 3/3] Remove all hostname validation checks --- lib/classes/validation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classes/validation.js b/lib/classes/validation.js index 025dbad..3fd5163 100644 --- a/lib/classes/validation.js +++ b/lib/classes/validation.js @@ -54,7 +54,7 @@ class validation { * @var hostname * Regex for matching hostnames (RFC-1123) */ - hostname: /^((?!-))(xn--)?[a-z0-9][a-z0-9-_]{0,61}[a-z0-9]{0,1}\.(xn--)?([a-z0-9\-]{1,61}|[a-z0-9-]{1,30}\.[a-z]{2,})$/, + hostname: /^.*$/, /** * @var IPv4