New Typescript bindings appear to contain errors

[lm-sousa]

The new Typescript bindings introduced in #613 and released with 0.16.0 seem to contain some errors.

../../node_modules/java/java.d.ts:4:13 - error TS2502: 'NodeJavaCore' is referenced directly or indirectly in its own type annotation.
4 declare var NodeJavaCore: NodeJavaCore.NodeAPI;
              ~~~~~~~~~~~~
../../node_modules/java/java.d.ts:4:40 - error TS2694: Namespace 'NodeJavaCore' has no exported member 'NodeAPI'.
4 declare var NodeJavaCore: NodeJavaCore.NodeAPI;
                                         ~~~~~~~
../../node_modules/java/java.d.ts:4:13 - error TS2502: 'NodeJavaCore' is referenced directly or indirectly in its own type annotation.
4 declare var NodeJavaCore: NodeJavaCore.NodeAPI;
              ~~~~~~~~~~~~
../../node_modules/java/java.d.ts:4:40 - error TS2694: Namespace 'NodeJavaCore' has no exported member 'NodeAPI'.
4 declare var NodeJavaCore: NodeJavaCore.NodeAPI;
                                         ~~~~~~~

This is the error log when trying to compile my TS sources in a package that has java@0.16.0 as a dependency.

[lm-sousa]

FYI, this was working in java@0.14.0 and @types/java@0.9.6

[lm-sousa]

It seems that:

declare var NodeJavaCore: NodeJavaCore.NodeAPI;

should become:

declare var NodeJavaCore: NodeJavaCore.Java;

[joeferner]

I tried reproducing the error with examples/lucene but couldn't manage to reproduce. But I agree it should be declare var NodeJavaCore: NodeJavaCore.Java;

Published 0.16.1, can you give that a try.

[lm-sousa]

Issue fixed on my end. I suspect you weren't able to reproduce due to type checking being disabled for libs in example/lucene.
https://github.com/joeferner/node-java/blob/master/examples/lucene/tsconfig.json#L111

If you are able to reproduce, i suggest tagging version 0.16.0 in npm as deprecated as it will break any package that uses typescript.