Skip to content

[Flow Control]: Cleanup: Remove PriorityName from PriorityBandConfig #2013

@LukeAVanDrie

Description

@LukeAVanDrie

What would you like to be added:
I would like to remove the PriorityName string field from the PriorityBandConfig struct and all downstream usages (metrics, logs, accessors).

Proposed Changes:

  1. Remove PriorityName from pkg/epp/flowcontrol/registry/config.go (and elsewhere in pkg/epp/flowcontrol).
  2. Remove validation logic checking for duplicate names.
  3. Update the DefaultPriorityBand template logic to stop generating names like Dynamic-<int>.
  4. Update Stats() and Prometheus metrics to identify bands solely by their integer Priority value.

Why is this needed:
Currently, priority bands are assigned a human-readable name (e.g., "High", "Dynamic-100"). However, the relationship between InferenceObjective resources and Priority Bands is N:1; multiple objectives can map to the same integer priority level.

Trying to assign a single name to a band shared by multiple objectives (e.g., "TenantA,TenantB") is complex and leads to ambiguous or confusing observability data.

Since the integer Priority is the unique identifier for the band, the string name provides little mechanical value and invites confusion. Removing it simplifies the configuration model and eliminates the ambiguity.

See: #2006 (comment).

In logging, we should replace this with the InferenceObjective info (Model) bound to the request. This info is being passed through in #2010.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions