Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Commit 36928fd

Browse files
committed
feat: update api for docs
1 parent 645adca commit 36928fd

File tree

6 files changed

+32
-40
lines changed

6 files changed

+32
-40
lines changed

ncovapi/admin.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,31 +84,30 @@ class RumorAdmin(BaseAdmin):
8484
class CityAdmin(BaseAdmin):
8585

8686
list_display = (
87-
'locationId', 'province', 'cityName', 'currentConfirmedCount',
87+
'province', 'cityName', 'currentConfirmedCount',
8888
'confirmedCount', 'suspectedCount', 'curedCount', 'deadCount'
8989
)
90-
search_fields = ('locationId', 'cityName', 'province__provinceName')
90+
search_fields = ('cityName', 'province__provinceName')
9191

9292

9393
@admin.register(models.Province)
9494
class ProvinceAdmin(BaseAdmin):
9595

9696
list_display = (
97-
'locationId', 'provinceName', 'currentConfirmedCount',
97+
'provinceName', 'currentConfirmedCount',
9898
'confirmedCount', 'suspectedCount', 'curedCount', 'deadCount'
9999
)
100-
search_fields = ('locationId', 'provinceName')
100+
search_fields = ('provinceName', )
101101

102102

103103
@admin.register(models.Country)
104104
class CountryAdmin(BaseAdmin):
105105

106106
list_display = (
107-
'locationId', 'continents', 'countryName', 'countryFullName',
107+
'continents', 'countryName', 'countryFullName',
108108
'currentConfirmedCount', 'confirmedCount',
109109
'suspectedCount', 'curedCount', 'deadCount'
110110
)
111111
search_fields = (
112-
'locationId', 'continents', 'countryFullName', 'countryShortCode',
113-
'countryName'
112+
'continents', 'countryFullName', 'countryShortCode', 'countryName'
114113
)

ncovapi/filters.py

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,45 +9,39 @@ class CharInFilter(django_filters.BaseInFilter, django_filters.CharFilter):
99

1010
class CityFilter(django_filters.rest_framework.FilterSet):
1111

12-
locationId = django_filters.CharFilter(lookup_expr='iexact')
13-
provinceName = django_filters.CharFilter(
14-
field_name='province__provinceName', lookup_expr='iexact')
15-
cityName = django_filters.CharFilter(lookup_expr='iexact')
12+
provinceShortNames = CharInFilter(
13+
field_name='province__provinceShortName', lookup_expr='in')
1614
cityNames = CharInFilter(
1715
field_name='cityName', lookup_expr='in')
1816

1917
class Meta:
2018
model = City
21-
fields = ['locationId', 'provinceName', 'cityName']
19+
fields = ['provinceShortNames', 'cityName']
2220

2321

2422
class ProvinceFilter(django_filters.rest_framework.FilterSet):
2523

26-
locationId = django_filters.CharFilter(lookup_expr='iexact')
27-
provinceName = django_filters.CharFilter(lookup_expr='iexact')
28-
provinceShortName = django_filters.CharFilter(lookup_expr='iexact')
24+
provinceShortNames = CharInFilter(
25+
field_name='provinceyName', lookup_expr='in')
2926
provinceNames = CharInFilter(
3027
field_name='provinceyName', lookup_expr='in')
3128

3229
class Meta:
3330
model = Province
34-
fields = ['id', 'locationId', 'provinceName', 'provinceShortName']
31+
fields = ['provinceName', 'provinceShortName']
3532

3633

3734
class CountryFilter(django_filters.rest_framework.FilterSet):
3835

39-
locationId = django_filters.CharFilter(lookup_expr='iexact')
40-
continents = django_filters.CharFilter(lookup_expr='iexact')
41-
countryShortCode = django_filters.CharFilter(lookup_expr='iexact')
42-
countryType = django_filters.CharFilter(lookup_expr='iexact')
43-
countryName = django_filters.CharFilter(lookup_expr='iexact')
44-
countryFullName = django_filters.CharFilter(lookup_expr='iexact')
36+
continents = CharInFilter(
37+
field_name='continents', lookup_expr='in')
38+
countryShortCodes = CharInFilter(
39+
field_name='countryShortCode', lookup_expr='in')
4540
countryNames = CharInFilter(
4641
field_name='countryName', lookup_expr='in')
4742

4843
class Meta:
4944
model = Country
5045
fields = [
51-
'locationId', 'continents', 'countryShortCode', 'countryType',
52-
'countryName', 'countryFullName'
46+
'continents', 'countryShortCode', 'countryName'
5347
]

ncovapi/models.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,11 +225,10 @@ class Meta:
225225
class Country(models.Model):
226226

227227
locationId = models.IntegerField()
228-
continents = models.CharField(max_length=50) #
229-
countryShortCode = models.CharField(max_length=20) #
230-
countryType = models.CharField(max_length=20) #
231-
countryName = models.CharField(max_length=50) #
232-
countryFullName = models.CharField(max_length=50) #
228+
continents = models.CharField(max_length=50)
229+
countryShortCode = models.CharField(max_length=20)
230+
countryName = models.CharField(max_length=50)
231+
countryFullName = models.CharField(max_length=50)
233232
currentConfirmedCount = models.IntegerField(default=0)
234233
confirmedCount = models.IntegerField(default=0)
235234
suspectedCount = models.IntegerField(default=0)

ncovapi/serializers.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class ProvinceSerializer(serializers.HyperlinkedModelSerializer):
9292
class Meta:
9393
model = Province
9494
fields = [
95-
'locationId', 'provinceName', 'provinceShortName',
95+
'provinceName', 'provinceShortName',
9696
'currentConfirmedCount', 'confirmedCount', 'suspectedCount',
9797
'curedCount', 'deadCount'
9898
]
@@ -103,7 +103,7 @@ class CitySerializer(serializers.ModelSerializer):
103103
class Meta:
104104
model = City
105105
fields = [
106-
'locationId', 'provinceName', 'cityName',
106+
'provinceName', 'cityName',
107107
'currentConfirmedCount', 'confirmedCount', 'suspectedCount',
108108
'curedCount', 'deadCount'
109109
]
@@ -113,8 +113,7 @@ class CountrySerializer(serializers.HyperlinkedModelSerializer):
113113
class Meta:
114114
model = Country
115115
fields = [
116-
'locationId', 'continents', 'countryShortCode',
117-
'countryType', 'countryName', 'countryFullName',
118-
'currentConfirmedCount', 'confirmedCount', 'suspectedCount',
119-
'curedCount', 'deadCount'
116+
'continents', 'countryShortCode', 'countryName',
117+
'countryFullName', 'currentConfirmedCount', 'confirmedCount',
118+
'suspectedCount', 'curedCount', 'deadCount'
120119
]

ncovapi/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
path('cities/<str:cityName>/', views.CityRetrieveByNameView.as_view(), name='city-detail-by-name'),
1515
path('provinces/', views.ProvinceListView.as_view(), name='province-list'),
1616
path('provinces/<int:pk>/', views.ProvinceRetrieveView.as_view(), name='province-detail'),
17-
path('provinces/<str:provinceName>/', views.ProvinceRetrieveByNameView.as_view(), name='province-detail-by-name'),
17+
path('provinces/<str:provinceShortName>/', views.ProvinceRetrieveByNameView.as_view(), name='province-detail-by-name'),
1818
path('countries/', views.CountryListView.as_view(), name='country-list'),
1919
path('countries/<int:pk>/', views.CountryRetrieveView.as_view(), name='country-detail'),
2020
path('countries/<str:countryName>/', views.CountryRetrieveByNameView.as_view(), name='country-detail-by-name'),

ncovapi/views.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,20 +101,21 @@ def dispatch(self, *args, **kwargs):
101101
class ProvinceRetrieveByNameView(APIView):
102102
"""通过省名获取数据"""
103103

104-
def get_object(self, provinceName):
104+
def get_object(self, provinceShortName):
105105
try:
106106
crawler = Crawler.objects.order_by('-id').first()
107107
except Crawler.DoesNotExist:
108108
raise Http404
109109
try:
110110
return Province.objects.filter(
111-
crawler=crawler, provinceName=provinceName).first()
111+
crawler=crawler,
112+
provinceShortName=provinceShortName).first()
112113
except Province.DoesNotExist:
113114
raise Http404
114115

115116
@method_decorator(cache_page(TIMEOUT))
116-
def get(self, request, provinceName):
117-
province = self.get_object(provinceName)
117+
def get(self, request, provinceShortName):
118+
province = self.get_object(provinceShortName)
118119
serializer = ProvinceSerializer(province)
119120
return Response(serializer.data)
120121

0 commit comments

Comments
 (0)