Rename WindowID to WindowId across codebase

Replaces all instances of the WindowID typedef and related usage with WindowId for consistency and clarity. Updates function signatures, class members, event constructors, and documentation comments in all window-related source and header files for Linux, macOS, and Windows platforms.

Author: lijy91

.cursor/rules/global-registry.mdc

@@ -47,24 +47,24 @@ class Registry {
 public:
     using Key = void*;
     using Ptr = std::shared_ptr<T>;
-    
+
     static Registry& GetInstance();
-    
+
     // Register an object with a key
     bool Register(Key key, Ptr object);
-    
+
     // Unregister an object by key
     bool Unregister(Key key);
-    
+
     // Retrieve an object by key
     Ptr Get(Key key) const;
-    
+
     // Check if key exists
     bool Contains(Key key) const;
-    
+
     // Clear all entries
     void Clear();
-    
+
     // Get snapshot of all entries
     std::unordered_map<Key, Ptr> GetSnapshot() const;
 
@@ -97,13 +97,13 @@ public:
         // Create native window
         HWND hwnd = CreateWindowEx(...);
         if (!hwnd) return nullptr;
-        
+
         // Create wrapper
         auto window = std::make_shared<Window>(static_cast<void*>(hwnd));
-        
+
         // Register in global registry
         GlobalRegistry<Window>().Register(static_cast<void*>(hwnd), window);
-        
+
         return window;
     }
 };
@@ -117,13 +117,13 @@ public:
         // Create native window
         NSWindow* nswindow = [[NSWindow alloc] init...];
         if (!nswindow) return nullptr;
-        
+
         // Create wrapper
         auto window = std::make_shared<Window>(static_cast<void*>(nswindow));
-        
+
         // Register in global registry
         GlobalRegistry<Window>().Register(static_cast<void*>(nswindow), window);
-        
+
         return window;
     }
 };
@@ -140,11 +140,11 @@ When platform code calls back with native handles, look up the wrapper:
 LRESULT CALLBACK WindowProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) {
     // Look up Window wrapper from native handle
     auto window = GlobalRegistry<Window>().Get(static_cast<void*>(hwnd));
-    
+
     if (!window) {
         return DefWindowProc(hwnd, msg, wp, lp);
     }
-    
+
     // Handle message using wrapper
     switch (msg) {
         case WM_SIZE:
@@ -154,7 +154,7 @@ LRESULT CALLBACK WindowProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) {
             // Emit WindowMovedEvent
             break;
     }
-    
+
     return DefWindowProc(hwnd, msg, wp, lp);
 }
 ```
@@ -166,11 +166,11 @@ LRESULT CALLBACK WindowProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) {
 
 - (void)windowDidMove:(NSNotification*)notification {
     NSWindow* nswindow = [notification object];
-    
+
     // Look up Window wrapper from native handle
     auto window = nativeapi::GlobalRegistry<nativeapi::Window>()
         .Get(static_cast<void*>(nswindow));
-    
+
     if (window) {
         // Emit WindowMovedEvent using wrapper
         NSRect frame = [nswindow frame];
@@ -185,12 +185,12 @@ LRESULT CALLBACK WindowProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) {
 
 ```cpp
 // GTK signal callback
-static void OnWindowStateChanged(GtkWidget* widget, 
+static void OnWindowStateChanged(GtkWidget* widget,
                                  GdkEventWindowState* event,
                                  gpointer user_data) {
     // Look up Window wrapper from native handle
     auto window = GlobalRegistry<Window>().Get(static_cast<void*>(widget));
-    
+
     if (window) {
         // Emit appropriate event using wrapper
         if (event->new_window_state & GDK_WINDOW_STATE_MAXIMIZED) {
@@ -210,12 +210,12 @@ public:
     ~Window() {
         // Get native handle before pimpl_ is destroyed
         void* native = GetNativeObject();
-        
+
         if (native) {
             // Unregister from global registry
             GlobalRegistry<Window>().Unregister(native);
         }
-        
+
         // pimpl_ destructor will clean up native object
     }
 
@@ -228,26 +228,26 @@ private:
 Or unregister when manager destroys object:
 
 ```cpp
-bool WindowManager::Destroy(WindowID id) {
+bool WindowManager::Destroy(WindowId id) {
     auto it = windows_.find(id);
     if (it == windows_.end()) {
         return false;
     }
-    
+
     auto window = it->second;
-    
+
     // Unregister from global registry
     void* native = window->GetNativeObject();
     if (native) {
         GlobalRegistry<Window>().Unregister(native);
     }
-    
+
     // Remove from local registry
     windows_.erase(it);
-    
+
     // Emit event
     Emit<WindowClosedEvent>(id);
-    
+
     return true;
 }
 ```
@@ -286,10 +286,10 @@ void OnMenuCommand(HMENU hmenu, UINT item_id) {
 // macOS
 - (void)menuItemClicked:(id)sender {
     NSMenuItem* nsitem = (NSMenuItem*)sender;
-    
+
     auto item = nativeapi::GlobalRegistry<nativeapi::MenuItem>()
         .Get(static_cast<void*>(nsitem));
-    
+
     if (item) {
         item->Trigger();
     }
@@ -299,7 +299,7 @@ void OnMenuCommand(HMENU hmenu, UINT item_id) {
 static void OnMenuItemActivated(GtkMenuItem* menu_item, gpointer user_data) {
     auto item = nativeapi::GlobalRegistry<nativeapi::MenuItem>()
         .Get(static_cast<void*>(menu_item));
-    
+
     if (item) {
         item->Trigger();
     }
@@ -497,7 +497,7 @@ auto snapshot = GlobalRegistry<Window>().GetSnapshot();
 std::cout << "Registered windows: " << snapshot.size() << std::endl;
 
 for (const auto& [native, window] : snapshot) {
-    std::cout << "  - " << window->GetTitle() 
+    std::cout << "  - " << window->GetTitle()
               << " (native: " << native << ")" << std::endl;
 }
 ```

.cursor/rules/pimpl-pattern.mdc

@@ -38,7 +38,7 @@ public:
 private:
     // Forward declaration only - no definition
     class Impl;
-    
+
     // Pointer to implementation
     std::unique_ptr<Impl> pimpl_;
 };
@@ -68,14 +68,14 @@ namespace nativeapi {
 class Window::Impl {
 public:
     Impl(HWND hwnd) : hwnd_(hwnd) {}
-    
+
     HWND hwnd_;  // Windows-specific handle
     // Other Windows-specific state...
 };
 
 Window::Window() : pimpl_(std::make_unique<Impl>(nullptr)) {}
 
-Window::Window(void* window) 
+Window::Window(void* window)
     : pimpl_(std::make_unique<Impl>(static_cast<HWND>(window))) {}
 
 Window::~Window() = default;  // unique_ptr handles cleanup
@@ -101,14 +101,14 @@ namespace nativeapi {
 class Window::Impl {
 public:
     Impl(NSWindow* window) : window_(window) {}
-    
+
     NSWindow* window_;  // macOS-specific handle
     // Other macOS-specific state...
 };
 
 Window::Window() : pimpl_(std::make_unique<Impl>(nil)) {}
 
-Window::Window(void* window) 
+Window::Window(void* window)
     : pimpl_(std::make_unique<Impl>(static_cast<NSWindow*>(window))) {}
 
 Window::~Window() = default;
@@ -134,14 +134,14 @@ namespace nativeapi {
 class Window::Impl {
 public:
     Impl(GtkWidget* window) : window_(window) {}
-    
+
     GtkWidget* window_;  // GTK-specific handle
     // Other GTK-specific state...
 };
 
 Window::Window() : pimpl_(std::make_unique<Impl>(nullptr)) {}
 
-Window::Window(void* window) 
+Window::Window(void* window)
     : pimpl_(std::make_unique<Impl>(static_cast<GtkWidget*>(window))) {}
 
 Window::~Window() = default;
@@ -172,7 +172,7 @@ class MyClass {
 public:
     MyClass();
     virtual ~MyClass();
-    
+
     void DoSomething();
 
 private:
@@ -218,7 +218,7 @@ class MyClass {
 public:
     MyClass();
     virtual ~MyClass();  // Virtual if used as base class
-    
+
     // Copy/move operations - handle appropriately
     MyClass(const MyClass&) = delete;
     MyClass& operator=(const MyClass&) = delete;
@@ -256,7 +256,7 @@ TrayIcon::TrayIcon() : TrayIcon(nullptr) {}  // Delegate to parameterized constr
 TrayIcon::TrayIcon(void* tray) {
     // Handle both cases in one place
     NSStatusItem* status_item = nullptr;
-    
+
     if (tray == nullptr) {
         // Create new platform object
         NSStatusBar* status_bar = [NSStatusBar systemStatusBar];
@@ -265,10 +265,10 @@ TrayIcon::TrayIcon(void* tray) {
         // Wrap existing platform object
         status_item = (__bridge NSStatusItem*)tray;
     }
-    
+
     // All initialization logic in one place
     pimpl_ = std::make_unique<Impl>(status_item);
-    
+
     // Additional setup that applies to both cases
     if (pimpl_->status_item_) {
         // Configure the status item...
@@ -291,7 +291,7 @@ TrayIcon::TrayIcon() : pimpl_(std::make_unique<Impl>()) {
     NSStatusBar* status_bar = [NSStatusBar systemStatusBar];
     NSStatusItem* status_item = [status_bar statusItemWithLength:NSVariableStatusItemLength];
     pimpl_->status_item_ = status_item;
-    
+
     // Setup code duplicated...
     if (pimpl_->status_item_) {
         // Configure...
@@ -301,7 +301,7 @@ TrayIcon::TrayIcon() : pimpl_(std::make_unique<Impl>()) {
 TrayIcon::TrayIcon(void* tray) : pimpl_(std::make_unique<Impl>()) {
     NSStatusItem* status_item = (__bridge NSStatusItem*)tray;
     pimpl_->status_item_ = status_item;
-    
+
     // Same setup code duplicated again!
     if (pimpl_->status_item_) {
         // Configure...
@@ -318,17 +318,17 @@ class WindowManager : public EventEmitter<WindowEvent> {
 public:
     static WindowManager& GetInstance();
     virtual ~WindowManager();
-    
+
     std::shared_ptr<Window> Create(const WindowOptions& options);
 
 private:
     WindowManager();  // Private constructor
-    
+
     class Impl;
     std::unique_ptr<Impl> pimpl_;
-    
+
     // Public data that doesn't vary by platform
-    std::unordered_map<WindowID, std::shared_ptr<Window>> windows_;
+    std::unordered_map<WindowId, std::shared_ptr<Window>> windows_;
 };
 ```
 
@@ -365,11 +365,11 @@ public:
 };
 
 // Windows implementation
-Window::Window(void* window) 
+Window::Window(void* window)
     : pimpl_(std::make_unique<Impl>(static_cast<HWND>(window))) {}
 
 // macOS implementation
-Window::Window(void* window) 
+Window::Window(void* window)
     : pimpl_(std::make_unique<Impl>(static_cast<NSWindow*>(window))) {}
 ```
 
@@ -380,7 +380,7 @@ Always validate before using platform handles:
 ```cpp
 void Window::Show() {
     if (!pimpl_->hwnd_) return;  // Or pimpl_->window_, pimpl_->gtk_window_
-    
+
     // Safe to use handle
     ShowWindow(pimpl_->hwnd_, SW_SHOW);
 }