Refactor Image class for platform-specific implementations

Moved the generic Image implementation from image.cpp to a new macOS-specific implementation in image_macos.mm. The Image constructor is now private and only accessible via factory methods. Updated tray icon and menu code on macOS to use native NSImage objects from Image. Minor formatting and whitespace adjustments in tray icon code for Linux and Windows.

Author: lijy91

include/nativeapi.h

@@ -9,6 +9,7 @@
 #include "../src/foundation/event_emitter.h"
 #include "../src/foundation/geometry.h"
 #include "../src/foundation/id_allocator.h"
+#include "../src/image.h"
 #include "../src/keyboard_event.h"
 #include "../src/keyboard_monitor.h"
 #include "../src/menu.h"
@@ -18,14 +19,14 @@
 #include "../src/window.h"
 #include "../src/window_event.h"
 #include "../src/window_manager.h"
-#include "../src/image.h"
 
 // Include necessary headers for C API
 #include "../src/capi/accessibility_manager_c.h"
 #include "../src/capi/app_runner_c.h"
 #include "../src/capi/display_c.h"
 #include "../src/capi/display_manager_c.h"
 #include "../src/capi/geometry_c.h"
+#include "../src/capi/image_c.h"
 #include "../src/capi/keyboard_monitor_c.h"
 #include "../src/capi/menu_c.h"
 #include "../src/capi/run_example_app_c.h"
@@ -34,4 +35,3 @@
 #include "../src/capi/tray_manager_c.h"
 #include "../src/capi/window_c.h"
 #include "../src/capi/window_manager_c.h"
-#include "../src/capi/image_c.h"

src/capi/tray_icon_c.cpp

@@ -84,7 +84,8 @@ native_tray_icon_id_t native_tray_icon_get_id(native_tray_icon_t tray_icon) {
   }
 }
 
-void native_tray_icon_set_icon(native_tray_icon_t tray_icon, native_image_t image) {
+void native_tray_icon_set_icon(native_tray_icon_t tray_icon,
+                               native_image_t image) {
   if (!tray_icon)
     return;
 

src/image.cpp

@@ -71,13 +71,6 @@ namespace nativeapi {
  */
 class Image : public NativeObjectProvider {
  public:
-  /**
-   * @brief Default constructor.
-   *
-   * Creates an empty image instance.
-   */
-  Image();
-
   /**
    * @brief Destructor.
    *
@@ -244,6 +237,14 @@ class Image : public NativeObjectProvider {
   void* GetNativeObjectInternal() const override;
 
  private:
+  /**
+   * @brief Private default constructor for use by factory methods.
+   *
+   * This constructor is private to prevent direct instantiation of Image objects.
+   * Use the static factory methods (FromFile, FromBase64, FromSystemIcon) instead.
+   */
+  Image();
+
   /**
    * @brief Private implementation class using the PIMPL idiom.
    *

src/image.h

@@ -17,7 +17,7 @@ namespace nativeapi {
 class TrayIcon::Impl {
  public:
   std::shared_ptr<Image> image_;
-  
+
   Impl(AppIndicator* indicator)
       : app_indicator_(indicator),
         title_(std::nullopt),
@@ -86,12 +86,12 @@ void TrayIcon::SetIcon(std::shared_ptr<Image> image) {
   if (image) {
     // For now, use a placeholder implementation
     // TODO: Implement proper Image to file conversion
-    app_indicator_set_icon_full(pimpl_->app_indicator_, "application-default-icon",
-                                "Tray Icon");
+    app_indicator_set_icon_full(pimpl_->app_indicator_,
+                                "application-default-icon", "Tray Icon");
   } else {
     // Use default icon
-    app_indicator_set_icon_full(pimpl_->app_indicator_, "application-default-icon",
-                                "Tray Icon");
+    app_indicator_set_icon_full(pimpl_->app_indicator_,
+                                "application-default-icon", "Tray Icon");
   }
 }