Upgrade to use SDL3 version of libtcod

Author: HexDecimal

.github/workflows/python-package.yml

@@ -47,7 +47,7 @@ jobs:
       - name: APT update
         run: sudo apt-get update
       - name: Install APT dependencies
-        run: sudo apt-get install libsdl2-dev
+        run: sudo apt-get install libsdl3-dev
       - uses: actions/checkout@v4
         with:
           fetch-depth: ${{ env.git-depth }}
@@ -71,7 +71,7 @@ jobs:
     strategy:
       matrix:
         os: ["windows-latest", "macos-latest"]
-        sdl-version: ["2.0.14", "2.0.16", "2.30.0"]
+        sdl-version: ["3.2.10"]
       fail-fast: true
     steps:
       - uses: actions/checkout@v4
@@ -122,7 +122,7 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           sudo apt-get update
-          sudo apt-get install libsdl2-dev xvfb
+          sudo apt-get install libsdl3-dev xvfb
       - name: Install Python dependencies
         run: |
           python -m pip install --upgrade pip
@@ -163,7 +163,7 @@ jobs:
       - name: Install APT dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install libsdl2-dev
+          sudo apt-get install libsdl3-dev
       - uses: actions/checkout@v4
         with:
           fetch-depth: ${{ env.git-depth }}
@@ -204,7 +204,7 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           sudo apt-get update
-          sudo apt-get install libsdl2-dev
+          sudo apt-get install libsdl3-dev
       - name: Run tox
         run: |
           tox -vv
@@ -248,7 +248,7 @@ jobs:
           CIBW_BEFORE_ALL_LINUX: >
             yum install -y epel-release &&
             yum-config-manager --enable epel &&
-            yum install -y SDL2-devel
+            yum install -y SDL3-devel
           CIBW_BEFORE_TEST: pip install numpy
           CIBW_TEST_COMMAND: python -c "import tcod.context"
           # Skip test on emulated architectures
@@ -287,7 +287,7 @@ jobs:
       - name: Install Python dependencies
         run: pip install -r requirements.txt
       - name: Prepare package
-        # Downloads SDL2 for the later step.
+        # Downloads SDL for the later step.
         run: python build_sdl.py
       - name: Build wheels
         uses: pypa/cibuildwheel@v2.19.2

.gitignore

@@ -69,10 +69,10 @@ Release/
 tcod/_*.c
 tcod/_*.pyd
 .benchmarks
-dependencies/SDL2*
+dependencies/SDL*
 tcod/x86
 tcod/x64
-tcod/SDL2.framework
+tcod/SDL?.framework
 deb_dist/
 *.tar.gz
 tcod/version.py

.readthedocs.yaml

@@ -5,11 +5,11 @@
 version: 2
 
 build:
-  os: ubuntu-22.04
+  os: ubuntu-24.04
   tools:
     python: "3.11"
   apt_packages:
-    - libsdl2-dev
+    - libsdl3-dev
 
 submodules:
   include: all

README.rst

@@ -48,7 +48,7 @@ For the most part it's just::
 ==============
 * Python 3.8+
 * Windows, Linux, or MacOS X 10.9+.
-* On Linux, requires libsdl2 (2.0.10+).
+* On Linux, requires libsdl3 (3.2.0+).
 
 ===========
  Changelog

build_libtcod.py

@@ -207,11 +207,11 @@ def walk_sources(directory: str) -> Iterator[str]:
 for include in includes:
     try:
         ffi.cdef(include.header)
-    except Exception:
+    except Exception:  # noqa: PERF203
         # Print the source, for debugging.
         print(f"Error with: {include.path}")
         for i, line in enumerate(include.header.split("\n"), 1):
-            print("%03i %s" % (i, line))
+            print(f"{i:03i} {line}")
         raise
 ffi.cdef(
     """
@@ -220,7 +220,10 @@ def walk_sources(directory: str) -> Iterator[str]:
 )
 ffi.set_source(
     module_name,
-    "#include <tcod/cffi.h>\n#include <SDL.h>",
+    """\
+#include <tcod/cffi.h>
+#define SDL_oldnames_h_
+#include <SDL3/SDL.h>""",
     include_dirs=include_dirs,
     library_dirs=library_dirs,
     sources=sources,