better recover after crash sorting

Author: jcupitt

CHANGELOG.md

@@ -12,6 +12,8 @@
 - implement program window menu
 - program displays info for builtins
 - generic load/save/open/replace/close for filemodel
+- better recover after crash sorting
+- fix an infobar race
 
 ## 9.0.12 2025/08/21
 

TODO

@@ -1,10 +1,4 @@
 
-- recover after crash should sort by date, then by PID
-
-	blank line between days?
-
-	implement click on column name to sort by that col
-
 - program: ^W should parse the text and block on error
 
 - program: don't get save-before-close box for modified toolkits?

src/recover.c

@@ -386,13 +386,12 @@ recover_refresh(Recover *recover)
 	(void) path_map_dir(PATH_TMP, "*.ws",
 		(path_map_fn) store_add_file, model);
 
-	// sort by PID, then date, then time
+	// sort by date, then time
+	// we can't sort by PID easily -- they are not numeric on all
+	// platforms
 	GtkMultiSorter *multi = gtk_multi_sorter_new();
 	GtkExpression *expression;
 	GtkSorter *sorter;
-	expression = gtk_property_expression_new(RECOVERFILE_TYPE, NULL, "pid");
-	sorter = GTK_SORTER(gtk_string_sorter_new(expression));
-	gtk_multi_sorter_append(multi, sorter);
 	expression = gtk_property_expression_new(RECOVERFILE_TYPE, NULL, "date");
 	sorter = GTK_SORTER(gtk_string_sorter_new(expression));
 	gtk_multi_sorter_append(multi, sorter);
@@ -512,15 +511,6 @@ recover_init(Recover *recover)
 	gtk_column_view_column_set_expand(GTK_COLUMN_VIEW_COLUMN(column), TRUE);
 	gtk_column_view_append_column(GTK_COLUMN_VIEW(recover->table), column);
 
-	factory = gtk_signal_list_item_factory_new();
-	g_object_set_qdata(G_OBJECT(factory), recover_quark, recover);
-	g_signal_connect(factory, "setup",
-		G_CALLBACK(recover_setup_item), "pid");
-	g_signal_connect(factory, "bind",
-		G_CALLBACK(recover_bind_item), "pid");
-	column = gtk_column_view_column_new("Process ID", factory);
-	gtk_column_view_append_column(GTK_COLUMN_VIEW(recover->table), column);
-
 	factory = gtk_signal_list_item_factory_new();
 	g_object_set_qdata(G_OBJECT(factory), recover_quark, recover);
 	g_signal_connect(factory, "setup",
@@ -539,6 +529,15 @@ recover_init(Recover *recover)
 	column = gtk_column_view_column_new("HH:MM.ss", factory);
 	gtk_column_view_append_column(GTK_COLUMN_VIEW(recover->table), column);
 
+	factory = gtk_signal_list_item_factory_new();
+	g_object_set_qdata(G_OBJECT(factory), recover_quark, recover);
+	g_signal_connect(factory, "setup",
+		G_CALLBACK(recover_setup_item), "pid");
+	g_signal_connect(factory, "bind",
+		G_CALLBACK(recover_bind_item), "pid");
+	column = gtk_column_view_column_new("Process ID", factory);
+	gtk_column_view_append_column(GTK_COLUMN_VIEW(recover->table), column);
+
 	factory = gtk_signal_list_item_factory_new();
 	g_object_set_qdata(G_OBJECT(factory), recover_quark, recover);
 	g_signal_connect(factory, "setup",