safer updates for recursive structs

jcupitt · jcupitt · commit c692e6b2c557 · 2025-03-24T14:10:03.000Z
diff --git a/src/iregiongroupview.c b/src/iregiongroupview.c
@@ -55,7 +55,8 @@ iregiongroupview_get_classmodel(iRegiongroupview *iregiongroupview)
 static void *
 iregiongroupview_unref(Regionview *regionview)
 {
-	imageui_remove_regionview(regionview->imageui, regionview);
+	if (regionview->imageui)
+		imageui_remove_regionview(regionview->imageui, regionview);
 
 	return NULL;
 }
diff --git a/src/regionview.c b/src/regionview.c
@@ -508,8 +508,6 @@ regionview_draw_line(Regionview *regionview,
 		gtk_snapshot_append_stroke(snapshot, path, stroke, &regionview_shadow);
 		gsk_stroke_free(stroke);
 	}
-	else
-		printf("regionview_draw_line: clipped\n");
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ iregiongroupview_get_classmodel(iRegiongroupview *iregiongroupview)`
`55`	`55`	`static void *`
`56`	`56`	`iregiongroupview_unref(Regionview *regionview)`
`57`	`57`	`{`
`58`		`- imageui_remove_regionview(regionview->imageui, regionview);`
	`58`	`+ if (regionview->imageui)`
	`59`	`+ imageui_remove_regionview(regionview->imageui, regionview);`
`59`	`60`
`60`	`61`	`return NULL;`
`61`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -508,8 +508,6 @@ regionview_draw_line(Regionview *regionview,`
`508`	`508`	`gtk_snapshot_append_stroke(snapshot, path, stroke, &regionview_shadow);`
`509`	`509`	`gsk_stroke_free(stroke);`
`510`	`510`	`}`
`511`		`- else`
`512`		`- printf("regionview_draw_line: clipped\n");`
`513`	`511`	`}`
`514`	`512`
`515`	`513`	`static void`