show parent/child relationships on hover

Author: jcupitt

CHANGELOG.md

@@ -9,6 +9,7 @@
 - add `nip4-batch` batch mode interface
 - fix tests
 - remove ^C/^V in mainwindow
+- show parent/child row relationships on hover
 
 ## 9.0.0-10 29025/02/18
 

TODO

@@ -1,5 +1,3 @@
-- add row label colour change for parent/child relationships
-
 - open test.ws, edit defs, "main = 12;", process, ws is not marked as modified
 
 - check all batch mode flags

src/gtk/nip4.css

@@ -2,6 +2,14 @@
   background-color: #5D7555;
 }
 
+.parent_widget {
+  background-color: #1F4151;
+}
+
+.child_widget {
+  background-color: #421F51;
+}
+
 .selected_widget {
   background-color: #83A67F;
 }

src/gtk/rowview.ui

@@ -30,7 +30,14 @@
         <child>
           <object class="GtkGestureClick">
             <property name="button">1</property>
-            <signal name="pressed" handler="rowview_click"/>
+            <signal name="pressed" handler="rowview_pressed"/>
+          </object>
+        </child>
+
+        <child>
+          <object class="GtkEventControllerMotion">
+            <signal name="enter" handler="rowview_enter"/>
+            <signal name="leave" handler="rowview_leave"/>
           </object>
         </child>
 

src/gtk/workspaceview.ui

@@ -94,7 +94,7 @@
                     <child>
                       <object class="GtkGestureClick">
                         <property name="button">1</property>
-                        <signal name="pressed" handler="workspaceview_click"/>
+                        <signal name="pressed" handler="workspaceview_pressed"/>
                       </object>
                     </child>
 

src/rowview.c

@@ -279,7 +279,7 @@ rowview_edit(Rowview *rview)
 }
 
 static void
-rowview_click(GtkGestureClick *gesture,
+rowview_pressed(GtkGestureClick *gesture,
 	guint n_press, double x, double y, Rowview *rview)
 {
 	Row *row = ROW(VOBJECT(rview)->iobject);
@@ -324,23 +324,23 @@ rowview_down_click(GtkGestureClick *gesture, Rowview *rview)
 	workspace_set_modified(row->ws, TRUE);
 }
 
-/*
 static void
-rowview_enter_cb(GtkWidget *widget, Rowview *rview)
+rowview_enter(GtkWidget *widget, Rowview *rview)
 {
 	Row *row = ROW(VOBJECT(rview)->iobject);
 
 	row_show_dependents(row);
 }
 
 static void
-rowview_leave_cb(GtkWidget *widget, Rowview *rview)
+rowview_leave(GtkWidget *widget, Rowview *rview)
 {
 	Row *row = ROW(VOBJECT(rview)->iobject);
 
 	row_hide_dependents(row);
 }
 
+/*
 static gboolean
 rowview_focus_cb(GtkWidget *widget, GtkDirectionType dir, Rowview *rview)
 {
@@ -494,14 +494,16 @@ rowview_class_init(RowviewClass *class)
 	BIND_RESOURCE("rowview.ui");
 	BIND_LAYOUT();
 
-	BIND_CALLBACK(rowview_click);
-	BIND_CALLBACK(rowview_up_click);
-	BIND_CALLBACK(rowview_down_click);
-
 	BIND_VARIABLE(Rowview, spin);
 	BIND_VARIABLE(Rowview, frame);
 	BIND_VARIABLE(Rowview, label);
 
+	BIND_CALLBACK(rowview_pressed);
+	BIND_CALLBACK(rowview_up_click);
+	BIND_CALLBACK(rowview_down_click);
+	BIND_CALLBACK(rowview_enter);
+	BIND_CALLBACK(rowview_leave);
+
 	/* Create signals.
 	 */
 

src/workspaceview.c

@@ -862,7 +862,7 @@ workspaceview_action(GSimpleAction *action, GVariant *parameter, View *view)
 }
 
 static void
-workspaceview_click(GtkGestureClick *gesture,
+workspaceview_pressed(GtkGestureClick *gesture,
 	guint n_press, double x, double y, Workspaceview *wview)
 {
 	Columnview *cview = workspaceview_find_columnview(wview, x, y);
@@ -1264,7 +1264,7 @@ workspaceview_class_init(WorkspaceviewClass *class)
 	BIND_VARIABLE(Workspaceview, fixed);
 	BIND_VARIABLE(Workspaceview, workspacedefs);
 
-	BIND_CALLBACK(workspaceview_click);
+	BIND_CALLBACK(workspaceview_pressed);
 	BIND_CALLBACK(workspaceview_drag_begin);
 	BIND_CALLBACK(workspaceview_drag_update);
 	BIND_CALLBACK(workspaceview_drag_end);