AC-16072: PHPUnit 12: Upgrade SalesRules & other related test cases

Author: shashi011

app/code/Magento/InstantPurchase/Test/Unit/Block/ButtonTest.php

@@ -13,6 +13,7 @@
 use Magento\InstantPurchase\Model\Config;
 use Magento\Store\Api\Data\StoreInterface;
 use Magento\Store\Model\StoreManagerInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -54,8 +55,8 @@ class ButtonTest extends TestCase
     protected function setUp(): void
     {
         $this->context = $this->createMock(Context::class);
-        $this->storeManager = $this->getMockForAbstractClass(StoreManagerInterface::class);
-        $this->store = $this->getMockForAbstractClass(StoreInterface::class);
+        $this->storeManager = $this->createMock(StoreManagerInterface::class);
+        $this->store = $this->createMock(StoreInterface::class);
 
         $this->storeManager->expects($this->any())->method('getStore')
             ->willReturn($this->store);
@@ -82,8 +83,8 @@ protected function setUp(): void
      * @param $currentStoreId
      * @param $isModuleEnabled
      * @param $expected
-     * @dataProvider isEnabledDataProvider
      */
+    #[DataProvider('isEnabledDataProvider')]
     public function testIsEnabled($currentStoreId, $isModuleEnabled, $expected)
     {
         $this->store->expects($this->any())->method('getId')

app/code/Magento/InstantPurchase/Test/Unit/CustomerData/InstantPurchaseTest.php

@@ -19,6 +19,7 @@
 use Magento\InstantPurchase\Model\Ui\ShippingMethodFormatter;
 use Magento\Store\Model\Store;
 use Magento\Store\Model\StoreManagerInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -90,7 +91,7 @@ class InstantPurchaseTest extends TestCase
     protected function setUp(): void
     {
         $this->customerSession = $this->createMock(Session::class);
-        $this->storeManager = $this->getMockForAbstractClass(StoreManagerInterface::class);
+        $this->storeManager = $this->createMock(StoreManagerInterface::class);
         $this->instantPurchase = $this->createMock(InstantPurchaseModel::class);
         $this->paymentTokenFormatter = $this->createMock(PaymentTokenFormatter::class);
         $this->customerAddressesFormatter = $this->createMock(CustomerAddressesFormatter::class);
@@ -119,8 +120,8 @@ protected function setUp(): void
      * @param $isLogin
      * @param $isAvailable
      * @param $expected
-     * @dataProvider getSectionDataProvider
      */
+    #[DataProvider('getSectionDataProvider')]
     public function testGetSectionData($isLogin, $isAvailable, $expected)
     {
         $this->customerSession->expects($this->any())->method('isLoggedIn')->willReturn($isLogin);

app/code/Magento/InstantPurchase/Test/Unit/Model/Ui/CustomerAddressesFormatterTest.php

@@ -9,13 +9,16 @@
 
 use Magento\Customer\Model\Address;
 use Magento\Directory\Model\Country;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
 use Magento\InstantPurchase\Model\Ui\CustomerAddressesFormatter;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class CustomerAddressesFormatterTest extends TestCase
 {
+    use MockCreationTrait;
+
     /**
      * @var CustomerAddressesFormatter|MockObject
      */
@@ -35,11 +38,10 @@ protected function setUp(): void
      */
     public function testFormat()
     {
-        $addressMock = $this->getMockBuilder(Address::class)
-            ->addMethods(['getCity', 'getPostcode'])
-            ->onlyMethods(['getName', 'getStreetFull', 'getRegion', 'getCountryModel'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $addressMock = $this->createPartialMockWithReflection(
+            Address::class,
+            ['getCity', 'getPostcode', 'getName', 'getStreetFull', 'getRegion', 'getCountryModel']
+        );
         $countryMock = $this->createMock(Country::class);
 
         $countryMock->expects($this->any())->method('getName')->willReturn('USA');

app/code/Magento/Multishipping/Test/Unit/Block/Checkout/SuccessTest.php

@@ -46,7 +46,7 @@ protected function setUp(): void
             ['getOrderIds']
         );
         $this->contextMock = $this->createMock(Context::class);
-        $this->storeManagerMock = $this->getMockForAbstractClass(StoreManagerInterface::class);
+        $this->storeManagerMock = $this->createMock(StoreManagerInterface::class);
 
         $objectManager = new ObjectManager($this);
         $this->contextMock->expects($this->once())->method('getSession')->willReturn($this->sessionMock);

app/code/Magento/Multishipping/Test/Unit/Controller/Checkout/Address/NewShippingTest.php

@@ -133,6 +133,14 @@ protected function setUp(): void
         );
     }
 
+    /**
+     * Test execute method with different scenarios
+     *
+     * @param string $backUrl
+     * @param string $shippingAddress
+     * @param string $url
+     * @return void
+     */
     #[DataProvider('executeDataProvider')]
     public function testExecute($backUrl, $shippingAddress, $url)
     {
@@ -174,6 +182,11 @@ public function testExecute($backUrl, $shippingAddress, $url)
         $this->controller->execute();
     }
 
+    /**
+     * Data provider for testExecute
+     *
+     * @return array
+     */
     public static function executeDataProvider(): array
     {
         return [
@@ -182,6 +195,11 @@ public static function executeDataProvider(): array
         ];
     }
 
+    /**
+     * Test execute when customer address block does not exist
+     *
+     * @return void
+     */
     public function testExecuteWhenCustomerAddressBlockNotExist()
     {
         $this->stateMock

app/code/Magento/Multishipping/Test/Unit/Helper/DataTest.php

@@ -63,6 +63,11 @@ protected function setUp(): void
         $this->scopeConfigMock = $context->getScopeConfig();
     }
 
+    /**
+     * Test getting maximum quantity for multishipping
+     *
+     * @return void
+     */
     public function testGetMaximumQty()
     {
         $maximumQty = 10;
@@ -79,6 +84,18 @@ public function testGetMaximumQty()
         $this->assertEquals($maximumQty, $this->helper->getMaximumQty());
     }
 
+    /**
+     * Test multishipping checkout availability
+     *
+     * @param bool $result
+     * @param bool $quoteHasItems
+     * @param bool $isMultiShipping
+     * @param bool $hasItemsWithDecimalQty
+     * @param bool $validateMinimumAmount
+     * @param int $itemsSummaryQty
+     * @param int $itemVirtualQty
+     * @param int $maximumQty
+     */
     #[DataProvider('isMultishippingCheckoutAvailableDataProvider')]
     public function testIsMultishippingCheckoutAvailable(
         $result,
@@ -151,6 +168,11 @@ public function testIsMultishippingCheckoutAvailable(
         $this->assertEquals($result, $this->helper->isMultishippingCheckoutAvailable());
     }
 
+    /**
+     * Data provider for testIsMultishippingCheckoutAvailable
+     *
+     * @return array
+     */
     public static function isMultishippingCheckoutAvailableDataProvider(): array
     {
         return [

app/code/Magento/Multishipping/Test/Unit/Model/Cart/MultishippingClearItemAddressTest.php

@@ -73,6 +73,15 @@ protected function setUp(): void
         );
     }
 
+    /**
+     * Test clearing address items in multishipping flow
+     *
+     * @param string $actionName
+     * @param int $addressId
+     * @param int $customerAddressId
+     * @param bool $isMultiShippingAddresses
+     * @return void
+     */
     #[DataProvider('getDataDataProvider')]
     public function testClearAddressItem(
         string $actionName,
@@ -142,6 +151,11 @@ public function testClearAddressItem(
         );
     }
 
+    /**
+     * Data provider for testClearAddressItem
+     *
+     * @return array
+     */
     public static function getDataDataProvider(): array
     {
         return [

app/code/Magento/Multishipping/Test/Unit/Model/Checkout/Type/Multishipping/PlaceOrderPoolTest.php

@@ -19,11 +19,17 @@
  */
 class PlaceOrderPoolTest extends TestCase
 {
+    /**
+     * @param string $paymentProviderCode
+     * @param PlaceOrderInterface[] $placeOrderList
+     * @param \Closure $expectedResult
+     * @return void
+     */
     #[DataProvider('getDataProvider')]
     public function testGet(string $paymentProviderCode, array $placeOrderList, $expectedResult)
     {
         $placeOrderList['payment_code'] = $placeOrderList['payment_code']($this);
-        if($expectedResult != null) {
+        if ($expectedResult != null) {
             $expectedResult = $expectedResult($this);
         }
         /** @var TMapFactory|MockObject $tMapFactory */

app/code/Magento/Multishipping/Test/Unit/Model/Checkout/Type/Multishipping/PluginTest.php

@@ -15,12 +15,16 @@
 use Magento\Multishipping\Model\Checkout\Type\Multishipping\Plugin;
 use Magento\Multishipping\Model\Checkout\Type\Multishipping\State;
 use Magento\Quote\Api\CartRepositoryInterface;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Quote\Model\Quote;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class PluginTest extends TestCase
 {
+    use MockCreationTrait;
+
     /**
      * @var MockObject
      */
@@ -58,29 +62,19 @@ class PluginTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->checkoutSessionMock = $this->getMockBuilder(Session::class)
-            ->addMethods(
-                [
-                    'getCheckoutState',
-                    'setCheckoutState',
-                    'getMultiShippingAddressesFlag',
-                    'setMultiShippingAddressesFlag'
-                ]
-            )
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->cartRepositoryMock = $this->getMockBuilder(CartRepositoryInterface::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->requestMock = $this->getMockBuilder(RequestInterface::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->localeMock = $this->getMockBuilder(ResolverInterface::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->quantityProcessorMock = $this->getMockBuilder(RequestQuantityProcessor::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->checkoutSessionMock = $this->createPartialMockWithReflection(
+            Session::class,
+            [
+                'getCheckoutState',
+                'setCheckoutState',
+                'getMultiShippingAddressesFlag',
+                'setMultiShippingAddressesFlag'
+            ]
+        );
+        $this->cartRepositoryMock = $this->createMock(CartRepositoryInterface::class);
+        $this->requestMock = $this->createMock(RequestInterface::class);
+        $this->localeMock = $this->createMock(ResolverInterface::class);
+        $this->quantityProcessorMock = $this->createMock(RequestQuantityProcessor::class);
         $this->cartMock = $this->createMock(Cart::class);
         $this->model = new Plugin(
             $this->checkoutSessionMock,
@@ -114,8 +108,9 @@ public function testBeforeInitCaseFalse()
      * @param float $itemInitialQuantity
      * @param array $params
      * @param bool $multipleShippingAddressesFlag
-     * @dataProvider getDataDataProvider
+     * @return void
      */
+    #[DataProvider('getDataDataProvider')]
     public function testAfterSave(
         float $itemInitialQuantity,
         array $params,
@@ -158,7 +153,7 @@ public function testAfterSave(
     /**
      * @return array
      */
-    public static function getDataDataProvider()
+    public static function getDataDataProvider(): array
     {
         return [
             'test with multi shipping addresses' => [10.0, ['qty' => '5'], true],