From 4ab2ea594f9e550b902b8a07326640c161bf549a Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Wed, 3 Dec 2025 10:03:59 -0800 Subject: [PATCH 1/3] Add pre-flight checks to release script --- dev-bin/release.sh | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/dev-bin/release.sh b/dev-bin/release.sh index fa3d86d..a481f22 100755 --- a/dev-bin/release.sh +++ b/dev-bin/release.sh @@ -2,6 +2,37 @@ set -eu -o pipefail +# Pre-flight checks - verify all required tools are available and configured +# before making any changes to the repository + +check_command() { + if ! command -v "$1" &> /dev/null; then + echo "Error: $1 is not installed or not in PATH" + exit 1 + fi +} + +# Verify gh CLI is authenticated +if ! gh auth status &> /dev/null; then + echo "Error: gh CLI is not authenticated. Run 'gh auth login' first." + exit 1 +fi + +# Verify we can access this repository via gh +if ! gh repo view --json name &> /dev/null; then + echo "Error: Cannot access repository via gh. Check your authentication and repository access." + exit 1 +fi + +# Verify git can connect to the remote (catches SSH key issues, etc.) +if ! git ls-remote origin &> /dev/null; then + echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys." + exit 1 +fi + +check_command perl +check_command rake + # Check that we're not on the main branch current_branch=$(git branch --show-current) if [ "$current_branch" = "main" ]; then From b31906758ab5f56b0a6eefc62339e36805a5ccbc Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Wed, 3 Dec 2025 10:04:34 -0800 Subject: [PATCH 2/3] Standardize pre-release version support in release script --- dev-bin/release.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-bin/release.sh b/dev-bin/release.sh index a481f22..376f355 100755 --- a/dev-bin/release.sh +++ b/dev-bin/release.sh @@ -54,7 +54,7 @@ fi changelog=$(cat CHANGELOG.md) regex=' -## v([0-9]+\.[0-9]+\.[0-9]+(.[a-z0-9]+)?) \(([0-9]{4}-[0-9]{2}-[0-9]{2})\) +## v([0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?) \(([0-9]{4}-[0-9]{2}-[0-9]{2})\) ((.| )*) @@ -67,7 +67,7 @@ fi version="${BASH_REMATCH[1]}" date="${BASH_REMATCH[3]}" -notes="$(echo "${BASH_REMATCH[4]}" | sed -n -E '/^## v[0-9]+\.[0-9]+\.[0-9]+/,$!p')" +notes="$(echo "${BASH_REMATCH[4]}" | sed -n -E '/^## v[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?/,$!p')" echo "$notes" if [[ "$date" != "$(date +"%Y-%m-%d")" ]]; then From 2424b0a68731f759f7cd9c3207d4d45d585cacb5 Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Wed, 3 Dec 2025 13:27:23 -0800 Subject: [PATCH 3/3] Fix release script consistency issues - Fix shellcheck SC2162: add -r flag to read command - Apply shfmt formatting --- dev-bin/release.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dev-bin/release.sh b/dev-bin/release.sh index 376f355..f3bdcf0 100755 --- a/dev-bin/release.sh +++ b/dev-bin/release.sh @@ -6,26 +6,26 @@ set -eu -o pipefail # before making any changes to the repository check_command() { - if ! command -v "$1" &> /dev/null; then + if ! command -v "$1" &>/dev/null; then echo "Error: $1 is not installed or not in PATH" exit 1 fi } # Verify gh CLI is authenticated -if ! gh auth status &> /dev/null; then +if ! gh auth status &>/dev/null; then echo "Error: gh CLI is not authenticated. Run 'gh auth login' first." exit 1 fi # Verify we can access this repository via gh -if ! gh repo view --json name &> /dev/null; then +if ! gh repo view --json name &>/dev/null; then echo "Error: Cannot access repository via gh. Check your authentication and repository access." exit 1 fi # Verify git can connect to the remote (catches SSH key issues, etc.) -if ! git ls-remote origin &> /dev/null; then +if ! git ls-remote origin &>/dev/null; then echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys." exit 1 fi @@ -61,8 +61,8 @@ regex=' ' if [[ ! $changelog =~ $regex ]]; then - echo "Could not find date line in change log!" - exit 1 + echo "Could not find date line in change log!" + exit 1 fi version="${BASH_REMATCH[1]}" @@ -94,7 +94,7 @@ git diff echo $'\nRelease notes:' echo "$notes" -read -e -p "Commit changes and push to origin? " should_push +read -r -e -p "Commit changes and push to origin? " should_push if [ "$should_push" != "y" ]; then echo "Aborting"