From 83aed4415d6ecd515e0b1bea525e42ba2fa9388e Mon Sep 17 00:00:00 2001 From: Orbin Sunny <91816511+orbin123@users.noreply.github.com> Date: Thu, 18 Dec 2025 14:48:18 +0530 Subject: [PATCH 1/6] fix(tests): adapt network tests for Meilisearch v1.30 HA changes Meilisearch v1.30.0 removed the sharding flag in favor of a new Leader/Follower High Availability model. This commit updates the test suite to align with these breaking changes. --- tests/client/test_client_multi_search_meilisearch.py | 4 ++-- tests/client/test_client_network.py | 6 ++---- tests/client/test_client_sharding.py | 4 ++-- tests/test_utils.py | 4 ++-- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/tests/client/test_client_multi_search_meilisearch.py b/tests/client/test_client_multi_search_meilisearch.py index b9523e0b..1077f00c 100644 --- a/tests/client/test_client_multi_search_meilisearch.py +++ b/tests/client/test_client_multi_search_meilisearch.py @@ -2,7 +2,7 @@ from meilisearch.errors import MeilisearchApiError from tests.common import INDEX_UID, REMOTE_MS_1, REMOTE_MS_2 -from tests.test_utils import disable_sharding +from tests.test_utils import reset_network_config def test_basic_multi_search(client, empty_index): @@ -112,4 +112,4 @@ def test_multi_search_with_network(client, index_with_documents): assert response["hits"][0]["_federation"]["indexUid"] == INDEX_UID assert response["hits"][0]["_federation"]["remote"] == REMOTE_MS_1 assert response["remoteErrors"] == {} - disable_sharding(client) + reset_network_config(client) diff --git a/tests/client/test_client_network.py b/tests/client/test_client_network.py index 7037b62e..adf4dec0 100644 --- a/tests/client/test_client_network.py +++ b/tests/client/test_client_network.py @@ -1,7 +1,7 @@ import pytest from tests.common import REMOTE_MS_1, REMOTE_MS_2 -from tests.test_utils import disable_sharding +from tests.test_utils import reset_network_config @pytest.mark.usefixtures("enable_network_options") @@ -17,7 +17,6 @@ def test_add_or_update_networks(client): """Tests upsert network remote instance.""" body = { "self": REMOTE_MS_1, - "sharding": True, "remotes": { REMOTE_MS_1: { "url": "http://localhost:7700", @@ -35,9 +34,8 @@ def test_add_or_update_networks(client): assert isinstance(response, dict) assert response["self"] == REMOTE_MS_1 - assert response["sharding"] is True assert len(response["remotes"]) >= 2 assert REMOTE_MS_2 in response["remotes"] assert REMOTE_MS_1 in response["remotes"] - disable_sharding(client) + reset_network_config(client) diff --git a/tests/client/test_client_sharding.py b/tests/client/test_client_sharding.py index aadab4e2..3a9bd215 100644 --- a/tests/client/test_client_sharding.py +++ b/tests/client/test_client_sharding.py @@ -1,7 +1,7 @@ import pytest from tests.common import BASE_URL, REMOTE_MS_1 -from tests.test_utils import disable_sharding +from tests.test_utils import reset_network_config @pytest.mark.usefixtures("enable_network_options") @@ -34,4 +34,4 @@ def test_update_and_get_network_settings(client): == options["remotes"][instance_name]["writeApiKey"] ) assert response["sharding"] == options["sharding"] - disable_sharding(client) + reset_network_config(client) diff --git a/tests/test_utils.py b/tests/test_utils.py index 7b9feace..4ca688ce 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -34,5 +34,5 @@ def test_iso_to_date_time_invalid_format(): # Refactor to use the unified API to toggle experimental features -def disable_sharding(client): - client.add_or_update_networks(body={"sharding": False}) +def reset_network_config(client): + client.add_or_update_networks(body={"remotes": {}, "leader": None}) From dbcfbcc8c03a51af03bf765f8e372c887e4f3b83 Mon Sep 17 00:00:00 2001 From: Orbin Sunny <91816511+orbin123@users.noreply.github.com> Date: Thu, 18 Dec 2025 15:01:35 +0530 Subject: [PATCH 2/6] Update tests/client/test_client_sharding.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- tests/client/test_client_sharding.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/client/test_client_sharding.py b/tests/client/test_client_sharding.py index 3a9bd215..2c12882d 100644 --- a/tests/client/test_client_sharding.py +++ b/tests/client/test_client_sharding.py @@ -33,5 +33,4 @@ def test_update_and_get_network_settings(client): response["remotes"][instance_name]["writeApiKey"] == options["remotes"][instance_name]["writeApiKey"] ) - assert response["sharding"] == options["sharding"] reset_network_config(client) From bd9bdb196bb108b118d3fe63377c1f6a6b93335e Mon Sep 17 00:00:00 2001 From: Orbin Sunny <91816511+orbin123@users.noreply.github.com> Date: Thu, 18 Dec 2025 15:05:38 +0530 Subject: [PATCH 3/6] change sharding --- tests/client/test_client_multi_search_meilisearch.py | 1 - tests/client/test_client_sharding.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/tests/client/test_client_multi_search_meilisearch.py b/tests/client/test_client_multi_search_meilisearch.py index 1077f00c..cb7c6e34 100644 --- a/tests/client/test_client_multi_search_meilisearch.py +++ b/tests/client/test_client_multi_search_meilisearch.py @@ -85,7 +85,6 @@ def test_multi_search_with_network(client, index_with_documents): resp = client.add_or_update_networks( { "self": REMOTE_MS_1, - "sharding": True, "remotes": { REMOTE_MS_1: { "url": "http://ms-1235.example.meilisearch.io", diff --git a/tests/client/test_client_sharding.py b/tests/client/test_client_sharding.py index 3a9bd215..e05d1183 100644 --- a/tests/client/test_client_sharding.py +++ b/tests/client/test_client_sharding.py @@ -17,7 +17,6 @@ def test_update_and_get_network_settings(client): "writeApiKey": "write-key-1", } }, - "sharding": True, } client.add_or_update_networks(options) @@ -33,5 +32,4 @@ def test_update_and_get_network_settings(client): response["remotes"][instance_name]["writeApiKey"] == options["remotes"][instance_name]["writeApiKey"] ) - assert response["sharding"] == options["sharding"] reset_network_config(client) From 2dd198ddea3f859fd7edbabcb4b9bfe81ef2024f Mon Sep 17 00:00:00 2001 From: Orbin Sunny <91816511+orbin123@users.noreply.github.com> Date: Tue, 30 Dec 2025 10:47:01 +0530 Subject: [PATCH 4/6] Update test_setting_embedder.py increased the timeout of test_huggingface_embedder_format to wait for 1 minute --- tests/settings/test_settings_embedders.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/settings/test_settings_embedders.py b/tests/settings/test_settings_embedders.py index 333678bc..73a32513 100644 --- a/tests/settings/test_settings_embedders.py +++ b/tests/settings/test_settings_embedders.py @@ -95,7 +95,7 @@ def test_huggingface_embedder_format(empty_index): } } response = index.update_embedders(huggingface_embedder) - index.wait_for_task(response.task_uid) + index.wait_for_task(response.task_uid, timeout_in_ms=60000) embedders = index.get_embedders() assert embedders.embedders["huggingface"].source == "huggingFace" assert embedders.embedders["huggingface"].model == "BAAI/bge-base-en-v1.5" From 6360ba6311d819396d837341c2f82af1c25e94ed Mon Sep 17 00:00:00 2001 From: Orbin Sunny <91816511+orbin123@users.noreply.github.com> Date: Tue, 30 Dec 2025 10:51:12 +0530 Subject: [PATCH 5/6] Update test_settings_embedders.py --- tests/settings/test_settings_embedders.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/settings/test_settings_embedders.py b/tests/settings/test_settings_embedders.py index 73a32513..178106ef 100644 --- a/tests/settings/test_settings_embedders.py +++ b/tests/settings/test_settings_embedders.py @@ -95,7 +95,7 @@ def test_huggingface_embedder_format(empty_index): } } response = index.update_embedders(huggingface_embedder) - index.wait_for_task(response.task_uid, timeout_in_ms=60000) + index.wait_for_task(response.task_uid, timeout_in_ms=60000) # embedder config can take longer. embedders = index.get_embedders() assert embedders.embedders["huggingface"].source == "huggingFace" assert embedders.embedders["huggingface"].model == "BAAI/bge-base-en-v1.5" From 692dff2bb8e3d50afdf944bf45e967cc5fb62f07 Mon Sep 17 00:00:00 2001 From: Strift Date: Tue, 30 Dec 2025 14:17:23 +0800 Subject: [PATCH 6/6] format with black --- tests/settings/test_settings_embedders.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/settings/test_settings_embedders.py b/tests/settings/test_settings_embedders.py index 178106ef..0265d6c3 100644 --- a/tests/settings/test_settings_embedders.py +++ b/tests/settings/test_settings_embedders.py @@ -95,7 +95,7 @@ def test_huggingface_embedder_format(empty_index): } } response = index.update_embedders(huggingface_embedder) - index.wait_for_task(response.task_uid, timeout_in_ms=60000) # embedder config can take longer. + index.wait_for_task(response.task_uid, timeout_in_ms=60000) # embedder config can take longer. embedders = index.get_embedders() assert embedders.embedders["huggingface"].source == "huggingFace" assert embedders.embedders["huggingface"].model == "BAAI/bge-base-en-v1.5"