Merge pull request #23 from Microsoft/commandbar-type-fix

Fix ICommandBarItemOptions type (again)

Author: bengry

…ore/src/lib/declarations/known-keys.d.ts …/core/src/lib/declarations/known-keys.tslibs/core/src/lib/declarations/known-keys.d.ts renamed to libs/core/src/lib/declarations/known-keys.ts libs/core/src/lib/declarations/known-keys.d.ts renamed to libs/core/src/lib/declarations/known-keys.ts

@@ -15,8 +15,6 @@ type KnownKeysOfOptions = KnownKeys<Options>; // 'key' | 'title';
 
  * Taken from https://stackoverflow.com/questions/51465182/typescript-remove-index-signature-using-mapped-types
  */
-export type KnownKeys<T> = { [K in keyof T]: string extends K ? never : number extends K ? never : K } extends {
-  [_ in keyof T]: infer U
-}
-  ? U
-  : never;
+type KnownKeys<T> = {
+  [K in keyof T]: string extends K ? never : number extends K ? never : K
+} extends { [_ in keyof T]: infer U } ?U: never;

libs/fabric/src/lib/components/command-bar/command-bar.component.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import { InputRendererOptions, Omit, ReactWrapperComponent } from '@angular-react/core';
+import { InputRendererOptions, ReactWrapperComponent } from '@angular-react/core';
 import {
   AfterContentInit,
   ChangeDetectionStrategy,
@@ -224,7 +224,10 @@ export class FabCommandBarComponent extends ReactWrapperComponent<ICommandBarPro
   }
 }
 
-export interface ICommandBarItemOptions<TData = any> extends Omit<ICommandBarItemProps, 'onRender' | 'onRenderIcon'> {
+// Not using `Omit` here since it confused the TypeScript compiler and it just showed the properties listed here (`renderIcon`, `render` and `data`).
+// The type here is just `Omit` without the generics though.
+export interface ICommandBarItemOptions<TData = any>
+  extends Pick<ICommandBarItemProps, Exclude<KnownKeys<ICommandBarItemProps>, 'onRender' | 'onRenderIcon'>> {
   readonly renderIcon?: InputRendererOptions<ICommandBarItemOptionsRenderIconContext>;
   readonly render?: InputRendererOptions<ICommandBarItemOptionsRenderContext>;
   readonly data?: TData;