Fix setting properties or attributes on a ReactNode overriding others when value was undefined

Ben Grynhaus · Ben Grynhaus · commit 2d7d63899bcc · 2018-10-19T22:01:11.000+03:00
diff --git a/libs/core/src/lib/renderer/react-node.ts b/libs/core/src/lib/renderer/react-node.ts
@@ -109,7 +109,7 @@ export class ReactNode {
 
   setProperties(properties: StringMap) {
     this.setRenderPending();
-    Object.assign(this.props, properties);
+    Object.assign(this._props, removeUndefinedProperties(properties));
   }
 
   removeProperty(name: string, childName?: string) {

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ export class ReactNode {`
`109`	`109`
`110`	`110`	`setProperties(properties: StringMap) {`
`111`	`111`	`this.setRenderPending();`
`112`		`- Object.assign(this.props, properties);`
	`112`	`+ Object.assign(this._props, removeUndefinedProperties(properties));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`removeProperty(name: string, childName?: string) {`