Skip to content

Commit 79c6389

Browse files
xjerwabengry
authored andcommitted
Moved geteventlisteners module to local and revised JS to use es5 syntax (#48)
* Updated to v0.5.1, Moved geteventlisteners module to local and revised JS to use es5 syntax, Minor typing fixes * Updated changelog * Remove changelog change * Update @types/react * Better type * revert version bumps for core + fabric
1 parent 4681b45 commit 79c6389

File tree

7 files changed

+373
-912
lines changed

7 files changed

+373
-912
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,23 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
88
# [0.5.0](https://github.com/Microsoft/angular-react/compare/v0.4.10...v0.5.0) (2018-12-04)
99

1010
### Breaking changes
11+
1112
- **all:** Upgrade Angular version to 7.0.3 ([#45](https://github.com/Microsoft/angular-react/pull/45)) ([bc39370](https://github.com/Microsoft/angular-react/commit/bc393707bdfb9f163b2e718702e35f0fb4ff25c3))
1213

1314
### General
15+
1416
- **all:** Upgrade React version to ^16.6.3 ([#45](https://github.com/Microsoft/angular-react/pull/45)) ([bc39370](https://github.com/Microsoft/angular-react/commit/bc393707bdfb9f163b2e718702e35f0fb4ff25c3)) ([#46](https://github.com/Microsoft/angular-react/pull/46)) ([87e70de](https://github.com/Microsoft/angular-react/commit/87e70de0cee459c69c914e2f723b4e647e3f466f))
1517
- **all:** Remove all index barrel files ([#44](https://github.com/Microsoft/angular-react/pull/44)) ([7f36a6b](https://github.com/Microsoft/angular-react/commit/7f36a6b47e77c70d53cc4290e53a1a8329d44467))
1618
- **core:** Upgrade css-to-style to ^1.2.1 ([5408b23](https://github.com/Microsoft/angular-react/commit/5408b238c2e3903a7417b6a2fd2e8c82bd94b0f1))
17-
- **fabric:** Upgrade `office-ui-fabric-react` to 6.110.0 ([#45](https://github.com/Microsoft/angular-react/pull/45)) ([bc39370](https://github.com/Microsoft/angular-react/commit/bc393707bdfb9f163b2e718702e35f0fb4ff25c3)) ([#46](https://github.com/Microsoft/angular-react/pull/46))
19+
- **fabric:** Upgrade `office-ui-fabric-react` to 6.110.0 ([#45](https://github.com/Microsoft/angular-react/pull/45)) ([bc39370](https://github.com/Microsoft/angular-react/commit/bc393707bdfb9f163b2e718702e35f0fb4ff25c3)) ([#46](https://github.com/Microsoft/angular-react/pull/46))
1820

1921
### Bug fixes
22+
2023
- **fabric:** Fix `<command-bar-item>` not recognizing some inputs ([#42](https://github.com/Microsoft/angular-react/pull/42)) ([411ef87](https://github.com/Microsoft/angular-react/commit/411ef8730e7e2d984e1a86f03f8603dfb335f499))
2124
- **fabric:** Fix bad imports in DetailsList module ([#43](https://github.com/Microsoft/angular-react/pull/43)) ([80a50e6](https://github.com/Microsoft/angular-react/commit/80a50e69942c6e679ecdb3c4f0fa2621932231c4))
2225

2326
### Features
27+
2428
- **fabric:** Add `<fab-plain-card>` and `<fab-expanding-card>` components ([#45](https://github.com/Microsoft/angular-react/pull/45)) ([bc39370](https://github.com/Microsoft/angular-react/commit/bc393707bdfb9f163b2e718702e35f0fb4ff25c3)) ([#46](https://github.com/Microsoft/angular-react/pull/46))
2529

2630
<!-- ### Features
2.39 KB
Binary file not shown.

libs/core/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,11 @@
6262
"css-to-style": "^1.2.1",
6363
"classnames": "^2.2.6",
6464
"stylenames": "^1.1.6",
65-
"geteventlisteners": "^1.0.6"
65+
"geteventlisteners": "file:external/geteventlisteners/geteventlisteners-1.0.6.tgz"
6666
},
6767
"bundledDependencies": [
6868
"css-to-style",
6969
"classnames",
70-
"stylenames",
71-
"geteventlisteners"
70+
"stylenames"
7271
]
7372
}

libs/core/src/lib/renderer/react-node.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class ReactNode {
5353
return this._isDestroyPending;
5454
}
5555

56-
constructor(private type?: React.ReactType) {
56+
constructor(private type?: React.ReactType | string) {
5757
this.setRenderPending();
5858
this._tryResolveTypeIsReactElementClass();
5959
}

libs/core/src/lib/renderer/registry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function isKnownComponent(elementName: string): boolean {
3333
return elementMap.has(elementName) || elementMap.has(elementName.toLowerCase());
3434
}
3535

36-
export function getComponentClass(elementName: string): React.ReactType {
36+
export function getComponentClass(elementName: string): React.ReactType | string {
3737
const entry = elementMap.get(elementName) || elementMap.get(elementName.toLowerCase());
3838
if (!entry) {
3939
// throw new TypeError(`No known component for element ${elementName}.`);

0 commit comments

Comments
 (0)