Skip to content

Commit 8c0e24c

Browse files
author
Lion Huang
committed
Take benefits from tree-shaking support in Fabric
1 parent 24606fe commit 8c0e24c

38 files changed

+39
-85
lines changed

libs/fabric/package.json

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -9,38 +9,7 @@
99
"react": "React",
1010
"react-dom": "ReactDOM",
1111
"@angular-react/core": "ɵa",
12-
"office-ui-fabric-react/lib/Breadcrumb": "Breadcrumb",
13-
"office-ui-fabric-react/lib/Button": "Button",
14-
"office-ui-fabric-react/lib/Calendar": "Calendar",
15-
"office-ui-fabric-react/lib/Callout": "Callout",
16-
"office-ui-fabric-react/lib/Checkbox": "Checkbox",
17-
"office-ui-fabric-react/lib/ChoiceGroup": "ChoiceGroup",
18-
"office-ui-fabric-react/lib/ComboBox": "ComboBox",
19-
"office-ui-fabric-react/lib/CommandBar": "CommandBar",
20-
"office-ui-fabric-react/lib/DatePicker": "DatePicker",
21-
"office-ui-fabric-react/lib/DetailsList": "DetailsList",
22-
"office-ui-fabric-react/lib/Dialog": "Dialog",
23-
"office-ui-fabric-react/lib/Divider": "Divider",
24-
"office-ui-fabric-react/lib/Fabric": "Fabric",
25-
"office-ui-fabric-react/lib/GroupedList": "GroupedList",
26-
"office-ui-fabric-react/lib/HoverCard": "HoverCard",
27-
"office-ui-fabric-react/lib/Icon": "Icon",
28-
"office-ui-fabric-react/lib/Image": "Image",
29-
"office-ui-fabric-react/lib/Link": "Link",
30-
"office-ui-fabric-react/lib/MarqueeSelection": "MarqueeSelection",
31-
"office-ui-fabric-react/lib/MessageBar": "MessageBar",
32-
"office-ui-fabric-react/lib/Modal": "Modal",
33-
"office-ui-fabric-react/lib/Panel": "Panel",
34-
"office-ui-fabric-react/lib/Persona": "Persona",
35-
"office-ui-fabric-react/lib/Pivot": "Pivot",
36-
"office-ui-fabric-react/lib/SearchBox": "SearchBox",
37-
"office-ui-fabric-react/lib/Shimmer": "Shimmer",
38-
"office-ui-fabric-react/lib/Slider": "Slider",
39-
"office-ui-fabric-react/lib/SpinButton": "SpinButton",
40-
"office-ui-fabric-react/lib/Spinner": "Spinner",
41-
"office-ui-fabric-react/lib/TextField": "TextField",
42-
"office-ui-fabric-react/lib/Toggle": "Toggle",
43-
"office-ui-fabric-react/lib/Tooltip": "Tooltip"
12+
"office-ui-fabric-react": "Fabric"
4413
},
4514
"comments": "none"
4615
},

libs/fabric/src/lib/components/breadcrumb/breadcrumb.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import { Breadcrumb } from 'office-ui-fabric-react/lib/Breadcrumb';
7+
import { Breadcrumb } from 'office-ui-fabric-react';
88
import { FabBreadcrumbComponent } from './breadcrumb.component';
99

1010
const components = [FabBreadcrumbComponent];

libs/fabric/src/lib/components/button/button.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
IconButton,
1313
MessageBarButton,
1414
PrimaryButton,
15-
} from 'office-ui-fabric-react/lib/Button';
15+
} from 'office-ui-fabric-react';
1616
import { FabActionButtonComponent } from './action-button.component';
1717
import { FabCommandBarButtonComponent } from './command-bar-button.component';
1818
import { FabCompoundButtonComponent } from './compound-button.component';

libs/fabric/src/lib/components/calendar/calendar.module.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,9 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import * as CalendarCss from 'office-ui-fabric-react/lib-amd/components/Calendar/Calendar.scss';
8-
import { Calendar } from 'office-ui-fabric-react/lib/Calendar';
9-
import { noop } from '../../utils/noop';
7+
import { Calendar } from 'office-ui-fabric-react';
108
import { FabCalendarComponent } from './calendar.component';
119

12-
// Dummy action to force CalendarCss to load and not be tree-shaken away.
13-
noop(CalendarCss);
14-
1510
const components = [FabCalendarComponent];
1611

1712
@NgModule({

libs/fabric/src/lib/components/callout/callout.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import { Callout } from 'office-ui-fabric-react/lib/Callout';
7+
import { Callout } from 'office-ui-fabric-react';
88
import { FabCalloutComponent } from './callout.component';
99

1010
const components = [FabCalloutComponent];

libs/fabric/src/lib/components/checkbox/checkbox.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import { Checkbox } from 'office-ui-fabric-react/lib/Checkbox';
7+
import { Checkbox } from 'office-ui-fabric-react';
88
import { FabCheckboxComponent } from './checkbox.component';
99

1010
const components = [FabCheckboxComponent];

libs/fabric/src/lib/components/choice-group/choice-group.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import { ChoiceGroup } from 'office-ui-fabric-react/lib/ChoiceGroup';
7+
import { ChoiceGroup } from 'office-ui-fabric-react';
88
import { FabChoiceGroupComponent } from './choice-group.component';
99

1010
const components = [FabChoiceGroupComponent];

libs/fabric/src/lib/components/combo-box/combo-box.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import { ComboBox, VirtualizedComboBox } from 'office-ui-fabric-react/lib/ComboBox';
7+
import { ComboBox, VirtualizedComboBox } from 'office-ui-fabric-react';
88
import { FabComboBoxComponent } from './combo-box.component';
99
import { FabVirtualizedComboBoxComponent } from './virtualized-combo-box.component';
1010

libs/fabric/src/lib/components/command-bar/command-bar.module.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
7-
import * as OverflowSetCss from 'office-ui-fabric-react/lib-amd/components/OverflowSet/OverflowSet.scss';
8-
import { CommandBar } from 'office-ui-fabric-react/lib/CommandBar';
9-
import { noop } from '../../utils/noop';
7+
import { CommandBar } from 'office-ui-fabric-react';
108
import { FabContextualMenuModule } from '../contextual-menu/contextual-menu.module';
119
import { FabCommandBarComponent } from './command-bar.component';
1210
import {
@@ -20,9 +18,6 @@ import {
2018
CommandBarOverflowItemsDirective,
2119
} from './directives/command-bar-items.directives';
2220

23-
// Dummy action to force OverflowSetCss to load and not be tree-shaken away.
24-
noop(OverflowSetCss);
25-
2621
const components = [
2722
FabCommandBarComponent,
2823
CommandBarItemsDirective,

libs/fabric/src/lib/components/date-picker/date-picker.module.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,8 @@ import { registerElement } from '@angular-react/core';
55
import { CommonModule } from '@angular/common';
66
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
77
import { DatePicker } from 'office-ui-fabric-react';
8-
import * as CalendarCss from 'office-ui-fabric-react/lib-amd/components/Calendar/Calendar.scss';
9-
import { noop } from '../../utils/noop';
108
import { FabDatePickerComponent } from './date-picker.component';
119

12-
// Dummy action to force CalendarCss to load and not be tree-shaken away.
13-
noop(CalendarCss);
14-
1510
const components = [FabDatePickerComponent];
1611

1712
@NgModule({

0 commit comments

Comments
 (0)