size arg not supported

Author: timgraham

django_mongodb_backend/fields/embedded_model_array.py

@@ -7,6 +7,8 @@
 
 class EmbeddedModelArrayField(ArrayField):
     def __init__(self, embedded_model, **kwargs):
+        if kwargs.get("size") is not None:
+            raise ValueError("EmbeddedModelArrayField does not support size.")
         super().__init__(EmbeddedModelField(embedded_model), **kwargs)
         self.embedded_model = embedded_model
 
@@ -42,7 +44,6 @@ def formfield(self, **kwargs):
                 "model": self.base_field.embedded_model,
                 "max_length": self.max_size,
                 "prefix": self.name,
-                "length": self.size,
                 **kwargs,
             },
         )

django_mongodb_backend/forms/fields/embedded_model_array.py

@@ -14,7 +14,7 @@ def models_to_dicts(models):
 
 
 class EmbeddedModelArrayField(forms.Field):
-    def __init__(self, model, prefix, max_length=None, length=None, *args, **kwargs):
+    def __init__(self, model, prefix, max_length=None, *args, **kwargs):
         self.model = model
         self.prefix = prefix
         self.formset = formset_factory(

docs/source/ref/models/fields.rst

@@ -272,7 +272,7 @@ See :doc:`/topics/embedded-models` for more details and examples.
 ``EmbeddedModelArrayField``
 ---------------------------
 
-.. class:: EmbeddedModelArrayField(embedded_model, **kwargs)
+.. class:: EmbeddedModelArrayField(embedded_model, max_size=None, **kwargs)
 
     .. versionadded:: 5.2.0b1
 
@@ -283,6 +283,13 @@ See :doc:`/topics/embedded-models` for more details and examples.
         This is a required argument, similar to
         :attr:`EmbeddedModelField.embedded_model`.
 
+    .. attribute:: max_size
+
+        This is an optional argument.
+
+        If passed, the array will have a maximum size as specified, validated
+        by forms and model validation, but not enforced by the database.
+
 ``ObjectIdAutoField``
 ---------------------
 

tests/model_fields_/test_embedded_model_array.py

@@ -17,6 +17,11 @@ def test_deconstruct(self):
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"embedded_model": "Data", "null": True})
 
+    def test_size_not_supported(self):
+        msg = "EmbeddedModelArrayField does not support size."
+        with self.assertRaisesMessage(ValueError, msg):
+            EmbeddedModelArrayField("Data", size=1)
+
     def test_get_db_prep_save_invalid(self):
         msg = "Expected list of <class 'model_fields_.models.Review'> instances, not <class 'int'>."
         with self.assertRaisesMessage(TypeError, msg):