Find a reliable way to check for search compatibility

Author: GromNaN

src/Operation/Aggregate.php

@@ -27,8 +27,8 @@
 use MongoDB\Driver\Server;
 use MongoDB\Driver\Session;
 use MongoDB\Driver\WriteConcern;
-use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\InvalidArgumentException;
+use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\UnexpectedValueException;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\CodecCursor;

src/Operation/CreateSearchIndexes.php

@@ -21,8 +21,8 @@
 use MongoDB\Driver\Exception\RuntimeException as DriverRuntimeException;
 use MongoDB\Driver\Exception\ServerException;
 use MongoDB\Driver\Server;
-use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\InvalidArgumentException;
+use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\SearchIndexInput;
 

src/Operation/DropSearchIndex.php

@@ -22,6 +22,7 @@
 use MongoDB\Driver\Exception\RuntimeException as DriverRuntimeException;
 use MongoDB\Driver\Server;
 use MongoDB\Exception\InvalidArgumentException;
+use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\UnsupportedException;
 
 /**
@@ -72,6 +73,10 @@ public function execute(Server $server): void
         } catch (CommandException $e) {
             // Drop operations are idempotent. The server may return an error if the collection does not exist.
             if ($e->getCode() !== self::ERROR_CODE_NAMESPACE_NOT_FOUND) {
+                if (SearchNotSupportedException::isSearchNotSupportedError($e)) {
+                    throw SearchNotSupportedException::create($e);
+                }
+
                 throw $e;
             }
         }

src/Operation/UpdateSearchIndex.php

@@ -19,8 +19,10 @@
 
 use MongoDB\Driver\Command;
 use MongoDB\Driver\Exception\RuntimeException as DriverRuntimeException;
+use MongoDB\Driver\Exception\ServerException;
 use MongoDB\Driver\Server;
 use MongoDB\Exception\InvalidArgumentException;
+use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Exception\UnsupportedException;
 
 use function MongoDB\is_document;
@@ -76,6 +78,14 @@ public function execute(Server $server): void
             $cmd['comment'] = $this->options['comment'];
         }
 
-        $server->executeCommand($this->databaseName, new Command($cmd));
+        try {
+            $server->executeCommand($this->databaseName, new Command($cmd));
+        } catch (ServerException $e) {
+            if (SearchNotSupportedException::isSearchNotSupportedError($e)) {
+                throw SearchNotSupportedException::create($e);
+            }
+
+            throw $e;
+        }
     }
 }

tests/Exception/SearchNotSupportedExceptionTest.php

@@ -2,19 +2,19 @@
 
 namespace Exception;
 
-use MongoDB\Collection;
 use MongoDB\Driver\Command;
 use MongoDB\Driver\Exception\ServerException;
 use MongoDB\Exception\SearchNotSupportedException;
 use MongoDB\Tests\Collection\FunctionalTestCase;
+use PHPUnit\Framework\Attributes\Depends;
 use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 
 class SearchNotSupportedExceptionTest extends FunctionalTestCase
 {
     #[DoesNotPerformAssertions]
     public function testListSearchIndexesNotSupportedException(): void
     {
-        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+        $collection = $this->createCollection($this->getDatabaseName(), 'SearchNotSupportedException');
 
         try {
             $collection->listSearchIndexes();
@@ -27,7 +27,7 @@ public function testListSearchIndexesNotSupportedException(): void
     #[DoesNotPerformAssertions]
     public function testCreateSearchIndexNotSupportedException(): void
     {
-        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+        $collection = $this->createCollection($this->getDatabaseName(), 'SearchNotSupportedException');
 
         try {
             $collection->createSearchIndex(['mappings' => ['dynamic' => false]], ['name' => 'test-search-index']);
@@ -37,9 +37,37 @@ public function testCreateSearchIndexNotSupportedException(): void
         }
     }
 
+    #[DoesNotPerformAssertions]
+    #[Depends('testCreateSearchIndexNotSupportedException')]
+    public function testUpdateSearchIndexNotSupportedException(): void
+    {
+        $collection = $this->createCollection($this->getDatabaseName(), 'SearchNotSupportedException');
+
+        try {
+            $collection->updateSearchIndex('test-search-index', ['mappings' => ['dynamic' => true]]);
+        } catch (SearchNotSupportedException) {
+            // If an exception is thrown because Atlas Search is not supported,
+            // then the test is successful because it has the correct exception class.
+        }
+    }
+
+    #[DoesNotPerformAssertions]
+    #[Depends('testUpdateSearchIndexNotSupportedException')]
+    public function testDropSearchIndexNotSupportedException(): void
+    {
+        $collection = $this->createCollection($this->getDatabaseName(), 'SearchNotSupportedException');
+
+        try {
+            $collection->dropSearchIndex('test-search-index');
+        } catch (SearchNotSupportedException) {
+            // If an exception is thrown because Atlas Search is not supported,
+            // then the test is successful because it has the correct exception class.
+        }
+    }
+
     public function testOtherStageNotFound(): void
     {
-        $collection = new Collection($this->manager, $this->getDatabaseName(), $this->getCollectionName());
+        $collection = $this->createCollection($this->getDatabaseName(), 'SearchNotSupportedException');
 
         try {
             $collection->aggregate([

tests/FunctionalTestCase.php

@@ -8,6 +8,7 @@
 use MongoDB\Collection;
 use MongoDB\Driver\Command;
 use MongoDB\Driver\Exception\CommandException;
+use MongoDB\Driver\Exception\ServerException;
 use MongoDB\Driver\Manager;
 use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\Server;
@@ -435,14 +436,17 @@ protected function skipIfServerVersion(string $operator, string $version, ?strin
     protected function skipIfSearchIndexIsNotSupported(): void
     {
         try {
-            $this->manager->executeReadCommand($this->getDatabaseName(), new Command([
-                'aggregate' => __METHOD__,
-                'pipeline' => [
-                    ['$search' => ['text' => ['query' => 'test', 'path' => 'field']]],
-                ],
-                'cursor' => new stdClass(),
+            $this->createCollection($this->getDatabaseName(), __METHOD__);
+            $this->manager->executeWriteCommand($this->getDatabaseName(), new Command([
+                'dropSearchIndex' => __METHOD__,
+                'name' => 'nonexistent-index',
             ]));
-        } catch (CommandException $exception) {
+        } catch (ServerException $exception) {
+            // Code 27 = Search index does not exist, which indicates that the feature is supported
+            if ($exception->getCode() === 27) {
+                return;
+            }
+
             self::markTestSkipped($exception->getMessage());
         }
     }

tests/UnifiedSpecTests/UnifiedTestRunner.php

@@ -32,6 +32,7 @@
 use function PHPUnit\Framework\assertIsString;
 use function PHPUnit\Framework\assertNotEmpty;
 use function PHPUnit\Framework\assertNotFalse;
+use function preg_match;
 use function preg_replace;
 use function sprintf;
 use function str_starts_with;