PHPLIB-1752 Upgrade to psalm 6.14

Author: GromNaN

.github/workflows/static-analysis.yml

@@ -18,7 +18,7 @@ on:
         required: true
 
 env:
-  PHP_VERSION: "8.2"
+  PHP_VERSION: "8.5"
   # TODO: change to "stable" once 2.0.0 is released
   # DRIVER_VERSION: "stable"
   DRIVER_VERSION: "mongodb/mongo-php-driver@v2.x"

composer.json

@@ -21,7 +21,7 @@
         "phpunit/phpunit": "^10.5.35",
         "rector/rector": "^2.1.4",
         "squizlabs/php_codesniffer": "^3.7",
-        "vimeo/psalm": "6.5.*"
+        "vimeo/psalm": "~6.14.2"
     },
     "replace": {
         "mongodb/builder": "*"

psalm-baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="6.5.1@3f17a6b24a2dbe543e21408c2b19108cf6a355ef">
+<files psalm-version="6.14.2@bbd217fc98c0daa0a13aea2a7f119d03ba3fc9a0">
   <file src="examples/atlas_search.php">
     <MixedArgument>
       <code><![CDATA[$document['name']]]></code>
@@ -23,6 +23,11 @@
       <code><![CDATA[$document['name']]]></code>
     </PossiblyInvalidArrayAccess>
   </file>
+  <file src="examples/gridfs_stream.php">
+    <ImplicitToStringCast>
+      <code><![CDATA[$id]]></code>
+    </ImplicitToStringCast>
+  </file>
   <file src="examples/persistable.php">
     <LessSpecificReturnStatement>
       <code><![CDATA[(object) [
@@ -240,6 +245,10 @@
     </PossiblyInvalidArgument>
   </file>
   <file src="src/ClientBulkWrite.php">
+    <InvalidAttribute>
+      <code><![CDATA[NoDiscard]]></code>
+      <code><![CDATA[NoDiscard]]></code>
+    </InvalidAttribute>
     <PossiblyInvalidArgument>
       <code><![CDATA[$document]]></code>
       <code><![CDATA[$replacement]]></code>
@@ -388,9 +397,6 @@
     <InvalidReturnType>
       <code><![CDATA[CursorInterface<TValue>]]></code>
     </InvalidReturnType>
-    <LessSpecificImplementedReturnType>
-      <code><![CDATA[CursorInterface<TValue>]]></code>
-    </LessSpecificImplementedReturnType>
     <MixedArgument>
       <code><![CDATA[$reply->cursor->nextBatch]]></code>
     </MixedArgument>
@@ -559,9 +565,6 @@
     <MixedMethodCall>
       <code><![CDATA[isInTransaction]]></code>
     </MixedMethodCall>
-    <MixedReturnStatement>
-      <code><![CDATA[$server->executeBulkWriteCommand($this->bulkWriteCommand, $options)]]></code>
-    </MixedReturnStatement>
   </file>
   <file src="src/Operation/Count.php">
     <MixedAssignment>

psalm.xml.dist

@@ -45,5 +45,8 @@
                 <directory name="examples" />
             </errorLevel>
         </RiskyTruthyFalsyComparison>
+
+        <MissingOverrideAttribute errorLevel="suppress" />
+        <ClassMustBeFinal errorLevel="info" />
     </issueHandlers>
 </psalm>

src/Client.php

@@ -54,6 +54,7 @@
 use function is_array;
 use function is_string;
 
+/** @psalm-no-seal-properties */
 class Client implements Stringable
 {
     public const DEFAULT_URI = 'mongodb://127.0.0.1/';

src/Database.php

@@ -58,6 +58,7 @@
 use function is_bool;
 use function strlen;
 
+/** @psalm-no-seal-properties */
 class Database implements Stringable
 {
     private const DEFAULT_TYPE_MAP = [