[Bug]: SMB shares stopped mounting in NC25.0.3 after Fedora 37 update

[wioch]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

After update to NC 25.0.3 (from 25.0.2) and after maintenance system update (Fedora 37) external Samba shares stopped working and cannot be mounted. SMB shares are marked with red exclamation mark.

As for Fedora update, there were minor updates. Example of version update for selected packages:
php: from 8.1.13-1.fc37 to 8.1.15-1.fc37
httpd: from 2.4.54-5.fc37 to 2.4.55-1.fc37
samba: from 4.17.4-2.fc37 to 4.17.5-0.fc37

Steps I've taken to troubleshoot:

• disable/enable SELinux - no improvement
• mounted shares via smbclient from linux console - shares are working correctly
• deploy fresh NC 25.0.2 and 25.0.3 - same issue with SMB shares
• checked NativeFileInfo.php on both NC 25.0.2 and 25.0.3, file is exactly the same

Preliminary conclusion: Linux update brought something that may not be compatible with Icewind app for SMB support.

Steps to reproduce

1. Update Nextcloud from 25.0.2 to 25.0.3 via web installer
2. Maintenance Fedora 37 update, followed by reboot
3. External Samba shares not working anymore

Expected behavior

Every Samba share working correctly after both NC update and OS update.

Installation method

Community Web installer on a VPS or web space

Operating system

RHEL/CentOS

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.domain.local"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "25.0.3.2",
        "overwrite.cli.url": "https:\/\/cloud.domain.local",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "updater.release.channel": "stable",
        "default_phone_region": "PL",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "mail_smtpmode": "smtp",
        "mail_smtpauth": 1,
        "mail_sendmailmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Enabled:
  - admin_audit: 1.15.0
  - bruteforcesettings: 2.5.0
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - contactsinteraction: 1.6.0
  - dav: 1.24.0
  - federatedfilesharing: 1.15.0
  - files: 1.20.1
  - files_external: 1.17.0
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - firstrunwizard: 2.14.0
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 2.0.1
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - related_resources: 1.0.3
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 7.0.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - workflowengine: 2.7.0
Disabled:
  - activity: 2.13.1
  - calendar: 4.2.3
  - comments: 1.10.0
  - contacts: 5.1.0
  - dashboard: 7.0.0
  - encryption
  - federation: 1.10.1
  - recommendations: 1.4.0
  - suspicious_login
  - systemtags: 1.10.0
  - user_ldap
  - weather_status: 1.0.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

[PHP] Error: Error: Undefined array key 1 at /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php#46 at <<closure>>

 0. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php line 46
    OC\Log\ErrorHandler::onError(2, "Undefined array key 1", "/datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php", 46)
 1. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php line 69
    Icewind\SMB\Native\NativeFileInfo->stat()
 2. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php line 114
    Icewind\SMB\Native\NativeFileInfo->getSize()
 3. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 191
    Icewind\SMB\Native\NativeShare->stat("/")
 4. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 348
    OCA\Files_External\Lib\Storage\SMB->getFileInfo("/")
 5. /datashare/html/domain.local/nextcloud_nc21/lib/private/Files/Storage/Common.php line 462
    OCA\Files_External\Lib\Storage\SMB->stat("")
 6. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 729
    OC\Files\Storage\Common->test()
 7. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/MountConfig.php line 131
    OCA\Files_External\Lib\Storage\SMB->test("*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***")
 8. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Controller/StoragesController.php line 288
    OCA\Files_External\MountConfig::getBackendStatus("*** sensitive parameters replaced ***")
 9. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Controller/UserGlobalStoragesController.php line 126
    OCA\Files_External\Controller\StoragesController->updateStorageStatus("*** sensitive parameters replaced ***")
10. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/Http/Dispatcher.php line 225
    OCA\Files_External\Controller\UserGlobalStoragesController->show(8, "*** sensitive parameters replaced ***")
11. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/Http/Dispatcher.php line 133
    OC\AppFramework\Http\Dispatcher->executeController(OCA\Files_Extern ... {}, "show")
12. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/App.php line 172
    OC\AppFramework\Http\Dispatcher->dispatch(OCA\Files_Extern ... {}, "show")
13. /datashare/html/domain.local/nextcloud_nc21/lib/private/Route/Router.php line 298
    OC\AppFramework\App::main("OCA\\Files_Exte ... r", "show", OC\AppFramework\ ... {}, ["8","files_exte ... "])
14. /datashare/html/domain.local/nextcloud_nc21/lib/base.php line 1047
    OC\Route\Router->match("/apps/files_ext ... 8")
15. /datashare/html/domain.local/nextcloud_nc21/index.php line 36
    OC::handleRequest()

GET /index.php/apps/files_external/userglobalstorages/8?testOnly=false
from 10.3.1.99 by root at 2023-02-17T18:37:49+00:00


[no app in context] Warning: Icewind\SMB\Exception\Exception: Invalid attribute response at <<closure>>

 0. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php line 69
    Icewind\SMB\Native\NativeFileInfo->stat()
 1. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php line 114
    Icewind\SMB\Native\NativeFileInfo->getSize()
 2. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 191
    Icewind\SMB\Native\NativeShare->stat("/")
 3. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 348
    OCA\Files_External\Lib\Storage\SMB->getFileInfo("/")
 4. /datashare/html/domain.local/nextcloud_nc21/lib/private/Files/Storage/Common.php line 462
    OCA\Files_External\Lib\Storage\SMB->stat("")
 5. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Lib/Storage/SMB.php line 729
    OC\Files\Storage\Common->test()
 6. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/MountConfig.php line 131
    OCA\Files_External\Lib\Storage\SMB->test("*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***")
 7. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Controller/StoragesController.php line 288
    OCA\Files_External\MountConfig::getBackendStatus("*** sensitive parameters replaced ***")
 8. /datashare/html/domain.local/nextcloud_nc21/apps/files_external/lib/Controller/GlobalStoragesController.php line 201
    OCA\Files_External\Controller\StoragesController->updateStorageStatus("*** sensitive parameters replaced ***")
 9. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/Http/Dispatcher.php line 225
    OCA\Files_External\Controller\GlobalStoragesController->update("*** sensitive parameters replaced ***")
10. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/Http/Dispatcher.php line 133
    OC\AppFramework\Http\Dispatcher->executeController(OCA\Files_Extern ... {}, "update")
11. /datashare/html/domain.local/nextcloud_nc21/lib/private/AppFramework/App.php line 172
    OC\AppFramework\Http\Dispatcher->dispatch(OCA\Files_Extern ... {}, "update")
12. /datashare/html/domain.local/nextcloud_nc21/lib/private/Route/Router.php line 298
    OC\AppFramework\App::main("OCA\\Files_Exte ... r", "update", OC\AppFramework\ ... {}, ["8","files_exte ... "])
13. /datashare/html/domain.local/nextcloud_nc21/lib/base.php line 1047
    OC\Route\Router->match("/apps/files_external/globalstorages/8")
14. /datashare/html/domain.local/nextcloud_nc21/index.php line 36
    OC::handleRequest()

PUT /index.php/apps/files_external/globalstorages/8
from 10.3.1.99 by root at 2023-02-17T18:56:18+00:00


[webdav] Error: Sabre\DAV\Exception\ServiceUnavailable: Storage with mount id 7 is not available at <<closure>>

 0. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Tree.php line 78
    OCA\DAV\Connector\Sabre\Directory->getChild("SMB_czarny")
 1. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 971
    Sabre\DAV\Tree->getNodeForPath("files/root/SMB_czarny")
 2. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 1662
    Sabre\DAV\Server->getPropertiesIteratorForPath("files/root/SMB_czarny", ["{DAV:}getetag"], 0)
 3. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 1647
    Sabre\DAV\Server->writeMultiStatus(Sabre\Xml\Writer ... ]}, Generator {}, false)
 4. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/CorePlugin.php line 346
    Sabre\DAV\Server->generateMultiStatus(Generator {}, false)
 5. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/event/lib/WildcardEmitterTrait.php line 89
    Sabre\DAV\CorePlugin->httpPropFind(Sabre\HTTP\Request {}, Sabre\HTTP\Response {})
 6. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 472
    Sabre\DAV\Server->emit("method:PROPFIND", [Sabre\HTTP\Requ ... }])
 7. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 253
    Sabre\DAV\Server->invokeMethod(Sabre\HTTP\Request {}, Sabre\HTTP\Response {})
 8. /datashare/html/domain.local/nextcloud_nc21/3rdparty/sabre/dav/lib/DAV/Server.php line 321
    Sabre\DAV\Server->start()
 9. /datashare/html/domain.local/nextcloud_nc21/apps/dav/lib/Server.php line 360
    Sabre\DAV\Server->exec()
10. /datashare/html/domain.local/nextcloud_nc21/apps/dav/appinfo/v2/remote.php line 35
    OCA\DAV\Server->exec()
11. /datashare/html/domain.local/nextcloud_nc21/remote.php line 171
    require_once("/datashare/html ... p")

PROPFIND /remote.php/dav/files/root/SMB_czarny/
from 10.3.1.1 by root at 2023-02-17T18:50:55+00:00


[no app in context] Warning: Icewind\SMB\Exception\Exception: Invalid attribute response at <<closure>>

 0. /datashare/html/domain.local/nc2503/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php line 69
    Icewind\SMB\Native\NativeFileInfo->stat()
 1. /datashare/html/domain.local/nc2503/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php line 114
    Icewind\SMB\Native\NativeFileInfo->getSize()
 2. /datashare/html/domain.local/nc2503/apps/files_external/lib/Lib/Storage/SMB.php line 191
    Icewind\SMB\Native\NativeShare->stat("/")
 3. /datashare/html/domain.local/nc2503/apps/files_external/lib/Lib/Storage/SMB.php line 348
    OCA\Files_External\Lib\Storage\SMB->getFileInfo("/")
 4. /datashare/html/domain.local/nc2503/lib/private/Files/Storage/Common.php line 462
    OCA\Files_External\Lib\Storage\SMB->stat("")
 5. /datashare/html/domain.local/nc2503/apps/files_external/lib/Lib/Storage/SMB.php line 729
    OC\Files\Storage\Common->test()
 6. /datashare/html/domain.local/nc2503/apps/files_external/lib/MountConfig.php line 131
    OCA\Files_External\Lib\Storage\SMB->test("*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***")
 7. /datashare/html/domain.local/nc2503/apps/files_external/lib/Controller/StoragesController.php line 288
    OCA\Files_External\MountConfig::getBackendStatus("*** sensitive parameters replaced ***")
 8. /datashare/html/domain.local/nc2503/apps/files_external/lib/Controller/StoragesController.php line 363
    OCA\Files_External\Controller\StoragesController->updateStorageStatus("*** sensitive parameters replaced ***")
 9. /datashare/html/domain.local/nc2503/lib/private/AppFramework/Http/Dispatcher.php line 225
    OCA\Files_External\Controller\StoragesController->show(1, "*** sensitive parameters replaced ***")
10. /datashare/html/domain.local/nc2503/lib/private/AppFramework/Http/Dispatcher.php line 133
    OC\AppFramework\Http\Dispatcher->executeController(OCA\Files_Extern ... {}, "show")
11. /datashare/html/domain.local/nc2503/lib/private/AppFramework/App.php line 172
    OC\AppFramework\Http\Dispatcher->dispatch(OCA\Files_Extern ... {}, "show")
12. /datashare/html/domain.local/nc2503/lib/private/Route/Router.php line 298
    OC\AppFramework\App::main("OCA\\Files_Exte ... r", "show", OC\AppFramework\ ... {}, ["1","files_exte ... "])
13. /datashare/html/domain.local/nc2503/lib/base.php line 1047
    OC\Route\Router->match("/apps/files_external/globalstorages/1")
14. /datashare/html/domain.local/nc2503/index.php line 36
    OC::handleRequest()

GET /index.php/apps/files_external/globalstorages/1?testOnly=true
from 10.3.1.99 by root at 2023-02-18T06:09:12+00:00

Additional info

No response

[ib54003]

Try downgrade to libsmbclient-4.17.2 as discribed here solved it for me.

# dnf downgrade libsmbclient-4.17.2 --allowerasing
# systemctl restart php-fpm.service

[wioch]

Downgraded to 4.17.1, SMB shares are now working, Thank you !
But still, it is a WoA, not solution (I may not remember to exclude samba from next update run).

[nicrame]

I also had problems with smbclient library in the past with Nextcloud. Funny thing is, that removing php-smbclient library package made it work correctly for me those days (i was using RockyLinux/RHEL 8).
I was trying to figure this out, but diagnosing libraries is very hard, and i didn't see any interest in that from anyone.

[sempervictus]

Downgrading client libraries is probably not an option in corporate environments where patch levels have to be maintained at current (or at least "not flagging as being vulnerable to high or critical severity concerns") versions.

Is this due to the recent CIFS machinations by Microsoft, something in Samba, or some interaction between recent Samba changes and the PHP API?

[wioch]

As I've mentioned, it is workaround, not solution. Either way, with lib-smbclient:

• 4.17.1 shares are working
• 4.17.5 shares were NOT working
  and I have both Windows and Linux SMB shares.

[puzzle-it-nu]

Problem is probably because of the getxattr behaviour change in 4.17.5.
See the release notes on the samba site: https://www.samba.org/samba/history/samba-4.17.5.html

[wioch]

Following the trail, looks like return codes were corrected: https://bugzilla.samba.org/show_bug.cgi?id=14808

[sempervictus]

Reached out to the committer listed atop that changelog, and according to him, the callers will need to be updated:

I'm afraid the code change was correct. The spec says the
smbc_getxattr() call should return 0 on success, -1 on
error.

The callers are going to have to be fixed, sorry.

[bnerickson]

Related eduardok/libsmbclient-php#98

[makabar]

Have to report the same issue un Ubuntu 20.04 (Samba 4.17.5) too.
Downgrade to 4.13.x did not solve the problem :-(