From d7cac96e7356b590f2b66a516a88b2568bb51f2f Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Sun, 13 Jul 2025 11:08:28 -0700 Subject: [PATCH 1/9] Add web-infra onboarding docs Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 onboarding/web-infra.md diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md new file mode 100644 index 0000000..bcfd086 --- /dev/null +++ b/onboarding/web-infra.md @@ -0,0 +1,23 @@ +# Web Infrastructure Onboarding + +This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team. + +Please note these tasks should only be performed after the person's nomination has passed. + +## Tasks + +Tasks prefixed by `Member:` are for the new member to complete. +Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. + +- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. + - Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. +- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. +- [ ] Web Admin: Recommend member sign their Git commits if not already doing so. +- [ ] Web Admin: Add member to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. +- [ ] Member: Add yourself to the [membership list document](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra). +- [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. +- [ ] Web Admin: Invite member to Node.js' Sentry account. + - [ ] Member: Enable physical or passkey 2FA on their Sentry account. + +Note there isn't currently a set level of access that Web Infra members has to some resources such as Cloudflare. +You may be granted access if needed, but will not be given it initially since we do not control it. From adaaff6dad9fc442b4ee7819a5b3a338e5aa77fe Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 16 Jul 2025 16:22:31 -0500 Subject: [PATCH 2/9] Apply suggestions from code review Co-authored-by: Aviv Keller Co-authored-by: Matt Cowley --- onboarding/web-infra.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index bcfd086..36f630e 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -1,8 +1,8 @@ -# Web Infrastructure Onboarding +# @nodejs/web-infra Onboarding -This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team. +This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). -Please note these tasks should only be performed after the person's nomination has passed. +Please note these tasks should only be performed after an individual's nomination has passed. ## Tasks @@ -18,6 +18,10 @@ Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to compl - [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. - [ ] Web Admin: Invite member to Node.js' Sentry account. - [ ] Member: Enable physical or passkey 2FA on their Sentry account. +- [ ] Web Admin: Invite member to Node.js' Vercel account. + - [ ] Member: Enable physical or passkey 2FA on their Vercel account. -Note there isn't currently a set level of access that Web Infra members has to some resources such as Cloudflare. +There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare. + +Should you need additional access, it may be granted, however, access is not given by default. You may be granted access if needed, but will not be given it initially since we do not control it. From 2dc9f131fe6d38afcd03fdb435954b3b93deff98 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Sun, 27 Jul 2025 09:17:37 -0700 Subject: [PATCH 3/9] review Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index 36f630e..9f26c60 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -3,25 +3,30 @@ This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). Please note these tasks should only be performed after an individual's nomination has passed. +To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ## Tasks -Tasks prefixed by `Member:` are for the new member to complete. -Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. - -- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. - - Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. -- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. -- [ ] Web Admin: Recommend member sign their Git commits if not already doing so. -- [ ] Web Admin: Add member to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. -- [ ] Member: Add yourself to the [membership list document](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra). -- [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. -- [ ] Web Admin: Invite member to Node.js' Sentry account. - - [ ] Member: Enable physical or passkey 2FA on their Sentry account. -- [ ] Web Admin: Invite member to Node.js' Vercel account. - - [ ] Member: Enable physical or passkey 2FA on their Vercel account. +- [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. + - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. + - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. +- [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. +- [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. +- [ ] A Web Admin should invite the nominee to Node.js' Sentry account. + - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. +- [ ] A Web Admin should invite the nominee to Node.js' Vercel account. + - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. +- [ ] The nominee should open a pull request in [nodejs/email](https://github.com/nodejs/email) to add their email to the `nodejs-crowdin` email chain. +- [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. + +### Recommendations + +- [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account +- [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. +- [ ] A Web Admin should recommend the nominee sign their Git commits. + +## Notes There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare. -Should you need additional access, it may be granted, however, access is not given by default. -You may be granted access if needed, but will not be given it initially since we do not control it. +Should you need additional access, it may be granted, however, access is not given by default since we do not control it. From 64e48f055407832469d1efc4c68355041b885ff9 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 22 Oct 2025 14:50:11 -0700 Subject: [PATCH 4/9] Apply suggestions from code review Co-authored-by: Aviv Keller --- onboarding/web-infra.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index 9f26c60..429b9e2 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -16,7 +16,9 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. - [ ] A Web Admin should invite the nominee to Node.js' Vercel account. - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. -- [ ] The nominee should open a pull request in [nodejs/email](https://github.com/nodejs/email) to add their email to the `nodejs-crowdin` email chain. +- [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)) + - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) + - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) - [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. ### Recommendations From fbe51114576094f07f309d4de4abf910b9980145 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 22 Oct 2025 15:09:40 -0700 Subject: [PATCH 5/9] Apply suggestions from code review Co-authored-by: Aviv Keller --- onboarding/web-infra.md | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index 429b9e2..e44d206 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -7,14 +7,11 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ## Tasks -- [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. - - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. - - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. -- [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. +- [ ] Add the **Nominee** to the @nodejs/web-infra team on GitHub. - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. -- [ ] A Web Admin should invite the nominee to Node.js' Sentry account. - - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. -- [ ] A Web Admin should invite the nominee to Node.js' Vercel account. +- [ ] Grant the **Nominee** access to Sentry. + - [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account. +- [ ] Grant the **Nominee** access to Vercel. - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. - [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)) - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) @@ -23,9 +20,9 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ### Recommendations -- [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account -- [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. -- [ ] A Web Admin should recommend the nominee sign their Git commits. +- [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. +- [ ] The **Nominee** should have a SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. +- [ ] The **Nominee** should sign their Git commits. ## Notes From 6ecb18b1029a92efdc1f2b712912b5617f1ff844 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 22 Oct 2025 15:13:21 -0700 Subject: [PATCH 6/9] Apply suggestions from code review --- onboarding/web-infra.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index e44d206..e037d11 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -21,7 +21,7 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ### Recommendations - [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. -- [ ] The **Nominee** should have a SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. +- [ ] The **Nominee** should have any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. - [ ] The **Nominee** should sign their Git commits. ## Notes From 64bc2c122bdf7e623d3a8339efea6ef5a678aae9 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 22 Oct 2025 17:39:23 -0700 Subject: [PATCH 7/9] Update onboarding/web-infra.md --- onboarding/web-infra.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index e037d11..eec146b 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -8,7 +8,7 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ## Tasks - [ ] Add the **Nominee** to the @nodejs/web-infra team on GitHub. -- [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. +- [ ] The **Nominee** should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. - [ ] Grant the **Nominee** access to Sentry. - [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account. - [ ] Grant the **Nominee** access to Vercel. From 2f6dc2d0689ec69951a2b4fbf342a5d4ea652c79 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Mon, 3 Nov 2025 09:36:36 -0800 Subject: [PATCH 8/9] add search console Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index eec146b..8283439 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -14,14 +14,15 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). - [ ] Grant the **Nominee** access to Vercel. - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. - [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)) - - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) - - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) + - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) + - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) +- [ ] Grant the **Nominee** access to Search Console - [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. ### Recommendations - [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. -- [ ] The **Nominee** should have any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. +- [ ] The **Nominee** should have any SSH or GPG key attached to their GitHub account have passphrases and/or be stored on a physical 2FA device. - [ ] The **Nominee** should sign their Git commits. ## Notes From 7ff63d89d4d21f7675642d68ead75c60c3eb32f4 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Mon, 3 Nov 2025 09:58:46 -0800 Subject: [PATCH 9/9] slack channels and status page Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index 8283439..2583e00 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -13,11 +13,18 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). - [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account. - [ ] Grant the **Nominee** access to Vercel. - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. -- [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)) +- [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email)): - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) -- [ ] Grant the **Nominee** access to Search Console +- [ ] Grant the **Nominee** access to Search Console. +- [ ] Grant the **Nominee** access to the Node.js Status Page. - [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. +- [ ] Add the **Nominee** to the following OpenJS Slack channels: + - [ ] `#nodejs-website` + - [ ] `#nodejs-web-infra` + - [ ] `#nodejs-web-infra-alerts` + - [ ] `#ext-nodejs-cloudflare` + - [ ] `#ext-nodejs-sentry` ### Recommendations