review comments

Author: VipulMascarenhas

ads/aqua/common/utils.py

@@ -100,23 +100,6 @@ def get_status(evaluation_status: str, job_run_status: str = None):
     JobRun.LIFECYCLE_STATE_NEEDS_ATTENTION: "Missing jobrun information.",
 }
 
-CONSOLE_LINK_RESOURCE_TYPE_MAPPING = dict(
-    datasciencemodel="models",
-    datasciencemodeldeployment="model-deployments",
-    datasciencemodeldeploymentdev="model-deployments",
-    datasciencemodeldeploymentint="model-deployments",
-    datasciencemodeldeploymentpre="model-deployments",
-    datasciencejob="jobs",
-    datasciencejobrun="job-runs",
-    datasciencejobrundev="job-runs",
-    datasciencejobrunint="job-runs",
-    datasciencejobrunpre="job-runs",
-    datasciencemodelversionset="model-version-sets",
-    datasciencemodelversionsetpre="model-version-sets",
-    datasciencemodelversionsetint="model-version-sets",
-    datasciencemodelversionsetdev="model-version-sets",
-)
-
 
 def random_color_generator(word: str):
     seed = sum([ord(c) for c in word]) % 13

ads/aqua/constants.py

@@ -41,3 +41,20 @@
 SERVICE_MANAGED_CONTAINER_URI_SCHEME = "dsmc://"
 SUPPORTED_FILE_FORMATS = ["jsonl"]
 MODEL_BY_REFERENCE_OSS_PATH_KEY = "artifact_location"
+
+CONSOLE_LINK_RESOURCE_TYPE_MAPPING = dict(
+    datasciencemodel="models",
+    datasciencemodeldeployment="model-deployments",
+    datasciencemodeldeploymentdev="model-deployments",
+    datasciencemodeldeploymentint="model-deployments",
+    datasciencemodeldeploymentpre="model-deployments",
+    datasciencejob="jobs",
+    datasciencejobrun="job-runs",
+    datasciencejobrundev="job-runs",
+    datasciencejobrunint="job-runs",
+    datasciencejobrunpre="job-runs",
+    datasciencemodelversionset="model-version-sets",
+    datasciencemodelversionsetpre="model-version-sets",
+    datasciencemodelversionsetint="model-version-sets",
+    datasciencemodelversionsetdev="model-version-sets",
+)

ads/aqua/evaluation/evaluation.py

@@ -50,6 +50,7 @@
     JOB_INFRASTRUCTURE_TYPE_DEFAULT_NETWORKING,
     NB_SESSION_IDENTIFIER,
     UNKNOWN,
+    CONSOLE_LINK_RESOURCE_TYPE_MAPPING,
 )
 from ads.aqua.evaluation.constants import *
 from ads.aqua.evaluation.entities import *
@@ -1344,7 +1345,7 @@ def _build_resource_identifier(
     ) -> AquaResourceIdentifier:
         """Constructs AquaResourceIdentifier based on the given ocid and display name."""
         try:
-            resource_type = utils.CONSOLE_LINK_RESOURCE_TYPE_MAPPING.get(
+            resource_type = CONSOLE_LINK_RESOURCE_TYPE_MAPPING.get(
                 utils.get_resource_type(id)
             )
 

ads/aqua/model/model.py

@@ -667,6 +667,7 @@ def _create_model_catalog_entry(
                 f"Using artifact from service bucket instead of {os_path}"
             )
 
+            # todo: implement generic copy_folder method
             # copy model config from artifact path to user bucket
             copy_model_config(
                 artifact_path=artifact_path, os_path=os_path, auth=self._auth