revert md default params

Author: VipulMascarenhas

ads/aqua/modeldeployment/deployment.py

@@ -527,7 +527,7 @@ def get_deployment_default_params(
         self,
         model_id: str,
         instance_shape: str,
-    ) -> Dict:
+    ) -> List[str]:
         """Gets the default params set in the deployment configs for the given model and instance shape.
 
         Parameters
@@ -546,8 +546,6 @@ def get_deployment_default_params(
 
         """
         default_params = []
-        container_type = UNKNOWN
-
         model = DataScienceModel.from_id(model_id)
         try:
             container_type_key = model.custom_metadata_list.get(
@@ -572,12 +570,10 @@ def get_deployment_default_params(
                     params = config_parameters.get(
                         InferenceContainerParamType.PARAM_TYPE_VLLM, UNKNOWN
                     )
-                    container_type = InferenceContainerType.CONTAINER_TYPE_VLLM
                 elif InferenceContainerType.CONTAINER_TYPE_TGI in container_type_key:
                     params = config_parameters.get(
                         InferenceContainerParamType.PARAM_TYPE_TGI, UNKNOWN
                     )
-                    container_type = InferenceContainerType.CONTAINER_TYPE_TGI
                 else:
                     params = UNKNOWN
                     logger.debug(
@@ -588,10 +584,7 @@ def get_deployment_default_params(
                     # account for param that can have --arg but no values, e.g. --trust-remote-code
                     default_params.extend(get_params_list(params))
 
-        return dict(
-            container_type=container_type,
-            params=default_params,
-        )
+        return default_params
 
     def validate_deployment_params(
         self, model_id: str, params: List[str] = None

tests/unitary/with_extras/aqua/test_deployment.py

@@ -423,38 +423,29 @@ def yaml_to_json(input_file):
         [
             (
                 "VLLM_PARAMS",
-                "vllm",
                 "odsc-vllm-serving",
                 ["--max-model-len 4096", "--seed 42", "--trust-remote-code"],
             ),
             (
                 "VLLM_PARAMS",
-                "vllm",
                 "odsc-vllm-serving",
                 [],
             ),
             (
                 "TGI_PARAMS",
-                "tgi",
                 "odsc-tgi-serving",
                 ["--sharded true", "--trust-remote-code"],
             ),
             (
                 "CUSTOM_PARAMS",
-                "",
                 "custom-container-key",
                 ["--max-model-len 4096", "--seed 42", "--trust-remote-code"],
             ),
         ]
     )
     @patch("ads.model.datascience_model.DataScienceModel.from_id")
     def test_get_deployment_default_params(
-        self,
-        container_params_field,
-        container_type,
-        container_type_key,
-        params,
-        mock_from_id,
+        self, container_params_field, container_type_key, params, mock_from_id
     ):
         """Test for fetching config details for a given deployment."""
 
@@ -480,12 +471,10 @@ def test_get_deployment_default_params(
         result = self.app.get_deployment_default_params(
             TestDataset.MODEL_ID, TestDataset.DEPLOYMENT_SHAPE_NAME
         )
-
-        assert result["container_type"] == container_type
         if container_params_field == "CUSTOM_PARAMS":
-            assert result["params"] == []
+            assert result == []
         else:
-            assert result["params"] == params
+            assert result == params
 
     @parameterized.expand(
         [