Skip to content

Commit 621ec25

Browse files
authored
Followup comment in #795: reuse the logger in ads.init (#800)
1 parent fa04a82 commit 621ec25

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

ads/aqua/__init__.py

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@
44
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
55

66

7-
import logging
87
import os
9-
import sys
108

11-
from ads import set_auth
9+
from ads import logger, set_auth
1210
from ads.aqua.utils import fetch_service_compartment
1311
from ads.config import NB_SESSION_OCID, OCI_RESOURCE_PRINCIPAL_VERSION
1412

@@ -21,25 +19,7 @@ def get_logger_level():
2119
return level
2220

2321

24-
def configure_aqua_logger():
25-
"""Configures the AQUA logger."""
26-
log_level = get_logger_level()
27-
logger = logging.getLogger(__name__)
28-
logger.setLevel(log_level)
29-
30-
handler = logging.StreamHandler(sys.stdout)
31-
formatter = logging.Formatter(
32-
"%(asctime)s - %(name)s.%(module)s - %(levelname)s - %(message)s"
33-
)
34-
handler.setFormatter(formatter)
35-
handler.setLevel(log_level)
36-
37-
logger.addHandler(handler)
38-
logger.propagate = False
39-
return logger
40-
41-
42-
logger = configure_aqua_logger()
22+
logger.setLevel(get_logger_level())
4323

4424

4525
def set_log_level(log_level: str):

ads/aqua/evaluation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ def _build_evaluation_runtime(
777777
)
778778

779779
return runtime
780-
780+
781781
@staticmethod
782782
def _get_service_model_name(
783783
source: Union[ModelDeployment, DataScienceModel]
@@ -803,7 +803,7 @@ def _get_service_model_name(
803803
return source.freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG.value)
804804
else:
805805
return extract_id_and_name_from_tag(fine_tuned_model_tag)[1]
806-
806+
807807
return source.display_name
808808

809809
@staticmethod

0 commit comments

Comments
 (0)