[GR-26331] Fix slow path fallbacks in MMap module and CExtParseArgumentsNode.

PullRequest: graalpython/1312

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MMapModuleBuiltins.java

@@ -98,19 +98,23 @@ public abstract static class MMapNode extends PythonBuiltinNode {
         private final BranchProfile invalidLengthProfile = BranchProfile.create();
 
         @Specialization(guards = {"isAnonymous(fd)", "isNoValue(access)", "isNoValue(offset)"})
-        PMMap doAnonymous(Object clazz, @SuppressWarnings("unused") long fd, int length, @SuppressWarnings("unused") Object tagname, @SuppressWarnings("unused") PNone access,
+        PMMap doAnonymous(Object clazz, @SuppressWarnings("unused") long fd, long length, @SuppressWarnings("unused") Object tagname, @SuppressWarnings("unused") PNone access,
                         @SuppressWarnings("unused") PNone offset) {
             checkLength(length);
-            return factory().createMMap(clazz, new AnonymousMap(length), length, 0);
+            if (length > Integer.MAX_VALUE) {
+                invalidLengthProfile.enter();
+                throw raise(PythonBuiltinClassType.OverflowError, ErrorMessages.PYTHON_INT_TOO_LARGE_TO_CONV_TO, "int");
+            }
+            return factory().createMMap(clazz, new AnonymousMap((int) length), length, 0);
         }
 
         @Specialization(guards = {"fd >= 0", "isNoValue(access)", "isNoValue(offset)"})
-        PMMap doFile(Object clazz, long fd, int length, Object tagname, @SuppressWarnings("unused") PNone access, @SuppressWarnings("unused") PNone offset) {
+        PMMap doFile(Object clazz, long fd, long length, Object tagname, @SuppressWarnings("unused") PNone access, @SuppressWarnings("unused") PNone offset) {
             return doFile(clazz, fd, length, tagname, ACCESS_DEFAULT, 0);
         }
 
         @Specialization(guards = {"fd >= 0", "isNoValue(offset)"})
-        PMMap doFile(Object clazz, long fd, int length, Object tagname, int access, @SuppressWarnings("unused") PNone offset) {
+        PMMap doFile(Object clazz, long fd, long length, Object tagname, int access, @SuppressWarnings("unused") PNone offset) {
             return doFile(clazz, fd, length, tagname, access, 0);
         }
 
@@ -200,30 +204,36 @@ public AnonymousMap(int cap) {
             this.data = new byte[cap];
         }
 
+        @Override
         public boolean isOpen() {
             return open;
         }
 
+        @Override
         public void close() throws IOException {
             open = false;
         }
 
+        @Override
         public int read(ByteBuffer dst) throws IOException {
             int nread = Math.min(dst.remaining(), data.length - cur);
             dst.put(data, cur, nread);
             return nread;
         }
 
+        @Override
         public int write(ByteBuffer src) throws IOException {
             int nwrite = Math.min(src.remaining(), data.length - cur);
             src.get(data, cur, nwrite);
             return nwrite;
         }
 
+        @Override
         public long position() throws IOException {
             return cur;
         }
 
+        @Override
         public SeekableByteChannel position(long newPosition) throws IOException {
             if (newPosition < 0) {
                 throw new IllegalArgumentException();
@@ -232,10 +242,12 @@ public SeekableByteChannel position(long newPosition) throws IOException {
             return this;
         }
 
+        @Override
         public long size() throws IOException {
             return data.length;
         }
 
+        @Override
         public SeekableByteChannel truncate(long size) throws IOException {
             for (int i = 0; i < size; i++) {
                 data[i] = 0;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/common/CExtParseArgumentsNode.java

@@ -1035,13 +1035,13 @@ static Object doNoKeywords(ParserState state, Object kwds, Object kwdnames, bool
             return out;
         }
 
-        @Specialization(replaces = "doNoKeywords", limit = "1")
+        @Specialization(replaces = "doNoKeywords")
         static Object doGeneric(ParserState state, Object kwds, Object kwdnames, boolean keywordsOnly,
                         @Shared("lenNode") @Cached SequenceNodes.LenNode lenNode,
                         @Shared("getSequenceStorageNode") @Cached GetSequenceStorageNode getSequenceStorageNode,
                         @Shared("getItemNode") @Cached SequenceStorageNodes.GetItemDynamicNode getItemNode,
                         @Cached HashingCollectionNodes.GetDictStorageNode getDictStorageNode,
-                        @CachedLibrary("kwdnames") InteropLibrary kwdnamesLib,
+                        @CachedLibrary(limit = "1") InteropLibrary kwdnamesLib,
                         @CachedLibrary(limit = "1") HashingStorageLibrary lib,
                         @Cached PCallCExtFunction callCStringToString) throws InteropException {