Enable tests related to umask in test_import, fix guards in ObjectToOpaquePathNode

Author: otethal

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -2124,13 +2124,13 @@ Object noCheck(VirtualFrame frame, Object obj, @SuppressWarnings("unused") boole
             return stringOrBytesToOpaquePathNode.execute(fspathNode.call(frame, obj));
         }
 
-        @Specialization(replaces = "noCheck", limit = "2")
-        Object withCheck(VirtualFrame frame, Object obj, boolean checkEmpty,
+        @Specialization(guards = "checkEmpty", limit = "2")
+        Object withCheck(VirtualFrame frame, Object obj, @SuppressWarnings("unused") boolean checkEmpty,
                         @Cached FspathNode fspathNode,
                         @CachedLibrary("obj") PythonObjectLibrary lib,
                         @Cached StringOrBytesToOpaquePathNode stringOrBytesToOpaquePathNode) {
             Object stringOrBytes = fspathNode.call(frame, obj);
-            if (checkEmpty && lib.lengthWithFrame(obj, frame) == 0) {
+            if (lib.lengthWithFrame(obj, frame) == 0) {
                 throw raise(ValueError, ErrorMessages.EXECV_ARG2_FIRST_ELEMENT_CANNOT_BE_EMPTY);
             }
             return stringOrBytesToOpaquePathNode.execute(stringOrBytes);

graalpython/lib-python/3/test/test_import/__init__.py

@@ -512,7 +512,6 @@ def test_dll_dependency_import(self):
 class FilePermissionTests(unittest.TestCase):
     # tests for file mode on cached .pyc files
 
-    @impl_detail("GR-25941: truffle umask support", graalvm=False)
     @unittest.skipUnless(os.name == 'posix',
                          "test meaningful only on posix systems")
     def test_creation_mode(self):
@@ -856,7 +855,6 @@ def test_import_pyc_path(self):
                         'bytecode file {!r} for {!r} does not '
                         'exist'.format(pyc_path, TESTFN))
 
-    @impl_detail("GR-25941: truffle umask support", graalvm=False)
     @unittest.skipUnless(os.name == 'posix',
                          "test meaningful only on posix systems")
     @unittest.skipIf(hasattr(os, 'geteuid') and os.geteuid() == 0,