Check fd range in select()

Author: otethal

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SelectModuleBuiltins.java

@@ -42,6 +42,8 @@
 
 import static com.oracle.graal.python.nodes.ErrorMessages.INVALID_VALUE_NAN;
 import static com.oracle.graal.python.nodes.ErrorMessages.TOO_LARGE_TO_CONVERT_TO;
+import static com.oracle.graal.python.runtime.PosixSupportLibrary.FD_SETSIZE;
+import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
 
 import java.util.List;
 
@@ -177,7 +179,7 @@ private PList toList(boolean[] result, ObjAndFDList fds) {
             return factory().createList(PythonUtils.arrayCopyOf(resultObjs, resultObjsIdx));
         }
 
-        private static ObjAndFDList seq2set(VirtualFrame frame, Object sequence, PythonObjectLibrary sequenceLib, PythonObjectLibrary itemLib, LookupAndCallBinaryNode callGetItemNode,
+        private ObjAndFDList seq2set(VirtualFrame frame, Object sequence, PythonObjectLibrary sequenceLib, PythonObjectLibrary itemLib, LookupAndCallBinaryNode callGetItemNode,
                         FastConstructListNode constructListNode, PosixResources resources) {
             PArguments.ThreadState threadState = PArguments.getThreadState(frame);
             // We cannot assume any size of those two arrays, because the sequence may change as a
@@ -191,6 +193,9 @@ private static ObjAndFDList seq2set(VirtualFrame frame, Object sequence, PythonO
                 Object pythonObject = callGetItemNode.executeObject(frame, pSequence, i);
                 objects.add(pythonObject);
                 int fd = itemLib.asFileDescriptorWithState(pythonObject, threadState);
+                if (fd >= FD_SETSIZE) {
+                    throw raise(ValueError, ErrorMessages.FILE_DESCRIPTOR_OUT_OF_RANGE_IN_SELECT);
+                }
                 fds.add(fd);
                 containsSocket |= resources.isSocket(fd);
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/ErrorMessages.java

@@ -257,6 +257,7 @@ public abstract class ErrorMessages {
     public static final String FILE_OR_STREAM_IS_NOT_READABLE = "File or stream is not readable.";
     public static final String FILE_OR_STREAM_IS_NOT_SEEKABLE = "File or stream is not seekable.";
     public static final String FILE_OR_STREAM_IS_NOT_WRITABLE = "File or stream is not writable.";
+    public static final String FILE_DESCRIPTOR_OUT_OF_RANGE_IN_SELECT = "filedescriptor out of range in select()";
     public static final String FILL_CHAR_MUST_BE_LENGTH_1 = "The fill character must be exactly one character long";
     public static final String FILTER_SPEC_MUST_BE_DICT = "Filter specifier must be a dict or dict-like object";
     public static final String FILTER_SPECIFIER_MUST_HAVE = "Filter specifier must have an \"id\" entry";

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PosixSupportLibrary.java

@@ -114,6 +114,8 @@ public abstract class PosixSupportLibrary extends Library {
     public static final int PROT_EXEC = 0x4; /* Page can be executed. */
     public static final int PROT_NONE = 0x0; /* Page can not be accessed. */
 
+    public static final int FD_SETSIZE = 1024;
+
     public abstract String getBackend(Object recevier);
 
     public abstract String strerror(Object receiver, int errorCode);