supress warnings in socket builtins, don't allow sockets when native access is prohibited

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java

@@ -73,6 +73,7 @@
 import com.oracle.graal.python.builtins.modules.SREModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.SelectModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.SignalModuleBuiltins;
+import com.oracle.graal.python.builtins.modules.SocketModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.StringModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.SysModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.TimeModuleBuiltins;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SocketModuleBuiltins.java

@@ -50,6 +50,7 @@
 import com.oracle.graal.python.builtins.objects.type.PythonClass;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
+import com.oracle.graal.python.runtime.exception.PythonErrorType;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.NodeFactory;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -66,8 +67,12 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
     @GenerateNodeFactory
     public abstract static class SocketNode extends PythonBuiltinNode {
         @Specialization
-        Object socket(PythonClass cls, int family, int type, int proto, PNone fileno) {
-            return factory().createSocket(cls, family, type, proto);
+        Object socket(PythonClass cls, int family, int type, int proto, @SuppressWarnings("unused") PNone fileno) {
+            if (getContext().getEnv().isNativeAccessAllowed()) {
+                return factory().createSocket(cls, family, type, proto);
+            } else {
+                throw raise(PythonErrorType.OSError, "creating sockets not allowed");
+            }
         }
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/socket/PSocket.java

@@ -61,32 +61,15 @@ public class PSocket extends PythonBuiltinObject {
     private final int proto;
 
     private double timeout;
-    private boolean blocking;
 
-    private SelectableChannel channel;
+    @SuppressWarnings("unused") private SelectableChannel channel;
     private InetSocketAddress address = EPHEMERAL_ADDRESS;
 
-    private enum SocketType {
-        UNKNOWN_SOCKET,
-        CLIENT_SOCKET,
-        SERVER_SOCKET,
-        DATAGRAM_SOCKET
-    }
-
-    private SocketType socketType;
-
     public PSocket(LazyPythonClass cls, int family, int type, int proto) {
         super(cls);
         this.family = family;
         this.type = type;
         this.proto = proto;
-        switch (type) {
-            case SOCK_DGRAM:
-                socketType = SocketType.DATAGRAM_SOCKET;
-                break;
-            default:
-                socketType = SocketType.UNKNOWN_SOCKET;
-        }
     }
 
     public int getFamily() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/socket/SocketBuiltins.java

@@ -58,6 +58,7 @@
 import com.oracle.truffle.api.dsl.Specialization;
 
 @CoreFunctions(extendClasses = PythonBuiltinClassType.PSocket)
+@SuppressWarnings("unused")
 public class SocketBuiltins extends PythonBuiltins {
 
     @Override