don't use guards for all native member types

Author: lukasstadler

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/DynamicObjectNativeWrapper.java

@@ -1268,18 +1268,60 @@ public String toString() {
         }
 
         @ExportMessage
-        protected boolean isMemberReadable(String member,
-                        @CachedLibrary("this") PythonNativeWrapperLibrary lib,
-                        @Cached GetLazyClassNode getClassNode,
-                        @Cached GetNameNode getNameNode) {
-            return DynamicObjectNativeWrapper.GP_OBJECT.equals(member) || NativeMemberNames.isValid(member) ||
-                            ReadObjectNativeMemberNode.isPyDateTimeCAPIType(getNameNode.execute(getClassNode.execute(lib.getDelegate(this))));
+        @ImportStatic({PGuards.class, NativeMemberNames.class, DynamicObjectNativeWrapper.class})
+        abstract static class IsMemberReadable {
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = {"stringEquals(cachedName, name, stringProfile)", "isValid(cachedName)"})
+            static boolean isReadableNativeMembers(PythonObjectNativeWrapper receiver, String name,
+                            @Cached("createBinaryProfile()") ConditionProfile stringProfile,
+                            @Cached(value = "name", allowUncached = true) String cachedName) {
+                return true;
+            }
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = "stringEquals(GP_OBJECT, name, stringProfile)")
+            static boolean isReadableCachedGP(PythonObjectNativeWrapper receiver, String name,
+                            @Cached("createBinaryProfile()") ConditionProfile stringProfile) {
+                return true;
+            }
+
+            static boolean isPyTimeMemberReadable(PythonObjectNativeWrapper receiver, PythonNativeWrapperLibrary lib, GetLazyClassNode getClassNode, GetNameNode getNameNode) {
+                return ReadObjectNativeMemberNode.isPyDateTimeCAPIType(getNameNode.execute(getClassNode.execute(lib.getDelegate(receiver))));
+            }
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = "isPyTimeMemberReadable(receiver, lib, getClassNode, getNameNode)")
+            static boolean isReadablePyTime(PythonObjectNativeWrapper receiver, String name,
+                            @CachedLibrary("receiver") PythonNativeWrapperLibrary lib,
+                            @Cached GetLazyClassNode getClassNode,
+                            @Cached GetNameNode getNameNode) {
+                return true;
+            }
+
+            @Specialization
+            @TruffleBoundary
+            static boolean isReadableFallback(PythonObjectNativeWrapper receiver, String name,
+                            @CachedLibrary("receiver") PythonNativeWrapperLibrary lib,
+                            @Cached GetLazyClassNode getClassNode,
+                            @Cached GetNameNode getNameNode) {
+                return DynamicObjectNativeWrapper.GP_OBJECT.equals(name) || NativeMemberNames.isValid(name) ||
+                                ReadObjectNativeMemberNode.isPyDateTimeCAPIType(getNameNode.execute(getClassNode.execute(lib.getDelegate(receiver))));
+            }
         }
 
         @ExportMessage
-        @Override
-        public boolean isMemberModifiable(String member) {
-            return NativeMemberNames.isValid(member);
+        @ImportStatic({PGuards.class, NativeMemberNames.class, DynamicObjectNativeWrapper.class})
+        abstract static class IsMemberModifiable {
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = "stringEquals(cachedName, name, stringProfile)")
+            static boolean isModifiableCached(PythonObjectNativeWrapper receiver, String name,
+                            @Cached("createBinaryProfile()") ConditionProfile stringProfile,
+                            @Cached(value = "name", allowUncached = true) String cachedName,
+                            @Cached(value = "isValid(name)", allowUncached = true) boolean isValid) {
+                return isValid;
+            }
         }
     }
 
@@ -1398,10 +1440,31 @@ public static PrimitiveNativeWrapper createDouble(double val) {
             return new PrimitiveNativeWrapper(val);
         }
 
-        @Override
         @ExportMessage
-        protected boolean isMemberReadable(String member) {
-            return member.equals(DynamicObjectNativeWrapper.GP_OBJECT) || NativeMemberNames.isValid(member);
+        @ImportStatic({PGuards.class, NativeMemberNames.class, DynamicObjectNativeWrapper.class})
+        abstract static class IsMemberReadable {
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = {"stringEquals(cachedName, name, stringProfile)", "isValid(cachedName)"})
+            static boolean isReadableNativeMembers(PrimitiveNativeWrapper receiver, String name,
+                            @Cached("createBinaryProfile()") ConditionProfile stringProfile,
+                            @Cached(value = "name", allowUncached = true) String cachedName) {
+                return true;
+            }
+
+            @SuppressWarnings("unused")
+            @Specialization(guards = "stringEquals(GP_OBJECT, name, stringProfile)")
+            static boolean isReadableCachedGP(PrimitiveNativeWrapper receiver, String name,
+                            @Cached("createBinaryProfile()") ConditionProfile stringProfile) {
+                return true;
+            }
+
+            @Specialization
+            @TruffleBoundary
+            static boolean isReadableFallback(@SuppressWarnings("unused") PrimitiveNativeWrapper receiver, String name) {
+                return DynamicObjectNativeWrapper.GP_OBJECT.equals(name) || NativeMemberNames.isValid(name);
+            }
+
         }
 
         @ExportMessage

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/NativeMemberNames.java

@@ -41,10 +41,9 @@
 package com.oracle.graal.python.builtins.objects.cext;
 
 import java.lang.reflect.Field;
+import java.util.HashSet;
 
-import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
-import com.oracle.truffle.api.nodes.ExplodeLoop;
-import com.oracle.truffle.api.nodes.ExplodeLoop.LoopExplosionKind;
+import com.oracle.truffle.api.CompilerAsserts;
 
 public final class NativeMemberNames {
     public static final String OB_BASE = "ob_base";
@@ -140,28 +139,23 @@ public final class NativeMemberNames {
     public static final String SET_USED = "used";
     public static final String MMAP_DATA = "data";
 
-    @CompilationFinal(dimensions = 1) private static final String[] values;
+    private static final HashSet<String> values = new HashSet<>();
+
     static {
         Field[] declaredFields = NativeMemberNames.class.getDeclaredFields();
-        values = new String[declaredFields.length - 1]; // omit the values field
         for (int i = 0; i < declaredFields.length; i++) {
             Field s = declaredFields[i];
             if (s.getType() == String.class) {
                 try {
-                    values[i] = (String) s.get(NativeMemberNames.class);
+                    values.add((String) s.get(NativeMemberNames.class));
                 } catch (IllegalArgumentException | IllegalAccessException e) {
                 }
             }
         }
     }
 
-    @ExplodeLoop(kind = LoopExplosionKind.FULL_UNROLL)
     public static boolean isValid(String name) {
-        for (int i = 0; i < values.length; i++) {
-            if (name.equals(values[i])) {
-                return true;
-            }
-        }
-        return false;
+        CompilerAsserts.neverPartOfCompilation();
+        return values.contains(name);
     }
 }