Sonarqube: Reduce visibility of Object[] array and provide copying accessor

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/traceback/PTraceback.java

@@ -54,7 +54,11 @@ public final class PTraceback extends PythonBuiltinObject {
     public static final String TB_LASTI = "tb_lasti";
     public static final String TB_LINENO = "tb_lineno";
 
-    @CompilationFinal(dimensions = 1) public static final Object[] TB_DIR_FIELDS = new Object[]{TB_FRAME, TB_NEXT, TB_LASTI, TB_LINENO};
+    @CompilationFinal(dimensions = 1) private static final Object[] TB_DIR_FIELDS = new Object[]{TB_FRAME, TB_NEXT, TB_LASTI, TB_LINENO};
+
+    static Object[] getTbFieldNames() {
+        return TB_DIR_FIELDS.clone();
+    }
 
     private final PBaseException exception;
     private final int index;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/traceback/TracebackBuiltins.java

@@ -25,7 +25,6 @@
  */
 package com.oracle.graal.python.builtins.objects.traceback;
 
-import static com.oracle.graal.python.builtins.objects.traceback.PTraceback.TB_DIR_FIELDS;
 import static com.oracle.graal.python.builtins.objects.traceback.PTraceback.TB_FRAME;
 import static com.oracle.graal.python.builtins.objects.traceback.PTraceback.TB_LASTI;
 import static com.oracle.graal.python.builtins.objects.traceback.PTraceback.TB_LINENO;
@@ -57,7 +56,7 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
     public abstract static class DirNode extends PythonBuiltinNode {
         @Specialization
         public Object dir(@SuppressWarnings("unused") PTraceback self) {
-            return factory().createList(TB_DIR_FIELDS.clone());
+            return factory().createList(PTraceback.getTbFieldNames());
         }
     }