[GR-12628] Fix starting a Python process when all permissions are disabled

PullRequest: graalpython/286

Author: timfel

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/interop/JavaInteropTest.java

@@ -46,9 +46,9 @@
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
+import java.io.UnsupportedEncodingException;
 import java.util.Arrays;
 import java.util.List;
-import java.io.UnsupportedEncodingException;
 
 import org.graalvm.polyglot.Context;
 import org.graalvm.polyglot.Context.Builder;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java

@@ -41,6 +41,7 @@
 import java.util.Map.Entry;
 import java.util.ServiceLoader;
 import java.util.function.Supplier;
+import java.util.logging.Level;
 
 import org.graalvm.nativeimage.ImageInfo;
 
@@ -652,10 +653,14 @@ private Source getSource(String basename, String prefix) {
             Env env = ctxt.getEnv();
             TruffleFile file = env.getTruffleFile(prefix + suffix);
             try {
-                return getLanguage().newSource(ctxt, file, basename);
+                if (file.exists()) {
+                    return getLanguage().newSource(ctxt, file, basename);
+                }
             } catch (SecurityException | IOException t) {
-                throw new RuntimeException("Could not read core library from " + file);
+                // fall through;
             }
+            PythonLanguage.getLogger().log(Level.SEVERE, "Startup failed, could not read core library from " + file + ". Maybe you need to set python.CoreHome and python.StdLibHome.");
+            throw new RuntimeException();
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -356,7 +356,7 @@ Object setInheritable(int fd, @SuppressWarnings("unused") Object inheritable) {
     @GenerateNodeFactory
     @TypeSystemReference(PythonArithmeticTypes.class)
     public abstract static class StatNode extends PythonBinaryBuiltinNode {
-        private final ConditionProfile fileNotFound = ConditionProfile.createBinaryProfile();
+        private final BranchProfile fileNotFound = BranchProfile.create();
 
         private static final int S_IFIFO = 0010000;
         private static final int S_IFCHR = 0020000;
@@ -386,8 +386,12 @@ long fileTimeToSeconds(FileTime t) {
         Object stat(String path, boolean followSymlinks) {
             TruffleFile f = getContext().getEnv().getTruffleFile(path);
             LinkOption[] linkOptions = followSymlinks ? new LinkOption[0] : new LinkOption[]{LinkOption.NOFOLLOW_LINKS};
-            if (fileNotFound.profile(!f.exists(linkOptions))) {
-                throw raise(FileNotFoundError, "No such file or directory: '%s'", path);
+            try {
+                if (!f.exists(linkOptions)) {
+                    throw fileNoFound(path);
+                }
+            } catch (SecurityException e) {
+                throw fileNoFound(path);
             }
             int mode = 0;
             long size = 0;
@@ -475,6 +479,11 @@ Object stat(String path, boolean followSymlinks) {
             });
         }
 
+        private PException fileNoFound(String path) {
+            fileNotFound.enter();
+            throw raise(FileNotFoundError, "No such file or directory: '%s'", path);
+        }
+
         @TruffleBoundary(allowInlining = true, transferToInterpreterOnException = false)
         private static long strToLong(String name) throws NumberFormatException {
             return new Long(name).longValue();