Skip to content

Commit 5fc5982

Browse files
committed
Ignore collection errors when doing Truffle coverage
Some modules don't import when frozen modules are disabled
1 parent 5f4146d commit 5fc5982

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

mx.graalpython/mx_graalpython.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1235,15 +1235,15 @@ def is_alive(self):
12351235

12361236

12371237
def run_tagged_unittests(python_binary, env=None, cwd=None, nonZeroIsFatal=True, checkIfWithGraalPythonEE=False,
1238-
report=False, parallel=min(os.cpu_count(), 8), exclude=None):
1238+
report=False, parallel=min(os.cpu_count(), 8), exclude=None, runner_args=()):
12391239
sub_env = dict(env or os.environ)
12401240
sub_env['PYTHONPATH'] = os.path.join(_dev_pythonhome(), 'lib-python', '3')
12411241

12421242
if checkIfWithGraalPythonEE:
12431243
mx.run([python_binary, "-c", "import sys; print(sys.version)"])
12441244
run_python_unittests(
12451245
python_binary,
1246-
runner_args=['--tagged'],
1246+
runner_args=['--tagged', *runner_args],
12471247
paths=[os.path.relpath(SUITE.dir)],
12481248
env=sub_env,
12491249
cwd=cwd,
@@ -2456,7 +2456,7 @@ def python_coverage(args):
24562456
"test_multiprocessing_graalpy",
24572457
]
24582458
if kwds.pop("tagged", False):
2459-
run_tagged_unittests(executable, env=env, nonZeroIsFatal=False, parallel=1, exclude=tagged_exclude)
2459+
run_tagged_unittests(executable, env=env, nonZeroIsFatal=False, parallel=1, exclude=tagged_exclude, runner_args=['--continue-on-collection-errors'])
24602460
elif kwds.pop("hpy", False):
24612461
run_hpy_unittests(executable, env=env, nonZeroIsFatal=False, timeout=5*60*60) # hpy unittests are really slow under coverage
24622462
else:

0 commit comments

Comments
 (0)