drop useless argument from PositionalArgumentsNode.prependArgument

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/ManagedMethodWrappersMR.java

@@ -60,7 +60,6 @@
 import com.oracle.truffle.api.interop.Resolve;
 import com.oracle.truffle.api.nodes.ExplodeLoop;
 import com.oracle.truffle.api.nodes.Node;
-import com.oracle.truffle.api.profiles.PrimitiveValueProfile;
 
 @MessageResolution(receiverType = MethodWrapper.class)
 public class ManagedMethodWrappersMR {
@@ -76,8 +75,6 @@ abstract static class ExecuteNode extends Node {
         @Child private ExecuteKeywordStarargsNode expandKwargsNode = ExecuteKeywordStarargsNode.create();
         @Child private CallNode dispatch;
 
-        private final PrimitiveValueProfile starArgsLenProfile = PrimitiveValueProfile.createEqualityProfile();
-
         public Object access(MethKeywords object, Object[] arguments) {
             if (arguments.length != 3) {
                 throw ArityException.raise(3, arguments.length);
@@ -90,8 +87,7 @@ public Object access(MethKeywords object, Object[] arguments) {
             Object kwArgs = toJavaNode.execute(arguments[2]);
 
             Object[] starArgsArray = posStarargsNode.executeWith(starArgs);
-            int starArgsLen = starArgsLenProfile.profile(starArgsArray.length);
-            Object[] pArgs = PositionalArgumentsNode.prependArgument(receiver, starArgsArray, starArgsLen);
+            Object[] pArgs = PositionalArgumentsNode.prependArgument(receiver, starArgsArray);
             PKeyword[] kwArgsArray = expandKwargsNode.executeWith(kwArgs);
 
             // execute

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/TypeBuiltins.java

@@ -255,7 +255,7 @@ private Object op(VirtualFrame frame, PythonAbstractClass self, Object[] argumen
             Object newMethod = lookupNew.execute(self);
             if (newMethod != PNone.NO_VALUE) {
                 CompilerAsserts.partialEvaluationConstant(doCreateArgs);
-                Object[] newArgs = doCreateArgs ? PositionalArgumentsNode.prependArgument(self, arguments, arguments.length) : arguments;
+                Object[] newArgs = doCreateArgs ? PositionalArgumentsNode.prependArgument(self, arguments) : arguments;
                 Object newInstance = dispatchNew.execute(frame, newMethod, newArgs, keywords);
                 PythonAbstractClass newInstanceKlass = getClass.execute(newInstance);
                 if (isSameType(newInstanceKlass, self)) {
@@ -268,7 +268,7 @@ private Object op(VirtualFrame frame, PythonAbstractClass self, Object[] argumen
                         if (initMethod != PNone.NO_VALUE) {
                             Object[] initArgs;
                             if (doCreateArgs) {
-                                initArgs = PositionalArgumentsNode.prependArgument(newInstance, arguments, arguments.length);
+                                initArgs = PositionalArgumentsNode.prependArgument(newInstance, arguments);
                             } else {
                                 // XXX: (tfel) is this valid? I think it should be fine...
                                 arguments[0] = newInstance;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/positional/PositionalArgumentsNode.java

@@ -63,10 +63,10 @@ public Object[] execute(VirtualFrame frame) {
         return values;
     }
 
-    public static Object[] prependArgument(Object primary, Object[] arguments, int argumentsLength) {
-        Object[] result = new Object[argumentsLength + 1];
+    public static Object[] prependArgument(Object primary, Object[] arguments) {
+        Object[] result = new Object[arguments.length + 1];
         result[0] = primary;
-        System.arraycopy(arguments, 0, result, 1, argumentsLength);
+        System.arraycopy(arguments, 0, result, 1, arguments.length);
         return result;
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/CallNode.java

@@ -88,7 +88,7 @@ protected Object specialCall(VirtualFrame frame, Object callableObject, Object[]
             CompilerDirectives.transferToInterpreter();
             throw raise(PythonBuiltinClassType.TypeError, "'%p' object is not callable", callableObject);
         }
-        return callCallNode.execute(frame, call, PositionalArgumentsNode.prependArgument(callableObject, arguments, arguments.length), keywords);
+        return callCallNode.execute(frame, call, PositionalArgumentsNode.prependArgument(callableObject, arguments), keywords);
     }
 
     private CreateArgumentsNode ensureCreateArguments() {