Refactor according to PR review.

Refactorings include:
- Use `@TruffleBoundary` and `@Fallback` where appropiate.
- Make `*Builtins` classes final.
- Fix (typo-ish): Use `PyComplexCheckNode` instead of `PyUnicodeCheckNode` for checking for complex numbers in `PyNumberCheckNode`.
- Add `doBoolean` specialization to `PyNumberCheckNode`.

Author: phoeinx

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

@@ -55,6 +55,7 @@
 import com.oracle.graal.python.builtins.objects.function.BuiltinMethodDescriptor;
 import com.oracle.graal.python.builtins.objects.type.SpecialMethodSlot;
 import com.oracle.graal.python.runtime.PythonContext;
+import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
@@ -716,7 +717,7 @@ public final Shape getInstanceShape(PythonLanguage lang) {
 
         Empty.base = Exception;
 
-        HashSet<String> set = new HashSet<>();
+        HashSet<String> set = PythonUtils.ASSERTIONS_ENABLED ? new HashSet<>() : null;
         for (PythonBuiltinClassType type : VALUES) {
             // check uniqueness
             assert set.add("" + type.moduleName + "." + type.name) : type.name();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVDialect.java

@@ -44,6 +44,7 @@
 import static com.oracle.graal.python.builtins.modules.csv.CSVModuleBuiltins.NOT_SET_CODEPOINT;
 
 import com.oracle.graal.python.builtins.objects.object.PythonBuiltinObject;
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.object.Shape;
 
 public final class CSVDialect extends PythonBuiltinObject {
@@ -87,6 +88,7 @@ public CSVDialect(Object cls, Shape instanceShape, String delimiter, boolean dou
         this.lineTerminatorCodePoints = strToCodePointArray(this.lineTerminator);
     }
 
+    @TruffleBoundary
     private static int[] strToCodePointArray(String str) {
         final int strLen = str.length();
         final int codePointCount = str.codePointCount(0, strLen);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVDialectBuiltins.java

@@ -56,7 +56,7 @@
 import com.oracle.truffle.api.dsl.Specialization;
 
 @CoreFunctions(extendClasses = PythonBuiltinClassType.CSVDialect)
-public class CSVDialectBuiltins extends PythonBuiltins {
+public final class CSVDialectBuiltins extends PythonBuiltins {
 
     @Override
     protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVModuleBuiltins.java

@@ -91,7 +91,7 @@
 import com.oracle.truffle.api.library.CachedLibrary;
 
 @CoreFunctions(defineModule = "_csv")
-public class CSVModuleBuiltins extends PythonBuiltins {
+public final class CSVModuleBuiltins extends PythonBuiltins {
 
     static long fieldLimit = 128 * 1024; // max parsed field size
     static final String WRITE = "write";

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVReaderBuiltins.java

@@ -59,7 +59,7 @@
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__NEXT__;
 
 @CoreFunctions(extendClasses = PythonBuiltinClassType.CSVReader)
-public class CSVReaderBuiltins extends PythonBuiltins {
+public final class CSVReaderBuiltins extends PythonBuiltins {
 
     @Override
     protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVWriterBuiltins.java

@@ -67,7 +67,7 @@
 import com.oracle.truffle.api.frame.VirtualFrame;
 
 @CoreFunctions(extendClasses = PythonBuiltinClassType.CSVWriter)
-public class CSVWriterBuiltins extends PythonBuiltins {
+public final class CSVWriterBuiltins extends PythonBuiltins {
 
     @Override
     protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyNumberCheckNode.java

@@ -48,6 +48,7 @@
 import com.oracle.graal.python.nodes.attributes.LookupCallableSlotInMRONode;
 import com.oracle.graal.python.nodes.object.GetClassNode;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -89,6 +90,11 @@ static boolean doLong(Long object) {
         return true;
     }
 
+    @Specialization
+    static boolean doBoolean(Boolean object) {
+        return false;
+    }
+
     @Specialization
     static boolean doNone(PNone object) {
         return false;
@@ -100,19 +106,19 @@ static boolean doPythonObject(PythonAbstractObject object,
                     @Cached(parameters = "Index") LookupCallableSlotInMRONode lookupIndex,
                     @Cached(parameters = "Float") LookupCallableSlotInMRONode lookupFloat,
                     @Cached(parameters = "Int") LookupCallableSlotInMRONode lookupInt,
-                    @Cached PyUnicodeCheckNode checkComplex) {
+                    @Cached PyComplexCheckNode checkComplex) {
         Object type = getClassNode.execute(object);
         return lookupIndex.execute(type) != PNone.NO_VALUE || lookupInt.execute(type) != PNone.NO_VALUE || lookupFloat.execute(type) != PNone.NO_VALUE || checkComplex.execute(object);
     }
 
-    @Specialization(replaces = "doPythonObject", guards = {"!isDouble(object)", "!isInteger(object)", "!isBoolean(object)", "!isNone(object)", "!isString(object)"})
-    static boolean doObject(VirtualFrame frame, Object object,
+    @Fallback
+    static boolean doObject(Object object,
                     @CachedLibrary(limit = "3") InteropLibrary interopLibrary,
                     @Cached GetClassNode getClassNode,
                     @Cached(parameters = "Index") LookupCallableSlotInMRONode lookupIndex,
                     @Cached(parameters = "Float") LookupCallableSlotInMRONode lookupFloat,
                     @Cached(parameters = "Int") LookupCallableSlotInMRONode lookupInt,
-                    @Cached PyUnicodeCheckNode checkComplex) {
+                    @Cached PyComplexCheckNode checkComplex) {
         Object type = getClassNode.execute(object);
         if (type == PythonBuiltinClassType.ForeignObject) {
             return interopLibrary.isNumber(object);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyUnicodeCheckNode.java

@@ -45,6 +45,7 @@
 import com.oracle.graal.python.nodes.classes.IsSubtypeNode;
 import com.oracle.graal.python.nodes.object.GetClassNode;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.nodes.Node;
@@ -67,7 +68,7 @@ static boolean doPString(@SuppressWarnings("unused") PString object) {
         return true;
     }
 
-    @Specialization
+    @Fallback
     static boolean doGeneric(Object object,
                     @Cached GetClassNode getClass,
                     @Cached IsSubtypeNode isSubtype) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/PythonUtils.java

@@ -586,7 +586,7 @@ public static boolean bufferHasRemaining(ByteBuffer buffer) {
         return buffer.hasRemaining();
     }
 
-    @TruffleBoundary(allowInlining = true)
+    @TruffleBoundary
     public static boolean equals(Object a, Object b) {
         return a.equals(b);
     }