reusable PythonBenchmarkSuite

- add __teardown__ callback to bench harness

Author: cosminbasca

graalpython/benchmarks/src/harness.py

@@ -46,6 +46,7 @@
 _HRULE = '-'.join(['' for i in range(80)])
 ATTR_BENCHMARK = '__benchmark__'
 ATTR_PROCESS_ARGS = '__process_args__'
+ATTR_TEARDOWN = '__teardown__'
 
 
 def ccompile(name, code):
@@ -162,6 +163,10 @@ def run(self):
                 else:
                     print("### iteration=%s, name=%s, duration=%s" % (iteration, self.bench_module.__name__, duration))
 
+        print("teardown ... ")
+        self._call_attr(ATTR_TEARDOWN)
+        print("benchmark complete")
+
 
 def run_benchmark(prog, args):
     warmup = 0

graalpython/benchmarks/src/micro/arith-binop.py

@@ -43,3 +43,8 @@ def measure(num):
 
 def __benchmark__(num=5):
     measure(num)
+
+
+def __teardown__():
+    # teardown example
+    print("arith-binop teardown")

mx.graalpython/mx_graalpython.py

@@ -36,7 +36,7 @@
 import mx_subst
 import mx_urlrewrites
 from mx_gate import Task
-from mx_graalpython_bench_param import PATH_MESO
+from mx_graalpython_bench_param import PATH_MESO, BENCHMARKS
 from mx_graalpython_benchmark import PythonBenchmarkSuite
 from mx_unittest import unittest
 
@@ -868,7 +868,7 @@ def import_python_sources(args):
 # add the defined python benchmark suites
 #
 # ----------------------------------------------------------------------------------------------------------------------
-for py_bench_suite in PythonBenchmarkSuite.get_benchmark_suites():
+for py_bench_suite in PythonBenchmarkSuite.get_benchmark_suites(BENCHMARKS):
     mx_benchmark.add_bm_suite(py_bench_suite)
 
 

mx.graalpython/mx_graalpython_benchmark.py

@@ -183,14 +183,14 @@ def config_name(self):
 #
 # ----------------------------------------------------------------------------------------------------------------------
 class PythonBenchmarkSuite(VmBenchmarkSuite, AveragingBenchmarkMixin):
-    def __init__(self, name, harness_path):
+    def __init__(self, name, bench_path, benchmarks, harness_path):
         self._name = name
         self._harness_path = harness_path
         self._harness_path = join(_graalpython_suite.dir, self._harness_path)
         if not self._harness_path:
             mx.abort("python harness path not specified!")
 
-        self._bench_path, self._benchmarks = BENCHMARKS[self._name]
+        self._bench_path, self._benchmarks = bench_path, benchmarks
         self._bench_path = join(_graalpython_suite.dir, self._bench_path)
 
     def rules(self, output, benchmarks, bm_suite_args):
@@ -292,8 +292,10 @@ def get_vm_registry(self):
         return python_vm_registry
 
     @classmethod
-    def get_benchmark_suites(cls):
-        return [cls(suite_name, HARNESS_PATH) for suite_name in BENCHMARKS]
+    def get_benchmark_suites(cls, benchmarks):
+        assert isinstance(benchmarks, dict), "benchmarks must be a dict: {suite: [path, benchmarks], ...}"
+        return [cls(suite_name, suite_info[0], suite_info[1], HARNESS_PATH)
+                for suite_name, suite_info in benchmarks.items()]
 
 
 # ----------------------------------------------------------------------------------------------------------------------