test_thread.py: skip test_unraisable_exception until sys.unraisablehook is intrinsified

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ThreadModuleBuiltins.java

@@ -42,6 +42,7 @@
 
 import static com.oracle.graal.python.builtins.objects.thread.AbstractPythonLock.TIMEOUT_MAX;
 
+import java.io.PrintWriter;
 import java.lang.ref.WeakReference;
 import java.util.List;
 
@@ -51,13 +52,13 @@
 import com.oracle.graal.python.builtins.PythonBuiltinClassType;
 import com.oracle.graal.python.builtins.PythonBuiltins;
 import com.oracle.graal.python.builtins.objects.PNone;
+import com.oracle.graal.python.builtins.objects.exception.PBaseException;
 import com.oracle.graal.python.builtins.objects.function.PKeyword;
 import com.oracle.graal.python.builtins.objects.thread.PLock;
 import com.oracle.graal.python.builtins.objects.thread.PRLock;
 import com.oracle.graal.python.builtins.objects.thread.PThread;
 import com.oracle.graal.python.builtins.objects.thread.PThreadLocal;
 import com.oracle.graal.python.nodes.ErrorMessages;
-import com.oracle.graal.python.nodes.WriteUnraisableNode;
 import com.oracle.graal.python.nodes.argument.keywords.ExpandKeywordStarargsNode;
 import com.oracle.graal.python.nodes.argument.positional.ExecutePositionalStarargsNode;
 import com.oracle.graal.python.nodes.call.CallNode;
@@ -204,14 +205,24 @@ long start(VirtualFrame frame, Object cls, Object callable, Object args, Object
                 } catch (PythonThreadKillException e) {
                     return;
                 } catch (PException e) {
-                    WriteUnraisableNode.getUncached().execute(e.getUnreifiedException(), "in thread started by", callable);
+                    dumpError(context, e.getUnreifiedException(), callable);
+                    // TODO (cbasca): when GR-30386 is completed use the intrinsified
+                    // sys.unraisablehook
+                    // WriteUnraisableNode.getUncached().execute(e.getUnreifiedException(), "in
+                    // thread started by", callable);
                 }
             }, env.getContext(), context.getThreadGroup());
 
             PThread pThread = factory().createPythonThread(cls, thread);
             pThread.start();
             return pThread.getId();
         }
+
+        @TruffleBoundary
+        static void dumpError(PythonContext context, PBaseException exception, Object object) {
+            PrintWriter err = new PrintWriter(context.getStandardErr());
+            err.println(String.format("%s in thread started by %s", exception.toString(), object));
+        }
     }
 
     @Builtin(name = "_set_sentinel", minNumOfPositionalArgs = 0)

graalpython/lib-python/3/test/test_thread.py

@@ -1,12 +1,14 @@
+import time
+
+import _thread as thread
+
 import os
-import unittest
 import random
-from test import support
-import _thread as thread
-import time
+import unittest
 import weakref
-
 from test import lock_tests
+from test import support
+from test.support import impl_detail
 
 NUMTASKS = 10
 NUMTRIPS = 3
@@ -133,6 +135,7 @@ def task():
             time.sleep(POLL_SLEEP)
             self.assertEqual(thread._count(), orig)
 
+    @impl_detail("[GR-30386] skip until implemented", graalvm=False)
     def test_unraisable_exception(self):
         def task():
             started.release()