Address review feedback

Author: msimacek

graalpython/com.oracle.graal.python.cext/src/capi.c

@@ -898,7 +898,7 @@ void PyTruffle_PrimitiveArrayFree(void* array) {
     free(array);
 }
 
-void PyTruffle_ObjectArrayFree(PyObject** array, int size) {
+void PyTruffle_ObjectArrayFree(PyObject** array, int32_t size) {
     for (int i = 0; i < size; i++) {
         Py_DECREF(array[i]);
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextAbstractBuiltins.java

@@ -909,28 +909,28 @@ Object get(Object obj,
     @CApiBuiltin(ret = Int, args = {PyObject, ConstCharPtrAsTruffleString}, call = Direct)
     abstract static class PyObject_SetDoc extends CApiBinaryBuiltinNode {
         @Specialization
-        int set(PBuiltinFunction obj, TruffleString value,
-                        @Cached WriteAttributeToDynamicObjectNode write) {
+        static int set(PBuiltinFunction obj, TruffleString value,
+                        @Shared("write") @Cached WriteAttributeToDynamicObjectNode write) {
             write.execute(obj, T___DOC__, value);
             return 1;
         }
 
         @Specialization
-        int set(PBuiltinMethod obj, TruffleString value,
-                        @Cached WriteAttributeToDynamicObjectNode write) {
+        static int set(PBuiltinMethod obj, TruffleString value,
+                        @Shared("write") @Cached WriteAttributeToDynamicObjectNode write) {
             set(obj.getFunction(), value, write);
             return 1;
         }
 
         @Specialization
-        int set(GetSetDescriptor obj, TruffleString value,
-                        @Cached WriteAttributeToDynamicObjectNode write) {
+        static int set(GetSetDescriptor obj, TruffleString value,
+                        @Shared("write") @Cached WriteAttributeToDynamicObjectNode write) {
             write.execute(obj, T___DOC__, value);
             return 1;
         }
 
         @Specialization(guards = "isType.execute(type)", limit = "1")
-        int set(PythonNativeClass type, TruffleString value,
+        static int set(PythonNativeClass type, TruffleString value,
                         @SuppressWarnings("unused") @Cached IsTypeNode isType,
                         // TODO we should write to tp_doc, this writes to __doc__ in the type dict
                         @Cached("createForceType()") WriteAttributeToObjectNode write) {
@@ -940,7 +940,8 @@ int set(PythonNativeClass type, TruffleString value,
 
         @Fallback
         @SuppressWarnings("unused")
-        int set(Object obj, Object value) {
+        static int set(Object obj, Object value) {
+            CompilerDirectives.transferToInterpreterAndInvalidate();
             throw CompilerDirectives.shouldNotReachHere("Don't know how to set doc for " + obj.getClass());
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiContext.java

@@ -53,7 +53,6 @@
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.IdentityHashMap;
 import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.ConcurrentHashMap;
@@ -103,6 +102,7 @@
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.graal.python.util.Function;
 import com.oracle.graal.python.util.PythonUtils;
+import com.oracle.graal.python.util.WeakIdentityHashMap;
 import com.oracle.truffle.api.CallTarget;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
@@ -197,7 +197,7 @@ public final class CApiContext extends CExtContext {
     private boolean loadNativeLibrary = true;
     public RootCallTarget signatureContainer;
 
-    private final IdentityHashMap<Object, Object> procWrappers = new IdentityHashMap<>();
+    private final WeakIdentityHashMap<Object, Object> procWrappers = new WeakIdentityHashMap<>();
 
     public static TruffleLogger getLogger(Class<?> clazz) {
         return PythonLanguage.getLogger(LOGGER_CAPI_NAME + "." + clazz.getSimpleName());