add basic support for Function.__defaults__

- missing initialization

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -29,6 +29,7 @@
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__ANNOTATIONS__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__CLOSURE__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__CODE__;
+import static com.oracle.graal.python.nodes.SpecialAttributeNames.__DEFAULTS__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__DICT__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__GLOBALS__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__MODULE__;
@@ -52,12 +53,14 @@
 import com.oracle.graal.python.builtins.objects.method.PMethod;
 import com.oracle.graal.python.builtins.objects.module.PythonModule;
 import com.oracle.graal.python.builtins.objects.object.PythonObject;
+import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.nodes.argument.CreateArgumentsNode;
 import com.oracle.graal.python.nodes.attributes.ReadAttributeFromObjectNode;
 import com.oracle.graal.python.nodes.attributes.WriteAttributeToObjectNode;
 import com.oracle.graal.python.nodes.call.CallDispatchNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
+import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonTernaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.subscript.GetItemNode;
@@ -232,7 +235,7 @@ Object getModule(PBuiltinFunction self, Object value) {
 
     @Builtin(name = __CODE__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
     @GenerateNodeFactory
-    public abstract static class GetCodeNode extends PythonBuiltinNode {
+    public abstract static class GetCodeNode extends PythonBinaryBuiltinNode {
         @Specialization(guards = {"!isBuiltinFunction(self)", "isNoValue(none)"})
         Object getCode(PFunction self, @SuppressWarnings("unused") PNone none,
                         @Cached("createBinaryProfile()") ConditionProfile hasCodeProfile) {
@@ -257,6 +260,51 @@ Object builtinCode(PBuiltinFunction self, Object none) {
         }
     }
 
+    @Builtin(name = __DEFAULTS__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
+    @GenerateNodeFactory
+    public abstract static class GetDefaultsNode extends PythonBinaryBuiltinNode {
+        private Object[] getDefaultsAndInitIfNotSet(PFunction function) {
+            // TODO: add support for __DEFAULTS__ (init from actual default values ...)
+            return function.getDefaults();
+        }
+
+        private Object getDefaults(PFunction function) {
+            Object[] defaultVals = getDefaultsAndInitIfNotSet(function);
+            if (defaultVals == null) {
+                return PNone.NONE;
+            }
+            return factory().createTuple(defaultVals);
+        }
+
+        @Specialization
+        Object defaults(PFunction self, @SuppressWarnings("unused") PNone defaults) {
+            return getDefaults(self);
+        }
+
+        @Specialization
+        Object defaults(PFunction self, PTuple defaults) {
+            self.setDefaults(defaults.getArray());
+            return PNone.NONE;
+        }
+
+        @Specialization
+        Object defaults(PMethod self, @SuppressWarnings("unused") PNone defaults) {
+            return getDefaults(self.getFunction());
+        }
+
+        @Specialization
+        Object defaults(PMethod self, PTuple defaults) {
+            self.getFunction().setDefaults(defaults.getArray());
+            return PNone.NONE;
+        }
+
+        @SuppressWarnings("unused")
+        @Specialization
+        Object defaults(PBuiltinFunction self, Object defaults) {
+            throw raise(AttributeError, "'builtin_function_or_method' object has no attribute '__defaults__'");
+        }
+    }
+
     @Builtin(name = __DICT__, fixedNumOfPositionalArgs = 1, isGetter = true)
     @GenerateNodeFactory
     static abstract class DictNode extends PythonUnaryBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/PFunction.java

@@ -51,6 +51,7 @@ public class PFunction extends PythonObject implements PythonCallable {
     private final PCell[] closure;
     private final boolean isStatic;
     private PCode code;
+    private Object[] defaults;
 
     public PFunction(PythonClass clazz, String name, String enclosingClassName, Arity arity, RootCallTarget callTarget, FrameDescriptor frameDescriptor, PythonObject globals, PCell[] closure) {
         super(clazz);
@@ -66,9 +67,9 @@ public PFunction(PythonClass clazz, String name, String enclosingClassName, Arit
     }
 
     @TruffleBoundary
-    private static void addDefaultConstants(DynamicObject storage2, String name, String enclosingClassName) {
-        storage2.define(__NAME__, name);
-        storage2.define(__QUALNAME__, enclosingClassName == null ? enclosingClassName + "." + name : name);
+    private static void addDefaultConstants(DynamicObject storage, String name, String enclosingClassName) {
+        storage.define(__NAME__, name);
+        storage.define(__QUALNAME__, enclosingClassName == null ? enclosingClassName + "." + name : name);
     }
 
     public boolean isStatic() {
@@ -130,4 +131,12 @@ public void setCode(PCode code) {
     public String getEnclosingClassName() {
         return enclosingClassName;
     }
+
+    public Object[] getDefaults() {
+        return defaults;
+    }
+
+    public void setDefaults(Object[] defaults) {
+        this.defaults = defaults;
+    }
 }