Skip to content

Commit a1da039

Browse files
committed
Fix PGO profile generation for Bytecode DSL
1 parent 121f51f commit a1da039

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

mx.graalpython/mx_graalpython.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -277,16 +277,15 @@ def libpythonvm_build_args():
277277
vc = SUITE.vc
278278
commit = str(vc.tip(SUITE.dir)).strip()
279279
branch = str(vc.active_branch(SUITE.dir, abortOnError=False) or 'master').strip()
280-
dsl_suffix = '' if not BYTECODE_DSL_INTERPRETER else '-bytecode-dsl'
281280

282281
if script := os.environ.get("ARTIFACT_DOWNLOAD_SCRIPT"):
283282
# This is always available in the GraalPy CI
284-
profile = f"cached_profile{dsl_suffix}.iprof.gz"
283+
profile = f"cached_profile.iprof.gz"
285284
run(
286285
[
287286
sys.executable,
288287
script,
289-
f"graalpy/pgo{dsl_suffix}-{commit}",
288+
f"graalpy/pgo-{commit}",
290289
profile,
291290
],
292291
nonZeroIsFatal=False,
@@ -299,8 +298,6 @@ def libpythonvm_build_args():
299298
if not profile:
300299
try:
301300
profile = get_profile(["--branch", b])
302-
if profile and dsl_suffix not in profile:
303-
mx.warn("PGO profile seems mismatched, you need newer graal-enterprise")
304301
except BaseException:
305302
pass
306303

@@ -359,13 +356,9 @@ def graalpy_native_pgo_build_and_test(args=None):
359356
GRAALPY_HOME=instrumented_home,
360357
):
361358
graalpytest(["--python", instrumented_launcher, "test_venv.py"])
362-
python_vm_config = 'custom'
363-
if BYTECODE_DSL_INTERPRETER:
364-
python_vm_config += '-bc-dsl'
365-
mx.command_function('benchmark')(["meso-small:*", "--", "--python-vm", "graalpython", "--python-vm-config", python_vm_config])
366-
dsl_suffix = '' if not BYTECODE_DSL_INTERPRETER else '-bytecode-dsl'
367-
iprof_path = Path(SUITE.dir) / f'default{dsl_suffix}.iprof'
368-
lcov_path = Path(SUITE.dir) / f'default{dsl_suffix}.lcov'
359+
mx.command_function('benchmark')(["meso-small:*", "--", "--python-vm", "graalpython", "--python-vm-config", 'custom'])
360+
iprof_path = Path(SUITE.dir) / f'default.iprof'
361+
lcov_path = Path(SUITE.dir) / f'default.lcov'
369362

370363
run([
371364
os.path.join(
@@ -418,7 +411,7 @@ def graalpy_native_pgo_build_and_test(args=None):
418411
sys.executable,
419412
script,
420413
iprof_gz_path,
421-
f"pgo{dsl_suffix}-{commit}",
414+
f"pgo-{commit}",
422415
"graalpy",
423416
"--lifecycle",
424417
"cache",

0 commit comments

Comments
 (0)