[GR-44432] Resolve Truffle DSL warnings, optimize AST footprint, tune hosted inlining heuristics.

PullRequest: graalpython/2672

Author: steve-s

ci.jsonnet

@@ -1 +1 @@
-{ "overlay": "0475af00203f3b004249bc9d0e0c1ac9700be1a9" }
+{ "overlay": "49d2e0a6fb13325d4d9e9e5687cec4afe54991ff" }

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/nodes/util/CastToJavaUnsignedLongNodeTests.java

@@ -56,8 +56,6 @@
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
 import com.oracle.graal.python.test.PythonTests;
-import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.nodes.RootNode;
 
 public class CastToJavaUnsignedLongNodeTests {
     private static PythonObjectFactory factory = PythonObjectFactory.getUncached();
@@ -145,35 +143,14 @@ private static void expect(PythonBuiltinClassType errorType, Runnable test) {
     }
 
     private static long castInt(int arg) {
-        return (Long) new RootNode(null) {
-            @Child private CastToJavaUnsignedLongNode castNode = CastToJavaUnsignedLongNode.create();
-
-            @Override
-            public Object execute(VirtualFrame frame) {
-                return castNode.execute(arg);
-            }
-        }.getCallTarget().call();
+        return CastToJavaUnsignedLongNode.executeUncached(arg);
     }
 
     private static long castLong(long arg) {
-        return (Long) new RootNode(null) {
-            @Child private CastToJavaUnsignedLongNode castNode = CastToJavaUnsignedLongNode.create();
-
-            @Override
-            public Object execute(VirtualFrame frame) {
-                return castNode.execute(arg);
-            }
-        }.getCallTarget().call();
+        return CastToJavaUnsignedLongNode.executeUncached(arg);
     }
 
     private static long castObject(Object arg) {
-        return (Long) new RootNode(null) {
-            @Child private CastToJavaUnsignedLongNode castNode = CastToJavaUnsignedLongNode.create();
-
-            @Override
-            public Object execute(VirtualFrame frame) {
-                return castNode.execute(arg);
-            }
-        }.getCallTarget().call();
+        return CastToJavaUnsignedLongNode.executeUncached(arg);
     }
 }

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/nodes/util/NarrowBigIntegerNodeTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -63,8 +63,6 @@ public void tearDown() {
         PythonTests.closeContext();
     }
 
-    private static NarrowBigIntegerNode narrow = NarrowBigIntegerNodeGen.getUncached();
-
     @Test
     public void smallInts() {
         expectInt(-2);
@@ -108,19 +106,19 @@ public void longPIntBoundary() {
     }
 
     private static void expectInt(int expected) {
-        Object actual = narrow.execute(BigInteger.valueOf(expected));
+        Object actual = NarrowBigIntegerNode.executeUncached(BigInteger.valueOf(expected));
         Assert.assertTrue(actual instanceof Integer);
         Assert.assertEquals(expected, (int) actual);
     }
 
     private static void expectLong(long expected) {
-        Object actual = narrow.execute(BigInteger.valueOf(expected));
+        Object actual = NarrowBigIntegerNode.executeUncached(BigInteger.valueOf(expected));
         Assert.assertTrue(actual instanceof Long);
         Assert.assertEquals(expected, (long) actual);
     }
 
     private static void expectPInt(BigInteger expected) {
-        Object actual = narrow.execute(expected);
+        Object actual = NarrowBigIntegerNode.executeUncached(expected);
         Assert.assertTrue(actual instanceof PInt);
         Assert.assertEquals(expected, ((PInt) actual).getValue());
     }

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/nodes/util/PyObjectLookupAttrTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -41,20 +41,20 @@
 
 package com.oracle.graal.python.nodes.util;
 
-import com.oracle.graal.python.builtins.PythonBuiltinClassType;
-import com.oracle.graal.python.builtins.objects.PNone;
-import com.oracle.graal.python.lib.PyObjectLookupAttr;
-import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.nodes.Node;
-import com.oracle.truffle.api.nodes.RootNode;
+import static com.oracle.graal.python.util.PythonUtils.tsLiteral;
+
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
+import com.oracle.graal.python.builtins.PythonBuiltinClassType;
+import com.oracle.graal.python.builtins.objects.PNone;
+import com.oracle.graal.python.lib.PyObjectLookupAttr;
 import com.oracle.graal.python.test.PythonTests;
-
-import static com.oracle.graal.python.util.PythonUtils.tsLiteral;
+import com.oracle.truffle.api.frame.VirtualFrame;
+import com.oracle.truffle.api.nodes.Node;
+import com.oracle.truffle.api.nodes.RootNode;
 
 public class PyObjectLookupAttrTests {
 
@@ -78,7 +78,7 @@ public void lookupThroughMRO() {
 
             @Override
             public Object execute(VirtualFrame frame) {
-                return lookupNode.execute(frame, PythonBuiltinClassType.Boolean, tsLiteral("real"));
+                return lookupNode.executeCached(frame, PythonBuiltinClassType.Boolean, tsLiteral("real"));
             }
         }.getCallTarget().call();
         Assert.assertNotSame(PNone.NO_VALUE, v);