Add not-connected checks for sockets

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/socket/SocketBuiltins.java

@@ -124,6 +124,9 @@ abstract static class AcceptNode extends PythonUnaryBuiltinNode {
         @Specialization
         @TruffleBoundary
         Object accept(PSocket socket) {
+            if (socket.getServerSocket() == null) {
+                throw raiseOSError(null, OSErrorEnum.EINVAL);
+            }
             try {
                 SocketChannel acceptSocket = SocketUtils.accept(this, socket);
                 if (acceptSocket == null) {
@@ -338,6 +341,9 @@ Object listen(PSocket socket, PNone backlog) {
     abstract static class RecvNode extends PythonTernaryClinicBuiltinNode {
         @Specialization
         Object recv(VirtualFrame frame, PSocket socket, int bufsize, int flags) {
+            if (socket.getSocket() == null) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            }
             ByteBuffer readBytes = PythonUtils.allocateByteBuffer(bufsize);
             try {
                 int length = SocketUtils.recv(this, socket, readBytes);
@@ -384,6 +390,9 @@ Object recvInto(VirtualFrame frame, PSocket socket, PMemoryView buffer, Object f
                         @CachedLibrary(limit = "getCallSiteInlineCacheMaxDepth()") PythonObjectLibrary lib,
                         @Cached("create(__LEN__)") LookupAndCallUnaryNode callLen,
                         @Cached("create(__SETITEM__)") LookupAndCallTernaryNode setItem) {
+            if (socket.getSocket() == null) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            }
             int bufferLen = lib.asSizeWithState(callLen.executeObject(frame, buffer), PArguments.getThreadState(frame));
             byte[] targetBuffer = new byte[bufferLen];
             ByteBuffer byteBuffer = PythonUtils.wrapByteBuffer(targetBuffer);
@@ -410,6 +419,9 @@ Object recvInto(VirtualFrame frame, PSocket socket, PByteArray buffer, Object fl
                         @Cached("createBinaryProfile()") ConditionProfile byteStorage,
                         @Cached SequenceStorageNodes.LenNode lenNode,
                         @Cached("createSetItem()") SequenceStorageNodes.SetItemNode setItem) {
+            if (socket.getSocket() == null) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            }
             SequenceStorage storage = buffer.getSequenceStorage();
             int bufferLen = lenNode.execute(storage);
             if (byteStorage.profile(storage instanceof ByteSequenceStorage)) {
@@ -470,17 +482,14 @@ Object send(VirtualFrame frame, PSocket socket, PBytes bytes, Object flags,
                         @Cached SequenceStorageNodes.ToByteArrayNode toBytes) {
             // TODO: do not ignore flags
             if (socket.getSocket() == null) {
-                throw raise(OSError);
-            }
-
-            if (!socket.isOpen()) {
-                throw raise(OSError);
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
             }
-
             int written;
             ByteBuffer buffer = PythonUtils.wrapByteBuffer(toBytes.execute(bytes.getSequenceStorage()));
             try {
                 written = SocketUtils.send(this, socket, buffer);
+            } catch (NotYetConnectedException e) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
             } catch (IOException e) {
                 throw raise(OSError);
             }
@@ -500,6 +509,9 @@ Object sendAll(VirtualFrame frame, PSocket socket, PBytesLike bytes, Object flag
                         @Cached SequenceStorageNodes.ToByteArrayNode toBytes,
                         @Cached ConditionProfile hasTimeoutProfile) {
             // TODO: do not ignore flags
+            if (socket.getSocket() == null) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            }
             ByteBuffer buffer = PythonUtils.wrapByteBuffer(toBytes.execute(bytes.getSequenceStorage()));
             long timeoutMillis = socket.getTimeoutInMilliseconds();
             TimeoutHelper timeoutHelper = null;
@@ -513,6 +525,8 @@ Object sendAll(VirtualFrame frame, PSocket socket, PBytesLike bytes, Object flag
                 int written;
                 try {
                     written = SocketUtils.send(this, socket, buffer, timeoutMillis);
+                } catch (NotYetConnectedException e) {
+                    throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
                 } catch (IOException e) {
                     throw raise(OSError);
                 }
@@ -606,24 +620,29 @@ Object setTimeout(PSocket socket, Object secondsObj,
     @GenerateNodeFactory
     abstract static class shutdownNode extends PythonBinaryBuiltinNode {
         @Specialization
-        @TruffleBoundary
-        Object family(PSocket socket, int how) {
-            if (socket.getSocket() != null) {
-                try {
-                    if (how == 0 || how == 2) {
-                        socket.getSocket().shutdownInput();
-                    }
-                    if (how == 1 || how == 2) {
-                        socket.getSocket().shutdownOutput();
-                    }
-                } catch (IOException e) {
-                    throw raise(OSError);
-                }
-            } else {
+        Object family(VirtualFrame frame, PSocket socket, int how) {
+            if (socket.getSocket() == null) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            }
+            try {
+                shutdown(socket, how);
+            } catch (NotYetConnectedException e) {
+                throw raiseOSError(frame, OSErrorEnum.ENOTCONN);
+            } catch (IOException e) {
                 throw raise(OSError);
             }
             return PNone.NO_VALUE;
         }
+
+        @TruffleBoundary
+        private static void shutdown(PSocket socket, int how) throws IOException {
+            if (how == 0 || how == 2) {
+                socket.getSocket().shutdownInput();
+            }
+            if (how == 1 || how == 2) {
+                socket.getSocket().shutdownOutput();
+            }
+        }
     }
 
     // family