remove incorrect int.from_bytes with Strings

Author: timfel

graalpython/com.oracle.graal.python.test/src/tests/test_int.py

@@ -487,11 +487,10 @@ def test_wrong_input(self):
         self.assertRaises(TypeError, int.from_bytes, 0, 'big')
         self.assertRaises(TypeError, int.from_bytes, 0, 'big', True)
 
-        #TODO uncoment these tests, when GR-12453 is fixed
-        #self.assertRaises(TypeError, int.from_bytes, "", 'big')
-        #self.assertRaises(TypeError, int.from_bytes, "\x00", 'big')
-        #self.assertRaises(TypeError, MyInt.from_bytes, "", 'big')
-        #self.assertRaises(TypeError, MyInt.from_bytes, "\x00", 'big')
+        self.assertRaises(TypeError, int.from_bytes, "", 'big')
+        self.assertRaises(TypeError, int.from_bytes, "\x00", 'big')
+        self.assertRaises(TypeError, MyInt.from_bytes, "", 'big')
+        self.assertRaises(TypeError, MyInt.from_bytes, "\x00", 'big')
         self.assertRaises(TypeError, MyInt.from_bytes, 0, 'big')
         self.assertRaises(TypeError, int.from_bytes, 0, 'big', True)
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntBuiltins.java

@@ -1981,20 +1981,6 @@ private Object compute(PythonClass cl, byte[] bytes, String byteorder, boolean s
             return createIntObject(cl, bi);
         }
 
-        // from String / PString
-        // TODO these specialization shouldn't be there. The CPython ends up with TypeError in such
-        // case. See GR-12453
-        @Specialization
-        @TruffleBoundary
-        public Object fromString(PythonClass cl, String str, String byteorder, Object[] args, boolean signed) {
-            return compute(cl, str.getBytes(), byteorder, signed);
-        }
-
-        @Specialization
-        public Object fromString(PythonClass cl, String str, String byteorder, Object[] args, PNone keywordArg) {
-            return fromString(cl, str, byteorder, args, false);
-        }
-
         // from PBytes
         @Specialization
         public Object fromPBytes(PythonClass cl, PBytes bytes, String byteorder, Object[] args, boolean signed) {

graalpython/lib-graalpython/_imp.py

@@ -48,7 +48,7 @@ def extension_suffixes():
 
 @__builtin__
 def get_magic():
-    return '\x0c\xaf\xaf\xe1'
+    return b'\x0c\xaf\xaf\xe1'
 
 
 @__builtin__