allow specifying parameter names in builtins

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Builtin.java

@@ -53,6 +53,8 @@
 
     boolean takesVarKeywordArgs() default false;
 
+    String[] parameterNames() default {};
+
     String[] keywordArguments() default {};
 
     boolean isPublic() default true;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltins.java

@@ -122,7 +122,7 @@ private static Arity createArity(Builtin builtin, boolean declaresExplicitSelf)
             maxNumPosArgs++;
         }
 
-        return new Arity(builtin.name(), minNumPosArgs, maxNumPosArgs, builtin.takesVarKeywordArgs(), builtin.takesVarArgs(), keywordNames);
+        return new Arity(builtin.name(), minNumPosArgs, maxNumPosArgs, builtin.takesVarKeywordArgs(), builtin.takesVarArgs(), builtin.parameterNames(), keywordNames.toArray(new Arity.KeywordName[0]));
     }
 
     private void setBuiltinFunction(String name, BoundBuiltinCallable<?> function) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/code/PCode.java

@@ -432,7 +432,7 @@ private int getMaxNumOfPositionalArgs() {
     }
 
     public Arity getArity() {
-        return new Arity(this.getName(), this.getMinNumOfPositionalArgs(), this.getMaxNumOfPositionalArgs(), this.takesVarKeywordArgs(), this.takesVarArgs(), this.getKeywordNames());
+        return new Arity(this.getName(), this.getMinNumOfPositionalArgs(), this.getMaxNumOfPositionalArgs(), this.takesVarKeywordArgs(), this.takesVarArgs(), null, this.getKeywordNames());
     }
 
     public RootCallTarget getRootCallTarget() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/Arity.java

@@ -52,18 +52,10 @@ public class Arity {
 
     public Arity(String functionName, int minNumOfPositionalArgs, int maxNumOfPositionalArgs,
                     boolean takesVarKeywordArgs, boolean takesVarArgs,
-                    KeywordName[] keywordNames) {
-        this(functionName, minNumOfPositionalArgs, maxNumOfPositionalArgs,
-                        takesVarKeywordArgs, takesVarArgs, false,
-                        null, keywordNames);
-    }
-
-    public Arity(String functionName, int minNumOfPositionalArgs, int maxNumOfPositionalArgs,
-                    boolean takesVarKeywordArgs, boolean takesVarArgs,
-                    List<KeywordName> keywordNames) {
+                    String[] parameterIds, KeywordName[] keywordNames) {
         this(functionName, minNumOfPositionalArgs, maxNumOfPositionalArgs,
                         takesVarKeywordArgs, takesVarArgs, false,
-                        null, keywordNames);
+                        parameterIds, keywordNames);
     }
 
     public Arity(String functionName, int minNumOfPositionalArgs, int maxNumOfPositionalArgs,
@@ -93,11 +85,11 @@ public Arity(String functionName, int minNumOfPositionalArgs, int maxNumOfPositi
     }
 
     public static Arity createOneArgumentWithVarKwArgs(String functionName) {
-        return new Arity(functionName, 1, 1, true, false, (KeywordName[]) null);
+        return new Arity(functionName, 1, 1, true, false, null, null);
     }
 
     public static Arity createVarArgsAndKwArgsOnly(String functionName) {
-        return new Arity(functionName, 0, 0, true, true, (KeywordName[]) null);
+        return new Arity(functionName, 0, 0, true, true, null, null);
     }
 
     @TruffleBoundary