Small style corrections.

Author: ppisl

graalpython/com.oracle.graal.python.test/src/tests/test_math.py

@@ -242,6 +242,7 @@ def testLog(self):
         self.ftest('log(32,2)', math.log(32,2), 5)
         self.ftest('log(10**40, 10)', math.log(10**40, 10), 40)
         self.ftest('log(10**40, 10**20)', math.log(10**40, 10**20), 2)
+        # TODO uncomment when GR-10346 will be fixed
         #self.ftest('log(10**1000)', math.log(10**1000), 2302.5850929940457)
         self.assertRaises(ValueError, math.log, -1.5)
         self.assertRaises(ValueError, math.log, -10**1000)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MathModuleBuiltins.java

@@ -1189,9 +1189,8 @@ private double executeRecursiveLogNode(Object value, Object base) {
 
         private static double logBigInteger(BigInteger val) {
             int blex = val.bitLength() - 1022; // any value in 60..1023 is ok
-            if (blex > 0)
-                val = val.shiftRight(blex);
-            double res = Math.log(val.doubleValue());
+            BigInteger value = blex > 0 ? val.shiftRight(blex) : val;
+            double res = Math.log(value.doubleValue());
             return blex > 0 ? res + blex * LOG2 : res;
         }
 
@@ -1212,7 +1211,7 @@ private double countBase(BigInteger base, ConditionProfile divByZero) {
         }
 
         @Specialization
-        public double log(long value, @SuppressWarnings("unused") PNone novalue,
+        public double log(long value, PNone novalue,
                         @Cached("createBinaryProfile()") ConditionProfile doNotFit) {
             return logDN(value, novalue, doNotFit);
         }
@@ -1316,7 +1315,7 @@ public double logPIPI(PInt value, PInt base,
         }
 
         @Specialization(guards = "!isNumber(value)")
-        public double logO(Object value, @SuppressWarnings("unused") PNone novalue,
+        public double logO(Object value, PNone novalue,
                         @Cached("createBinaryProfile()") ConditionProfile notNumber) {
             Object result = getRealNumber(value, getValueDispatchNode(), notNumber);
             return executeRecursiveLogNode(result, novalue);
@@ -1359,7 +1358,7 @@ private void raiseMathError(ConditionProfile doNotFit, boolean con) {
 
         private Object getRealNumber(Object object, LookupAndCallUnaryNode dispatchNode, ConditionProfile isNotRealNumber) {
             Object result = dispatchNode.executeObject(object);
-            if (result == PNone.NO_VALUE) {
+            if (isNotRealNumber.profile(result == PNone.NO_VALUE)) {
                 throw raise(TypeError, "must be real number, not %p", object);
             }
             return result;