[GR-16719] [GH-74] Make function.__dict__ writeable.

PullRequest: graalpython/565

Author: fangerer

graalpython/com.oracle.graal.python.test/src/tests/test_functions.py

@@ -236,3 +236,10 @@ def assign_code(x, y):
     assert_raises(ValueError, assign_code, foo, foobar_code)
     bazbar.__code__ = foobar_code
     assert bazbar() == (2,3)
+    
+
+def test_function_dict_writeable():
+    def foo(): pass
+    new_dict = { "customProp": "hello, world"}
+    foo.__dict__ = new_dict
+    assert foo.customProp == "hello, world"

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -55,6 +55,7 @@
 import com.oracle.graal.python.nodes.call.CallDispatchNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
+import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonTernaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.subscript.GetItemNode;
@@ -227,11 +228,17 @@ Object getModule(PBuiltinFunction self, Object value) {
         }
     }
 
-    @Builtin(name = __DICT__, minNumOfPositionalArgs = 1, isGetter = true)
+    @Builtin(name = __DICT__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
     @GenerateNodeFactory
-    abstract static class DictNode extends PythonUnaryBuiltinNode {
+    abstract static class DictNode extends PythonBinaryBuiltinNode {
         @Specialization
-        Object dict(PFunction self) {
+        PNone dict(PFunction self, PHashingCollection mapping) {
+            self.setDict(mapping);
+            return PNone.NONE;
+        }
+
+        @Specialization(guards = "isNoValue(mapping)")
+        Object dict(PFunction self, @SuppressWarnings("unused") PNone mapping) {
             PHashingCollection dict = self.getDict();
             if (dict == null) {
                 dict = factory().createDictFixedStorage(self);
@@ -240,9 +247,9 @@ Object dict(PFunction self) {
             return dict;
         }
 
-        @SuppressWarnings("unused")
         @Specialization
-        Object builtinCode(PBuiltinFunction self) {
+        @SuppressWarnings("unused")
+        Object builtinCode(PBuiltinFunction self, Object mapping) {
             throw raise(AttributeError, "'builtin_function_or_method' object has no attribute '__dict__'");
         }
     }